Adding export schedule as class button#48
Open
lieutenantlin wants to merge 1 commit into
Open
Conversation
Signed-off-by: FordoA455 <milobylin@gmail.com>
Collaborator
Author
|
@maxstrid can you take a look at the layout of the export buttons? There might need to be some changes to spacing to make it look better |
maxstrid
requested changes
May 14, 2024
| for (let i: number = 0; i < highestLength; i++) { | ||
| const row: ScheduleExportPeriodIds = { | ||
| const idRow: ScheduleExportPeriodIds = { | ||
| period1ClassIds: periods[0]["classes"][i] == undefined ? "" : periods[0]["classes"][i]['id'], |
Owner
There was a problem hiding this comment.
These don't need to be separate types, make it one type and just export class or id depending on the option
| <span>Export</span> | ||
| </CSVLink> | ||
| <div className='flex flex-row m-auto'> | ||
| <CSVLink |
Owner
There was a problem hiding this comment.
The spacing is fine here but I'd honestly prefer this to be a submenu if you could, or a modal which shows up and lets you choose between classes and ids. Or it might just be better to include the ids in the export as well as class names.
Collaborator
Author
There was a problem hiding this comment.
Can be resolved in #50, but just for the meeting with Ms. Morelli, it is fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making a button to export schedule as classes or ids