Dynamically pull in different palettes

[dpalay]

beadifier/src/app/palette/palette.service.ts

Line 24 in 84e05da

getAll(): Observable<Palette[]> {

Instead of listing all the csvs here, would it be easier to have the beadcolors project generate a simple txt file that lists all the csvs in the project, then this code would just reference the txt file and dynamically iterate through the listed files? Then adding new palettes (which, granted, probably won't be that common) wouldn't require any modification here.

[dpalay]

Tagging @maxcleme since you didn't get the notifications last time :)

[maxcleme]

@dpalay thanks for the mention, it works now, I got the notification 😂

Totally agree with you, to be honest I though I might had time to develop the API for beadcolors first, then we could easily have an endpoint to list all the available palettes and use it here instead of loading static csv in the application.

Sadly this obviously is not done yet. Using your approach would make it straightforward, however if I had to develop new features for Beadcolors (something else than adding/updating palette), I would better invest my time in the API.

Moreover, adding new palettes here (while waiting for the API) is a very small PR. I'm going to integrate the new one asap :)

[maxcleme]

@dpalay Both new palettes has been added.

However I would be glad to keep this issue open since it is not "properly fixed" I would say.

I would also remind me that I have to work on the beadcolors API to tackle this.

Regards.