From 129a13879ba0a480eb20fd09466b93ed7959b1c1 Mon Sep 17 00:00:00 2001 From: Claude Bot Date: Sun, 24 May 2026 11:56:32 +0800 Subject: [PATCH] feat: support rename server command - Add renameServer method to ConfigManager preserving key order - Register 'rename' command with 'mv' alias (both top-level and legacy) - Add comprehensive unit tests for rename functionality - Handle edge cases: non-existing server, duplicate name --- src/commands/server.ts | 20 +++++++++++++ src/core/config.ts | 24 +++++++++++++++ src/tests/unit/config.test.ts | 55 +++++++++++++++++++++++++++++++++++ 3 files changed, 99 insertions(+) diff --git a/src/commands/server.ts b/src/commands/server.ts index 9afc926..b0ca1ae 100644 --- a/src/commands/server.ts +++ b/src/commands/server.ts @@ -159,6 +159,15 @@ export const registerServerCommands = (program: Command) => { } }; + const renameServerAction = (oldName: string, newName: string) => { + try { + configManager.renameServer(oldName, newName); + console.log(chalk.green(`Server "${oldName}" renamed to "${newName}".`)); + } catch (error: any) { + console.error(chalk.red(error.message)); + } + }; + const updateServerAction = async (name: string | undefined, options: any) => { // If no server name provided, refresh all connections if (!name) { @@ -225,6 +234,12 @@ export const registerServerCommands = (program: Command) => { .description('Remove a server') .action(removeServerAction); + // Rename server command + program.command('rename ') + .alias('mv') + .description('Rename a server') + .action(renameServerAction); + // Update server command program.command('update [name]') .description('Update a server configuration or refresh all servers') @@ -257,6 +272,11 @@ export const registerServerCommands = (program: Command) => { .description('Remove a server') .action(removeServerAction); + serverCmd.command('rename ') + .alias('mv') + .description('Rename a server') + .action(renameServerAction); + serverCmd.command('update [name]') .description('Update a server configuration or refresh all servers') .option('--command ', 'New command') diff --git a/src/core/config.ts b/src/core/config.ts index 468e7f0..211be00 100644 --- a/src/core/config.ts +++ b/src/core/config.ts @@ -96,6 +96,30 @@ export class ConfigManager { this.saveConfig(config); } + renameServer(oldName: string, newName: string) { + const config = this.loadConfig(); + const current = config.mcpServers[oldName]; + if (!current) { + throw new Error(`Server with name "${oldName}" not found.`); + } + if (config.mcpServers[newName]) { + throw new Error(`Server with name "${newName}" already exists.`); + } + + // Insert newName in the same position as oldName, preserving key order + const newServers: Record = {}; + for (const [key, value] of Object.entries(config.mcpServers)) { + if (key === oldName) { + newServers[newName] = value; + } else { + newServers[key] = value; + } + } + + config.mcpServers = newServers; + this.saveConfig(config); + } + updateServer(name: string, updates: Partial) { const config = this.loadConfig(); const current = config.mcpServers[name]; diff --git a/src/tests/unit/config.test.ts b/src/tests/unit/config.test.ts index 6994a03..ca63fbe 100644 --- a/src/tests/unit/config.test.ts +++ b/src/tests/unit/config.test.ts @@ -166,6 +166,61 @@ describe('ConfigManager', () => { }); }); + describe('renameServer', () => { + it('should rename an existing server', () => { + manager.addServer('old-name', { + command: 'node', + args: ['--version'] + }); + + manager.renameServer('old-name', 'new-name'); + + expect(manager.getServer('old-name')).toBeUndefined(); + const renamed = manager.getServer('new-name'); + expect(renamed).toBeDefined(); + expect((renamed as any).command).toBe('node'); + expect((renamed as any).args).toEqual(['--version']); + }); + + it('should preserve key order after rename', () => { + manager.addServer('server-a', { command: 'a', args: [] }); + manager.addServer('server-b', { command: 'b', args: [] }); + manager.addServer('server-c', { command: 'c', args: [] }); + + manager.renameServer('server-b', 'server-b-renamed'); + + const servers = manager.listServers(); + expect(servers.map(s => s.name)).toEqual(['server-a', 'server-b-renamed', 'server-c']); + }); + + it('should throw error when renaming non-existing server', () => { + expect(() => manager.renameServer('non-existing', 'new-name')).toThrow('not found'); + }); + + it('should throw error when new name already exists', () => { + manager.addServer('server-1', { command: 'a', args: [] }); + manager.addServer('server-2', { command: 'b', args: [] }); + + expect(() => manager.renameServer('server-1', 'server-2')).toThrow('already exists'); + }); + + it('should preserve all server properties after rename', () => { + manager.addServer('full-server', { + command: 'node', + args: ['--version'], + disabled: true + }); + + manager.renameServer('full-server', 'renamed-server'); + + const renamed = manager.getServer('renamed-server'); + expect(renamed).toBeDefined(); + expect((renamed as any).command).toBe('node'); + expect((renamed as any).args).toEqual(['--version']); + expect((renamed as any).disabled).toBe(true); + }); + }); + describe('updateServer', () => { it('should update server configuration', () => { manager.addServer('to-update', {