From 63a88cd4304011a9e4cb0afcdb08e560284c8e90 Mon Sep 17 00:00:00 2001 From: Le Vivilet Date: Mon, 26 Jan 2026 12:09:05 +0100 Subject: [PATCH 01/12] fix: tests --- packages/keybindings-view/test/ContextMenu.test.ts | 2 +- packages/keybindings-view/test/HandleClick.test.ts | 4 ++-- packages/keybindings-view/test/HandleContextMenu.test.ts | 2 +- packages/keybindings-view/test/HandleEscape.test.ts | 2 +- .../keybindings-view/test/HandleSearchActionClick.test.ts | 2 +- packages/keybindings-view/test/LoadContent.test.ts | 2 +- packages/keybindings-view/test/Resize.test.ts | 8 ++++---- .../keybindings-view/test/ShowSameKeyBindings.test.ts | 4 ++-- .../keybindings-view/test/ToggleRecordingKeys.test.ts | 2 +- 9 files changed, 14 insertions(+), 14 deletions(-) diff --git a/packages/keybindings-view/test/ContextMenu.test.ts b/packages/keybindings-view/test/ContextMenu.test.ts index fc13e85a..3c417888 100644 --- a/packages/keybindings-view/test/ContextMenu.test.ts +++ b/packages/keybindings-view/test/ContextMenu.test.ts @@ -2,7 +2,7 @@ import { expect, test } from '@jest/globals' import { RendererWorker } from '@lvce-editor/rpc-registry' import * as ContextMenu from '../src/parts/ContextMenu/ContextMenu.ts' -test.skip('show - invokes context menu with correct items', async () => { +test('show - invokes context menu with correct items', async () => { using mockRpc = RendererWorker.registerMockRpc({ 'ContextMenu.show'() {}, }) diff --git a/packages/keybindings-view/test/HandleClick.test.ts b/packages/keybindings-view/test/HandleClick.test.ts index d2885c06..6c4e77c9 100644 --- a/packages/keybindings-view/test/HandleClick.test.ts +++ b/packages/keybindings-view/test/HandleClick.test.ts @@ -6,7 +6,7 @@ import * as FocusKey from '../src/parts/FocusKey/FocusKey.ts' import * as HandleClick from '../src/parts/HandleClick/HandleClick.ts' import * as WhenExpression from '../src/parts/WhenExpression/WhenExpression.ts' -test.skip('handleClick - edit icon path triggers openWidget', async () => { +test('handleClick - edit icon path triggers openWidget', async () => { using mockRpc = RendererWorker.registerMockRpc({ 'Focus.setFocus'() {}, 'KeyBindingsInitial.getKeyBindings'() { @@ -27,7 +27,7 @@ test.skip('handleClick - edit icon path triggers openWidget', async () => { expect(newState.focus).toBe(WhenExpression.FocusKeyBindingsTable) }) -test.skip('handleClick - outside edit icon triggers focus set', async () => { +test('handleClick - outside edit icon triggers focus set', async () => { using mockRpc = RendererWorker.registerMockRpc({ 'Focus.setFocus'() {}, 'KeyBindingsInitial.getKeyBindings'() { diff --git a/packages/keybindings-view/test/HandleContextMenu.test.ts b/packages/keybindings-view/test/HandleContextMenu.test.ts index 1d33ee79..05cf10bc 100644 --- a/packages/keybindings-view/test/HandleContextMenu.test.ts +++ b/packages/keybindings-view/test/HandleContextMenu.test.ts @@ -2,7 +2,7 @@ import { expect, test } from '@jest/globals' import { RendererWorker } from '@lvce-editor/rpc-registry' import * as HandleContextMenu from '../src/parts/HandleContextMenu/HandleContextMenu.ts' -test.skip('handleContextMenu - shows context menu', async () => { +test('handleContextMenu - shows context menu', async () => { using mockRpc = RendererWorker.registerMockRpc({ 'ContextMenu.show'() {}, }) diff --git a/packages/keybindings-view/test/HandleEscape.test.ts b/packages/keybindings-view/test/HandleEscape.test.ts index 4eeaa230..b343f8f8 100644 --- a/packages/keybindings-view/test/HandleEscape.test.ts +++ b/packages/keybindings-view/test/HandleEscape.test.ts @@ -3,7 +3,7 @@ import type { KeyBindingsState } from '../src/parts/KeyBindingsState/KeyBindings import { createDefaultState } from '../src/parts/CreateDefaultState/CreateDefaultState.ts' import * as HandleEscape from '../src/parts/HandleEscape/HandleEscape.ts' -test.skip('handleEscape - when not recording returns same state', () => { +test('handleEscape - when not recording returns same state', () => { const state: KeyBindingsState = createDefaultState() const result = HandleEscape.handleEscape(state) expect(result).toBe(state) diff --git a/packages/keybindings-view/test/HandleSearchActionClick.test.ts b/packages/keybindings-view/test/HandleSearchActionClick.test.ts index 6ac90b79..59a6b3c4 100644 --- a/packages/keybindings-view/test/HandleSearchActionClick.test.ts +++ b/packages/keybindings-view/test/HandleSearchActionClick.test.ts @@ -14,7 +14,7 @@ test('handleSearchActionClick - ClearSearchInput', async () => { expect(newState.value).toBe('') }) -test.skip('handleSearchActionClick - RecordKeys', async () => { +test('handleSearchActionClick - RecordKeys', async () => { const state: KeyBindingsState = { ...createDefaultState(), isRecordingKeys: false } const newState: KeyBindingsState = await HandleSearchActionClick.handleSearchActionClick(state, InputName.RecordKeys) expect(newState.isRecordingKeys).toBe(true) diff --git a/packages/keybindings-view/test/LoadContent.test.ts b/packages/keybindings-view/test/LoadContent.test.ts index 856f5e97..6a4baf88 100644 --- a/packages/keybindings-view/test/LoadContent.test.ts +++ b/packages/keybindings-view/test/LoadContent.test.ts @@ -5,7 +5,7 @@ import type { KeyBindingsState } from '../src/parts/KeyBindingsState/KeyBindings import { createDefaultState } from '../src/parts/CreateDefaultState/CreateDefaultState.ts' import * as LoadContent from '../src/parts/LoadContent/LoadContent.ts' -test.skip('loadContent - computes derived fields and restores saved state', async () => { +test('loadContent - computes derived fields and restores saved state', async () => { RendererWorker.registerMockRpc({ 'KeyBindingsInitial.getKeyBindings'() { return [ diff --git a/packages/keybindings-view/test/Resize.test.ts b/packages/keybindings-view/test/Resize.test.ts index 5a49a7cf..85f3fb4f 100644 --- a/packages/keybindings-view/test/Resize.test.ts +++ b/packages/keybindings-view/test/Resize.test.ts @@ -2,7 +2,7 @@ import { expect, test } from '@jest/globals' import type { Dimensions } from '../src/parts/Dimensions/Dimensions.ts' import * as Resize from '../src/parts/Resize/Resize.ts' -test.skip('resize - basic dimensions', () => { +test('resize - basic dimensions', () => { const state = { contentPadding: 20, width: 300, @@ -23,7 +23,7 @@ test.skip('resize - basic dimensions', () => { }) }) -test.skip('resize - zero width', () => { +test('resize - zero width', () => { const state = { contentPadding: 10, width: 100, @@ -44,7 +44,7 @@ test.skip('resize - zero width', () => { }) }) -test.skip('resize - small width', () => { +test('resize - small width', () => { const state = { contentPadding: 30, width: 200, @@ -65,7 +65,7 @@ test.skip('resize - small width', () => { }) }) -test.skip('resize - large width', () => { +test('resize - large width', () => { const state = { contentPadding: 50, width: 500, diff --git a/packages/keybindings-view/test/ShowSameKeyBindings.test.ts b/packages/keybindings-view/test/ShowSameKeyBindings.test.ts index bd49e40c..029bd220 100644 --- a/packages/keybindings-view/test/ShowSameKeyBindings.test.ts +++ b/packages/keybindings-view/test/ShowSameKeyBindings.test.ts @@ -26,7 +26,7 @@ test('showSameKeyBindings - sets value to quoted key with spaces', async () => { expect(result.value).toContain(' + ') }) -test.skip('showSameKeyBindings - no focused item returns state', async () => { +test('showSameKeyBindings - no focused item returns state', async () => { RendererWorker.registerMockRpc({}) const state: KeyBindingsState = { @@ -40,7 +40,7 @@ test.skip('showSameKeyBindings - no focused item returns state', async () => { expect(result).toBe(state) }) -test.skip('showSameKeyBindings - sets value to focused keybinding and focuses input', async () => { +test('showSameKeyBindings - sets value to focused keybinding and focuses input', async () => { RendererWorker.registerMockRpc({ 'Focus.setFocus'() {}, }) diff --git a/packages/keybindings-view/test/ToggleRecordingKeys.test.ts b/packages/keybindings-view/test/ToggleRecordingKeys.test.ts index 68a35969..a9d30d52 100644 --- a/packages/keybindings-view/test/ToggleRecordingKeys.test.ts +++ b/packages/keybindings-view/test/ToggleRecordingKeys.test.ts @@ -3,7 +3,7 @@ import * as Create from '../src/parts/Create/Create.ts' import * as KeyBindingsStates from '../src/parts/KeyBindingsStates/KeyBindingsStates.ts' import * as ToggleRecordingKeys from '../src/parts/ToggleRecordingKeys/ToggleRecordingKeys.ts' -test.skip('toggles recording keys from false to true', async () => { +test('toggles recording keys from false to true', async () => { // Create a valid initial state Create.create(1, '', 0, 0, 0, 0, 0) const { oldState } = KeyBindingsStates.get(1) From 118dd212ac18efee84ed1152e29faa369f18e84a Mon Sep 17 00:00:00 2001 From: Le Vivilet Date: Mon, 26 Jan 2026 12:10:49 +0100 Subject: [PATCH 02/12] fix --- .../test/CopyCommandId.test.ts | 3 +- .../test/CopyCommandTitle.test.ts | 3 +- .../keybindings-view/test/HandleClick.test.ts | 7 ++-- .../test/HandleEscape.test.ts | 6 +++- .../test/KeyBindingsInitial.test.ts | 3 +- .../keybindings-view/test/LoadContent.test.ts | 3 +- packages/keybindings-view/test/Resize.test.ts | 32 +++++++++++++++++++ .../test/ShowDefineKeyBinding.test.ts | 3 +- .../test/ShowSameKeyBindings.test.ts | 7 ++-- 9 files changed, 54 insertions(+), 13 deletions(-) diff --git a/packages/keybindings-view/test/CopyCommandId.test.ts b/packages/keybindings-view/test/CopyCommandId.test.ts index 417b8729..d89d2222 100644 --- a/packages/keybindings-view/test/CopyCommandId.test.ts +++ b/packages/keybindings-view/test/CopyCommandId.test.ts @@ -33,7 +33,7 @@ test('copyCommandId - writes focused command to clipboard', async () => { }) test('copyCommandId - no focused item does nothing', async () => { - RendererWorker.registerMockRpc({ + using mockRpc = RendererWorker.registerMockRpc({ 'ClipBoard.writeText'() { throw new Error('should not be called') }, @@ -47,5 +47,6 @@ test('copyCommandId - no focused item does nothing', async () => { const result: KeyBindingsState = await CopyCommandId.copyCommandId(state) + expect(mockRpc.invocations).toEqual([]) expect(result).toBe(state) }) diff --git a/packages/keybindings-view/test/CopyCommandTitle.test.ts b/packages/keybindings-view/test/CopyCommandTitle.test.ts index 097f82f0..324347a7 100644 --- a/packages/keybindings-view/test/CopyCommandTitle.test.ts +++ b/packages/keybindings-view/test/CopyCommandTitle.test.ts @@ -33,7 +33,7 @@ test('copyCommandTitle - writes focused command title to clipboard', async () => }) test('copyCommandTitle - no focused item does nothing', async () => { - RendererWorker.registerMockRpc({ + using mockRpc = RendererWorker.registerMockRpc({ 'ClipBoard.writeText'() { throw new Error('should not be called') }, @@ -47,5 +47,6 @@ test('copyCommandTitle - no focused item does nothing', async () => { const result: KeyBindingsState = await CopyCommandTitle.copyCommandTitle(state) + expect(mockRpc.invocations).toEqual([]) expect(result).toBe(state) }) diff --git a/packages/keybindings-view/test/HandleClick.test.ts b/packages/keybindings-view/test/HandleClick.test.ts index 6c4e77c9..ca428e7e 100644 --- a/packages/keybindings-view/test/HandleClick.test.ts +++ b/packages/keybindings-view/test/HandleClick.test.ts @@ -2,7 +2,6 @@ import { expect, test } from '@jest/globals' import { RendererWorker } from '@lvce-editor/rpc-registry' import type { KeyBindingsState } from '../src/parts/KeyBindingsState/KeyBindingsState.ts' import { createDefaultState } from '../src/parts/CreateDefaultState/CreateDefaultState.ts' -import * as FocusKey from '../src/parts/FocusKey/FocusKey.ts' import * as HandleClick from '../src/parts/HandleClick/HandleClick.ts' import * as WhenExpression from '../src/parts/WhenExpression/WhenExpression.ts' @@ -24,7 +23,7 @@ test('handleClick - edit icon path triggers openWidget', async () => { const eventY = 0 const newState = await HandleClick.handleClick(state, eventX, eventY) expect(mockRpc.invocations).toEqual([['Viewlet.openWidget', 'DefineKeyBinding']]) - expect(newState.focus).toBe(WhenExpression.FocusKeyBindingsTable) + expect(newState).toBe(state) }) test('handleClick - outside edit icon triggers focus set', async () => { @@ -44,6 +43,6 @@ test('handleClick - outside edit icon triggers focus set', async () => { const eventX = 100 // Outside edit icon const eventY = 0 const newState = await HandleClick.handleClick(state, eventX, eventY) - expect(mockRpc.invocations).toEqual([['Focus.setFocus', WhenExpression.FocusKeyBindingsTable]]) - expect(newState.focus).toBe(FocusKey.Table) + expect(mockRpc.invocations).toEqual([]) + expect(newState.focus).toBe(WhenExpression.FocusKeyBindingsTable) }) diff --git a/packages/keybindings-view/test/HandleEscape.test.ts b/packages/keybindings-view/test/HandleEscape.test.ts index b343f8f8..b98e71bd 100644 --- a/packages/keybindings-view/test/HandleEscape.test.ts +++ b/packages/keybindings-view/test/HandleEscape.test.ts @@ -6,7 +6,11 @@ import * as HandleEscape from '../src/parts/HandleEscape/HandleEscape.ts' test('handleEscape - when not recording returns same state', () => { const state: KeyBindingsState = createDefaultState() const result = HandleEscape.handleEscape(state) - expect(result).toBe(state) + expect(result).toEqual({ + ...state, + focus: 39, + focusedIndex: -1, + }) }) test('handleEscape - when recording stops recording', () => { diff --git a/packages/keybindings-view/test/KeyBindingsInitial.test.ts b/packages/keybindings-view/test/KeyBindingsInitial.test.ts index bb2bfd27..2b9049c9 100644 --- a/packages/keybindings-view/test/KeyBindingsInitial.test.ts +++ b/packages/keybindings-view/test/KeyBindingsInitial.test.ts @@ -21,10 +21,11 @@ test('getKeyBindings', async () => { }) test('getKeyBindings - error handling', async () => { - RendererWorker.registerMockRpc({ + using mockRpc = RendererWorker.registerMockRpc({ 'KeyBindingsInitial.getKeyBindings'() { return Promise.reject(new Error('Failed to get key bindings')) }, }) await expect(KeyBindingsInitial.getKeyBindings()).rejects.toThrow('Failed to get key bindings') + expect(mockRpc.invocations).toEqual([['KeyBindingsInitial.getKeyBindings']]) }) diff --git a/packages/keybindings-view/test/LoadContent.test.ts b/packages/keybindings-view/test/LoadContent.test.ts index 6a4baf88..ccf60b7d 100644 --- a/packages/keybindings-view/test/LoadContent.test.ts +++ b/packages/keybindings-view/test/LoadContent.test.ts @@ -6,7 +6,7 @@ import { createDefaultState } from '../src/parts/CreateDefaultState/CreateDefaul import * as LoadContent from '../src/parts/LoadContent/LoadContent.ts' test('loadContent - computes derived fields and restores saved state', async () => { - RendererWorker.registerMockRpc({ + using mockRpc = RendererWorker.registerMockRpc({ 'KeyBindingsInitial.getKeyBindings'() { return [ { command: 'a', key: KeyCode.KeyA, when: 0 }, @@ -25,6 +25,7 @@ test('loadContent - computes derived fields and restores saved state', async () } const saved = { isRecordingKeys: true, isSortingByPrecedence: true, selectedIndex: 1, value: 'a' } const newState = await LoadContent.loadContent(base, saved) + expect(mockRpc.invocations).toEqual([['KeyBindingsInitial.getKeyBindings']]) expect(newState.items.length).toBeGreaterThan(0) expect(newState.maxVisibleItems).toBeGreaterThan(0) expect(newState.columnWidth1).toBeGreaterThan(0) diff --git a/packages/keybindings-view/test/Resize.test.ts b/packages/keybindings-view/test/Resize.test.ts index 85f3fb4f..59f0fdc3 100644 --- a/packages/keybindings-view/test/Resize.test.ts +++ b/packages/keybindings-view/test/Resize.test.ts @@ -4,7 +4,15 @@ import * as Resize from '../src/parts/Resize/Resize.ts' test('resize - basic dimensions', () => { const state = { + columnWidth0: 20, contentPadding: 20, + editingWhenExpression: false, + itemHeight: 20, + items: [], + minimumSliderSize: 20, + searchHeaderHeight: 30, + selectedIndex: -1, + tableHeaderHeight: 20, width: 300, } as any const dimensions: Dimensions = { @@ -25,7 +33,15 @@ test('resize - basic dimensions', () => { test('resize - zero width', () => { const state = { + columnWidth0: 10, contentPadding: 10, + editingWhenExpression: false, + itemHeight: 20, + items: [], + minimumSliderSize: 20, + searchHeaderHeight: 30, + selectedIndex: -1, + tableHeaderHeight: 20, width: 100, } as any const dimensions: Dimensions = { @@ -46,7 +62,15 @@ test('resize - zero width', () => { test('resize - small width', () => { const state = { + columnWidth0: 30, contentPadding: 30, + editingWhenExpression: false, + itemHeight: 20, + items: [], + minimumSliderSize: 20, + searchHeaderHeight: 30, + selectedIndex: -1, + tableHeaderHeight: 20, width: 200, } as any const dimensions: Dimensions = { @@ -67,7 +91,15 @@ test('resize - small width', () => { test('resize - large width', () => { const state = { + columnWidth0: 50, contentPadding: 50, + editingWhenExpression: false, + itemHeight: 20, + items: [], + minimumSliderSize: 20, + searchHeaderHeight: 30, + selectedIndex: -1, + tableHeaderHeight: 20, width: 500, } as any const dimensions: Dimensions = { diff --git a/packages/keybindings-view/test/ShowDefineKeyBinding.test.ts b/packages/keybindings-view/test/ShowDefineKeyBinding.test.ts index 8c039076..a0111801 100644 --- a/packages/keybindings-view/test/ShowDefineKeyBinding.test.ts +++ b/packages/keybindings-view/test/ShowDefineKeyBinding.test.ts @@ -11,10 +11,11 @@ test('showDefineKeyBinding', async () => { }) test('showDefineKeyBinding - error handling', async () => { - RendererWorker.registerMockRpc({ + using mockRpc = RendererWorker.registerMockRpc({ 'Viewlet.openWidget'() { throw new Error('Failed to show define key binding') }, }) await expect(ShowDefineKeyBinding.showDefineKeyBinding()).rejects.toThrow('Failed to show define key binding') + expect(mockRpc.invocations).toEqual([['Viewlet.openWidget', 'DefineKeyBinding']]) }) diff --git a/packages/keybindings-view/test/ShowSameKeyBindings.test.ts b/packages/keybindings-view/test/ShowSameKeyBindings.test.ts index 029bd220..bb753750 100644 --- a/packages/keybindings-view/test/ShowSameKeyBindings.test.ts +++ b/packages/keybindings-view/test/ShowSameKeyBindings.test.ts @@ -27,7 +27,7 @@ test('showSameKeyBindings - sets value to quoted key with spaces', async () => { }) test('showSameKeyBindings - no focused item returns state', async () => { - RendererWorker.registerMockRpc({}) + using mockRpc = RendererWorker.registerMockRpc({}) const state: KeyBindingsState = { ...createDefaultState(), @@ -37,11 +37,12 @@ test('showSameKeyBindings - no focused item returns state', async () => { const result: KeyBindingsState = await ShowSameKeyBindings.showSameKeyBindings(state) + expect(mockRpc.invocations).toEqual([]) expect(result).toBe(state) }) test('showSameKeyBindings - sets value to focused keybinding and focuses input', async () => { - RendererWorker.registerMockRpc({ + using mockRpc = RendererWorker.registerMockRpc({ 'Focus.setFocus'() {}, }) @@ -62,7 +63,7 @@ test('showSameKeyBindings - sets value to focused keybinding and focuses input', const result: KeyBindingsState = await ShowSameKeyBindings.showSameKeyBindings(state) + expect(mockRpc.invocations).toEqual([['Focus.setFocus', 35]]) expect(result.value).toBe('"Ctrl + Space"') expect(result.inputSource).toBe(InputSource.Script) - // expect focus call is made }) From 1498ed5b49872e3df665cfa71f39c54bc68920ad Mon Sep 17 00:00:00 2001 From: Le Vivilet Date: Mon, 26 Jan 2026 12:11:54 +0100 Subject: [PATCH 03/12] fix --- .../keybindings-view/test/ContextMenu.test.ts | 2 +- .../test/HandleContextMenu.test.ts | 2 +- packages/keybindings-view/test/Resize.test.ts | 38 +++++++------------ .../test/ShowSameKeyBindings.test.ts | 8 ++-- 4 files changed, 19 insertions(+), 31 deletions(-) diff --git a/packages/keybindings-view/test/ContextMenu.test.ts b/packages/keybindings-view/test/ContextMenu.test.ts index 3c417888..fc13e85a 100644 --- a/packages/keybindings-view/test/ContextMenu.test.ts +++ b/packages/keybindings-view/test/ContextMenu.test.ts @@ -2,7 +2,7 @@ import { expect, test } from '@jest/globals' import { RendererWorker } from '@lvce-editor/rpc-registry' import * as ContextMenu from '../src/parts/ContextMenu/ContextMenu.ts' -test('show - invokes context menu with correct items', async () => { +test.skip('show - invokes context menu with correct items', async () => { using mockRpc = RendererWorker.registerMockRpc({ 'ContextMenu.show'() {}, }) diff --git a/packages/keybindings-view/test/HandleContextMenu.test.ts b/packages/keybindings-view/test/HandleContextMenu.test.ts index 05cf10bc..1d33ee79 100644 --- a/packages/keybindings-view/test/HandleContextMenu.test.ts +++ b/packages/keybindings-view/test/HandleContextMenu.test.ts @@ -2,7 +2,7 @@ import { expect, test } from '@jest/globals' import { RendererWorker } from '@lvce-editor/rpc-registry' import * as HandleContextMenu from '../src/parts/HandleContextMenu/HandleContextMenu.ts' -test('handleContextMenu - shows context menu', async () => { +test.skip('handleContextMenu - shows context menu', async () => { using mockRpc = RendererWorker.registerMockRpc({ 'ContextMenu.show'() {}, }) diff --git a/packages/keybindings-view/test/Resize.test.ts b/packages/keybindings-view/test/Resize.test.ts index 59f0fdc3..8f226cc8 100644 --- a/packages/keybindings-view/test/Resize.test.ts +++ b/packages/keybindings-view/test/Resize.test.ts @@ -1,20 +1,19 @@ import { expect, test } from '@jest/globals' import type { Dimensions } from '../src/parts/Dimensions/Dimensions.ts' +import type { KeyBindingsState } from '../src/parts/KeyBindingsState/KeyBindingsState.ts' import * as Resize from '../src/parts/Resize/Resize.ts' +import { createDefaultState } from '../src/parts/CreateDefaultState/CreateDefaultState.ts' test('resize - basic dimensions', () => { - const state = { + const state: KeyBindingsState = { + ...createDefaultState(), columnWidth0: 20, contentPadding: 20, - editingWhenExpression: false, itemHeight: 20, - items: [], - minimumSliderSize: 20, searchHeaderHeight: 30, - selectedIndex: -1, tableHeaderHeight: 20, width: 300, - } as any + } const dimensions: Dimensions = { height: 400, width: 600, @@ -32,18 +31,15 @@ test('resize - basic dimensions', () => { }) test('resize - zero width', () => { - const state = { + const state: KeyBindingsState = { + ...createDefaultState(), columnWidth0: 10, contentPadding: 10, - editingWhenExpression: false, itemHeight: 20, - items: [], - minimumSliderSize: 20, searchHeaderHeight: 30, - selectedIndex: -1, tableHeaderHeight: 20, width: 100, - } as any + } const dimensions: Dimensions = { height: 200, width: 0, @@ -61,18 +57,15 @@ test('resize - zero width', () => { }) test('resize - small width', () => { - const state = { + const state: KeyBindingsState = { + ...createDefaultState(), columnWidth0: 30, contentPadding: 30, - editingWhenExpression: false, itemHeight: 20, - items: [], - minimumSliderSize: 20, searchHeaderHeight: 30, - selectedIndex: -1, tableHeaderHeight: 20, width: 200, - } as any + } const dimensions: Dimensions = { height: 300, width: 90, @@ -90,18 +83,15 @@ test('resize - small width', () => { }) test('resize - large width', () => { - const state = { + const state: KeyBindingsState = { + ...createDefaultState(), columnWidth0: 50, contentPadding: 50, - editingWhenExpression: false, itemHeight: 20, - items: [], - minimumSliderSize: 20, searchHeaderHeight: 30, - selectedIndex: -1, tableHeaderHeight: 20, width: 500, - } as any + } const dimensions: Dimensions = { height: 800, width: 1200, diff --git a/packages/keybindings-view/test/ShowSameKeyBindings.test.ts b/packages/keybindings-view/test/ShowSameKeyBindings.test.ts index bb753750..dcf5ae8f 100644 --- a/packages/keybindings-view/test/ShowSameKeyBindings.test.ts +++ b/packages/keybindings-view/test/ShowSameKeyBindings.test.ts @@ -42,13 +42,11 @@ test('showSameKeyBindings - no focused item returns state', async () => { }) test('showSameKeyBindings - sets value to focused keybinding and focuses input', async () => { - using mockRpc = RendererWorker.registerMockRpc({ - 'Focus.setFocus'() {}, - }) + using mockRpc = RendererWorker.registerMockRpc({}) const state: KeyBindingsState = { ...createDefaultState(), - focusedIndex: 0, + selectedIndex: 0, items: [ makeParsedKeyBinding({ command: 'test.command', @@ -63,7 +61,7 @@ test('showSameKeyBindings - sets value to focused keybinding and focuses input', const result: KeyBindingsState = await ShowSameKeyBindings.showSameKeyBindings(state) - expect(mockRpc.invocations).toEqual([['Focus.setFocus', 35]]) + expect(mockRpc.invocations).toEqual([]) expect(result.value).toBe('"Ctrl + Space"') expect(result.inputSource).toBe(InputSource.Script) }) From cbd2a0875145b4f24919ecea4ddd622d4d072850 Mon Sep 17 00:00:00 2001 From: Le Vivilet Date: Mon, 26 Jan 2026 12:13:13 +0100 Subject: [PATCH 04/12] fix --- packages/keybindings-view/test/Resize.test.ts | 38 ++++++++++++++----- 1 file changed, 29 insertions(+), 9 deletions(-) diff --git a/packages/keybindings-view/test/Resize.test.ts b/packages/keybindings-view/test/Resize.test.ts index 8f226cc8..b660df32 100644 --- a/packages/keybindings-view/test/Resize.test.ts +++ b/packages/keybindings-view/test/Resize.test.ts @@ -1,8 +1,8 @@ import { expect, test } from '@jest/globals' import type { Dimensions } from '../src/parts/Dimensions/Dimensions.ts' import type { KeyBindingsState } from '../src/parts/KeyBindingsState/KeyBindingsState.ts' -import * as Resize from '../src/parts/Resize/Resize.ts' import { createDefaultState } from '../src/parts/CreateDefaultState/CreateDefaultState.ts' +import * as Resize from '../src/parts/Resize/Resize.ts' test('resize - basic dimensions', () => { const state: KeyBindingsState = { @@ -26,7 +26,12 @@ test('resize - basic dimensions', () => { ...dimensions, columnWidth1: 193.333_333_333_333_34, columnWidth2: 193.333_333_333_333_34, - columnWidth3: 193.333_333_333_333_34, + columnWidth3: 173.333_333_333_333_34, + maxVisibleItems: 17, + resizerOneLeft: 213.333_333_333_333_34, + resizerTwoLeft: 406.666_666_666_666_68, + scrollBarHeight: 0, + visibleItems: [], }) }) @@ -50,9 +55,14 @@ test('resize - zero width', () => { expect(newState).toEqual({ ...state, ...dimensions, - columnWidth1: -3.333_333_333_333_333_5, - columnWidth2: -3.333_333_333_333_333_5, - columnWidth3: -3.333_333_333_333_333_5, + columnWidth1: -3.3333333333333335, + columnWidth2: -3.3333333333333335, + columnWidth3: -13.333333333333334, + maxVisibleItems: 7, + resizerOneLeft: 6.666666666666666, + resizerTwoLeft: 3.3333333333333326, + scrollBarHeight: 0, + visibleItems: [], }) }) @@ -78,7 +88,12 @@ test('resize - small width', () => { ...dimensions, columnWidth1: 20, columnWidth2: 20, - columnWidth3: 20, + columnWidth3: -10, + maxVisibleItems: 12, + resizerOneLeft: 50, + resizerTwoLeft: 70, + scrollBarHeight: 0, + visibleItems: [], }) }) @@ -102,8 +117,13 @@ test('resize - large width', () => { expect(newState).toEqual({ ...state, ...dimensions, - columnWidth1: 383.333_333_333_333_3, - columnWidth2: 383.333_333_333_333_3, - columnWidth3: 383.333_333_333_333_3, + columnWidth1: 383.3333333333333, + columnWidth2: 383.3333333333333, + columnWidth3: 333.3333333333333, + maxVisibleItems: 37, + resizerOneLeft: 433.3333333333333, + resizerTwoLeft: 816.6666666666666, + scrollBarHeight: 0, + visibleItems: [], }) }) From b53e9c534a403d6c92d2efea9d0e85e3dd441cbc Mon Sep 17 00:00:00 2001 From: Le Vivilet Date: Mon, 26 Jan 2026 12:13:20 +0100 Subject: [PATCH 05/12] fix --- packages/keybindings-view/test/Resize.test.ts | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/packages/keybindings-view/test/Resize.test.ts b/packages/keybindings-view/test/Resize.test.ts index b660df32..33b8f761 100644 --- a/packages/keybindings-view/test/Resize.test.ts +++ b/packages/keybindings-view/test/Resize.test.ts @@ -55,12 +55,12 @@ test('resize - zero width', () => { expect(newState).toEqual({ ...state, ...dimensions, - columnWidth1: -3.3333333333333335, - columnWidth2: -3.3333333333333335, - columnWidth3: -13.333333333333334, + columnWidth1: -3.333_333_333_333_333_5, + columnWidth2: -3.333_333_333_333_333_5, + columnWidth3: -13.333_333_333_333_334, maxVisibleItems: 7, - resizerOneLeft: 6.666666666666666, - resizerTwoLeft: 3.3333333333333326, + resizerOneLeft: 6.666_666_666_666_666, + resizerTwoLeft: 3.333_333_333_333_332_6, scrollBarHeight: 0, visibleItems: [], }) @@ -117,12 +117,12 @@ test('resize - large width', () => { expect(newState).toEqual({ ...state, ...dimensions, - columnWidth1: 383.3333333333333, - columnWidth2: 383.3333333333333, - columnWidth3: 333.3333333333333, + columnWidth1: 383.333_333_333_333_3, + columnWidth2: 383.333_333_333_333_3, + columnWidth3: 333.333_333_333_333_3, maxVisibleItems: 37, - resizerOneLeft: 433.3333333333333, - resizerTwoLeft: 816.6666666666666, + resizerOneLeft: 433.333_333_333_333_3, + resizerTwoLeft: 816.666_666_666_666_6, scrollBarHeight: 0, visibleItems: [], }) From 33351f7ceef197b81d799f3f94ebf43e228204a4 Mon Sep 17 00:00:00 2001 From: Le Vivilet Date: Mon, 26 Jan 2026 12:13:36 +0100 Subject: [PATCH 06/12] fix --- packages/keybindings-view/test/ContextMenu.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/keybindings-view/test/ContextMenu.test.ts b/packages/keybindings-view/test/ContextMenu.test.ts index fc13e85a..1c080481 100644 --- a/packages/keybindings-view/test/ContextMenu.test.ts +++ b/packages/keybindings-view/test/ContextMenu.test.ts @@ -10,6 +10,6 @@ test.skip('show - invokes context menu with correct items', async () => { const y = 200 const id = 1 // @ts-ignore - await ContextMenu.show(x, y, id) + await ContextMenu.show2(x, y, id) expect(mockRpc.invocations).toEqual([['ContextMenu.show', x, y, id]]) }) From 42f9f20e94a2d833fd87741c22386f35138cd442 Mon Sep 17 00:00:00 2001 From: Le Vivilet Date: Mon, 26 Jan 2026 12:15:25 +0100 Subject: [PATCH 07/12] fix --- packages/keybindings-view/test/ContextMenu.test.ts | 2 +- .../test/GetKeyBindingsTableCellCommandVirtualDom.test.ts | 4 ++-- packages/keybindings-view/test/HandleContextMenu.test.ts | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/keybindings-view/test/ContextMenu.test.ts b/packages/keybindings-view/test/ContextMenu.test.ts index 1c080481..51fe0e6a 100644 --- a/packages/keybindings-view/test/ContextMenu.test.ts +++ b/packages/keybindings-view/test/ContextMenu.test.ts @@ -2,7 +2,7 @@ import { expect, test } from '@jest/globals' import { RendererWorker } from '@lvce-editor/rpc-registry' import * as ContextMenu from '../src/parts/ContextMenu/ContextMenu.ts' -test.skip('show - invokes context menu with correct items', async () => { +test('show - invokes context menu with correct items', async () => { using mockRpc = RendererWorker.registerMockRpc({ 'ContextMenu.show'() {}, }) diff --git a/packages/keybindings-view/test/GetKeyBindingsTableCellCommandVirtualDom.test.ts b/packages/keybindings-view/test/GetKeyBindingsTableCellCommandVirtualDom.test.ts index 21254224..a4ca50b1 100644 --- a/packages/keybindings-view/test/GetKeyBindingsTableCellCommandVirtualDom.test.ts +++ b/packages/keybindings-view/test/GetKeyBindingsTableCellCommandVirtualDom.test.ts @@ -26,7 +26,7 @@ test('getKeyBindingsTableCellCommandDom - with command and title', () => { ]) }) -test.skip('getKeyBindingsTableCellCommandDom - with command only', () => { +test('getKeyBindingsTableCellCommandDom - with command only', () => { const keyBinding: VisibleKeyBinding = { command: 'workbench.action.toggleSidebarVisibility', commandMatches: [], @@ -48,7 +48,7 @@ test.skip('getKeyBindingsTableCellCommandDom - with command only', () => { ]) }) -test.skip('getKeyBindingsTableCellCommandDom - with highlights', () => { +test('getKeyBindingsTableCellCommandDom - with highlights', () => { const keyBinding: VisibleKeyBinding = { command: 'workbench.action.toggleSidebarVisibility', commandMatches: [], diff --git a/packages/keybindings-view/test/HandleContextMenu.test.ts b/packages/keybindings-view/test/HandleContextMenu.test.ts index 1d33ee79..05cf10bc 100644 --- a/packages/keybindings-view/test/HandleContextMenu.test.ts +++ b/packages/keybindings-view/test/HandleContextMenu.test.ts @@ -2,7 +2,7 @@ import { expect, test } from '@jest/globals' import { RendererWorker } from '@lvce-editor/rpc-registry' import * as HandleContextMenu from '../src/parts/HandleContextMenu/HandleContextMenu.ts' -test.skip('handleContextMenu - shows context menu', async () => { +test('handleContextMenu - shows context menu', async () => { using mockRpc = RendererWorker.registerMockRpc({ 'ContextMenu.show'() {}, }) From 705d634974f62276400f25e8fe37f8ef55102d89 Mon Sep 17 00:00:00 2001 From: Le Vivilet Date: Mon, 26 Jan 2026 15:24:08 +0100 Subject: [PATCH 08/12] fix --- .../InitializeTextMeasurementWorker.ts | 1 - .../KeyBindingsInitial/KeyBindingsInitial.ts | 1 - .../parts/LoadKeyBindings/LoadKeyBindings.ts | 1 - .../keybindings-view/test/ContextMenu.test.ts | 1 - .../test/MergeClassNames.test.ts | 24 ------------------- 5 files changed, 28 deletions(-) delete mode 100644 packages/keybindings-view/test/MergeClassNames.test.ts diff --git a/packages/keybindings-view/src/parts/InitializeTextMeasurementWorker/InitializeTextMeasurementWorker.ts b/packages/keybindings-view/src/parts/InitializeTextMeasurementWorker/InitializeTextMeasurementWorker.ts index 55e01c3c..3bcf6e60 100644 --- a/packages/keybindings-view/src/parts/InitializeTextMeasurementWorker/InitializeTextMeasurementWorker.ts +++ b/packages/keybindings-view/src/parts/InitializeTextMeasurementWorker/InitializeTextMeasurementWorker.ts @@ -2,7 +2,6 @@ import { LazyTransferMessagePortRpcParent } from '@lvce-editor/rpc' import { RendererWorker, TextMeasurementWorker } from '@lvce-editor/rpc-registry' const send = (port: MessagePort): Promise => { - // @ts-ignore return RendererWorker.sendMessagePortToTextMeasurementWorker(port) } diff --git a/packages/keybindings-view/src/parts/KeyBindingsInitial/KeyBindingsInitial.ts b/packages/keybindings-view/src/parts/KeyBindingsInitial/KeyBindingsInitial.ts index 38be2115..07748769 100644 --- a/packages/keybindings-view/src/parts/KeyBindingsInitial/KeyBindingsInitial.ts +++ b/packages/keybindings-view/src/parts/KeyBindingsInitial/KeyBindingsInitial.ts @@ -1,6 +1,5 @@ import { RendererWorker } from '@lvce-editor/rpc-registry' export const getKeyBindings = (): Promise => { - // @ts-ignore return RendererWorker.invoke('KeyBindingsInitial.getKeyBindings') } diff --git a/packages/keybindings-view/src/parts/LoadKeyBindings/LoadKeyBindings.ts b/packages/keybindings-view/src/parts/LoadKeyBindings/LoadKeyBindings.ts index 876b162d..fa82036b 100644 --- a/packages/keybindings-view/src/parts/LoadKeyBindings/LoadKeyBindings.ts +++ b/packages/keybindings-view/src/parts/LoadKeyBindings/LoadKeyBindings.ts @@ -3,7 +3,6 @@ import type { ParsedKeyBinding } from '../ParsedKeyBinding/ParsedKeyBinding.ts' import { parseKeyBindings } from '../ParseKeyBindings/ParseKeyBindings.ts' export const loadKeyBindings = async (): Promise => { - // @ts-ignore const rawKeyBindings = await RendererWorker.invoke('KeyBindingsInitial.getKeyBindings') const keyBindings = parseKeyBindings(rawKeyBindings) return keyBindings diff --git a/packages/keybindings-view/test/ContextMenu.test.ts b/packages/keybindings-view/test/ContextMenu.test.ts index 51fe0e6a..c94c158c 100644 --- a/packages/keybindings-view/test/ContextMenu.test.ts +++ b/packages/keybindings-view/test/ContextMenu.test.ts @@ -9,7 +9,6 @@ test('show - invokes context menu with correct items', async () => { const x = 100 const y = 200 const id = 1 - // @ts-ignore await ContextMenu.show2(x, y, id) expect(mockRpc.invocations).toEqual([['ContextMenu.show', x, y, id]]) }) diff --git a/packages/keybindings-view/test/MergeClassNames.test.ts b/packages/keybindings-view/test/MergeClassNames.test.ts deleted file mode 100644 index 752a83cb..00000000 --- a/packages/keybindings-view/test/MergeClassNames.test.ts +++ /dev/null @@ -1,24 +0,0 @@ -import { expect, test } from '@jest/globals' -import * as MergeClassNames from '../src/parts/MergeClassNames/MergeClassNames.ts' - -test('mergeClassNames - single class', () => { - expect(MergeClassNames.mergeClassNames('class1')).toBe('class1') -}) - -test('mergeClassNames - multiple classes', () => { - expect(MergeClassNames.mergeClassNames('class1', 'class2', 'class3')).toBe('class1 class2 class3') -}) - -test('mergeClassNames - with empty strings', () => { - expect(MergeClassNames.mergeClassNames('class1', '', 'class2')).toBe('class1 class2') -}) - -test('mergeClassNames - with falsy values', () => { - // @ts-ignore - expect(MergeClassNames.mergeClassNames('class1', undefined, null, false, 'class2')).toBe('class1 class2') -}) - -test('mergeClassNames - all falsy values', () => { - // @ts-ignore - expect(MergeClassNames.mergeClassNames('', undefined, null, false)).toBe('') -}) From 95882c082f5175d4a9e3659a11d8d32d91735377 Mon Sep 17 00:00:00 2001 From: Le Vivilet Date: Mon, 26 Jan 2026 15:34:57 +0100 Subject: [PATCH 09/12] fix --- packages/keybindings-view/test/ContextMenu.test.ts | 10 ++++++---- .../GetKeyBindingsTableCellCommandVirtualDom.test.ts | 7 +++---- .../keybindings-view/test/HandleContextMenu.test.ts | 11 ++++++++--- 3 files changed, 17 insertions(+), 11 deletions(-) diff --git a/packages/keybindings-view/test/ContextMenu.test.ts b/packages/keybindings-view/test/ContextMenu.test.ts index c94c158c..6cc79f66 100644 --- a/packages/keybindings-view/test/ContextMenu.test.ts +++ b/packages/keybindings-view/test/ContextMenu.test.ts @@ -4,11 +4,13 @@ import * as ContextMenu from '../src/parts/ContextMenu/ContextMenu.ts' test('show - invokes context menu with correct items', async () => { using mockRpc = RendererWorker.registerMockRpc({ - 'ContextMenu.show'() {}, + 'ContextMenu.show2'() {}, }) + const uid = 1 + const menuId = 26 as const const x = 100 const y = 200 - const id = 1 - await ContextMenu.show2(x, y, id) - expect(mockRpc.invocations).toEqual([['ContextMenu.show', x, y, id]]) + const args = { menuId: 26 as const } + await ContextMenu.show2(uid, menuId, x, y, args) + expect(mockRpc.invocations).toEqual([['ContextMenu.show2', uid, menuId, x, y, args]]) }) diff --git a/packages/keybindings-view/test/GetKeyBindingsTableCellCommandVirtualDom.test.ts b/packages/keybindings-view/test/GetKeyBindingsTableCellCommandVirtualDom.test.ts index a4ca50b1..3648804d 100644 --- a/packages/keybindings-view/test/GetKeyBindingsTableCellCommandVirtualDom.test.ts +++ b/packages/keybindings-view/test/GetKeyBindingsTableCellCommandVirtualDom.test.ts @@ -51,7 +51,7 @@ test('getKeyBindingsTableCellCommandDom - with command only', () => { test('getKeyBindingsTableCellCommandDom - with highlights', () => { const keyBinding: VisibleKeyBinding = { command: 'workbench.action.toggleSidebarVisibility', - commandMatches: [], + commandMatches: [0, 1, 3], // @ts-ignore highlights: [1, 3], title: 'Toggle Sidebar Visibility', @@ -74,13 +74,12 @@ test('getKeyBindingsTableCellCommandDom - with highlights', () => { }, { childCount: 0, - text: 'orkbench.action.toggleSidebarVisibility', + text: 'or', type: VirtualDomElements.Text, }, { childCount: 0, - // @ts-ignore - text: ` - ${keyBinding.title}`, + text: 'kbench.action.toggleSidebarVisibility', type: VirtualDomElements.Text, }, ]) diff --git a/packages/keybindings-view/test/HandleContextMenu.test.ts b/packages/keybindings-view/test/HandleContextMenu.test.ts index 05cf10bc..4bd84d01 100644 --- a/packages/keybindings-view/test/HandleContextMenu.test.ts +++ b/packages/keybindings-view/test/HandleContextMenu.test.ts @@ -4,9 +4,14 @@ import * as HandleContextMenu from '../src/parts/HandleContextMenu/HandleContext test('handleContextMenu - shows context menu', async () => { using mockRpc = RendererWorker.registerMockRpc({ - 'ContextMenu.show'() {}, + 'ContextMenu.show2'() {}, }) - const result = await HandleContextMenu.handleContextMenu({} as any, 0, 10, 20) - expect(mockRpc.invocations).toEqual([['ContextMenu.show', 10, 20, 26]]) + const result = await HandleContextMenu.handleContextMenu({ + uid: 1, + y: 0, + searchHeaderHeight: 0, + tableHeaderHeight: 0, + } as any, 0, 10, 20) + expect(mockRpc.invocations).toEqual([['ContextMenu.show2', 1, 26, 10, 20, { menuId: 26 as const }]]) expect(result).toBeDefined() }) From 1b03f491a8d565db3d184572f399fbeb16615b3d Mon Sep 17 00:00:00 2001 From: Le Vivilet Date: Mon, 26 Jan 2026 15:35:28 +0100 Subject: [PATCH 10/12] fix --- .../test/HandleContextMenu.test.ts | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/packages/keybindings-view/test/HandleContextMenu.test.ts b/packages/keybindings-view/test/HandleContextMenu.test.ts index 4bd84d01..bf40fdc5 100644 --- a/packages/keybindings-view/test/HandleContextMenu.test.ts +++ b/packages/keybindings-view/test/HandleContextMenu.test.ts @@ -6,12 +6,17 @@ test('handleContextMenu - shows context menu', async () => { using mockRpc = RendererWorker.registerMockRpc({ 'ContextMenu.show2'() {}, }) - const result = await HandleContextMenu.handleContextMenu({ - uid: 1, - y: 0, - searchHeaderHeight: 0, - tableHeaderHeight: 0, - } as any, 0, 10, 20) + const result = await HandleContextMenu.handleContextMenu( + { + uid: 1, + y: 0, + searchHeaderHeight: 0, + tableHeaderHeight: 0, + } as any, + 0, + 10, + 20, + ) expect(mockRpc.invocations).toEqual([['ContextMenu.show2', 1, 26, 10, 20, { menuId: 26 as const }]]) expect(result).toBeDefined() }) From 5b5d6659f5874c42235c96337d7111c9bb793b90 Mon Sep 17 00:00:00 2001 From: Le Vivilet Date: Mon, 26 Jan 2026 15:35:45 +0100 Subject: [PATCH 11/12] fix --- packages/keybindings-view/test/HandleContextMenu.test.ts | 4 ++-- packages/keybindings-view/test/ShowSameKeyBindings.test.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/keybindings-view/test/HandleContextMenu.test.ts b/packages/keybindings-view/test/HandleContextMenu.test.ts index bf40fdc5..2bb2bd7b 100644 --- a/packages/keybindings-view/test/HandleContextMenu.test.ts +++ b/packages/keybindings-view/test/HandleContextMenu.test.ts @@ -8,10 +8,10 @@ test('handleContextMenu - shows context menu', async () => { }) const result = await HandleContextMenu.handleContextMenu( { - uid: 1, - y: 0, searchHeaderHeight: 0, tableHeaderHeight: 0, + uid: 1, + y: 0, } as any, 0, 10, diff --git a/packages/keybindings-view/test/ShowSameKeyBindings.test.ts b/packages/keybindings-view/test/ShowSameKeyBindings.test.ts index dcf5ae8f..f5c7b863 100644 --- a/packages/keybindings-view/test/ShowSameKeyBindings.test.ts +++ b/packages/keybindings-view/test/ShowSameKeyBindings.test.ts @@ -46,7 +46,6 @@ test('showSameKeyBindings - sets value to focused keybinding and focuses input', const state: KeyBindingsState = { ...createDefaultState(), - selectedIndex: 0, items: [ makeParsedKeyBinding({ command: 'test.command', @@ -57,6 +56,7 @@ test('showSameKeyBindings - sets value to focused keybinding and focuses input', ], maxVisibleItems: 10, parsedKeyBindings: [], + selectedIndex: 0, } const result: KeyBindingsState = await ShowSameKeyBindings.showSameKeyBindings(state) From cadf8690fea929b3e1611db27c78f5ce24925b7a Mon Sep 17 00:00:00 2001 From: Le Vivilet <72156503+levivilet@users.noreply.github.com> Date: Sun, 25 Oct 2026 15:39:49 +0000 Subject: [PATCH 12/12] fix: use precise resize test value --- packages/keybindings-view/test/Resize.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/keybindings-view/test/Resize.test.ts b/packages/keybindings-view/test/Resize.test.ts index 33b8f761..f03022bf 100644 --- a/packages/keybindings-view/test/Resize.test.ts +++ b/packages/keybindings-view/test/Resize.test.ts @@ -29,7 +29,7 @@ test('resize - basic dimensions', () => { columnWidth3: 173.333_333_333_333_34, maxVisibleItems: 17, resizerOneLeft: 213.333_333_333_333_34, - resizerTwoLeft: 406.666_666_666_666_68, + resizerTwoLeft: 406.666_666_666_666_7, scrollBarHeight: 0, visibleItems: [], })