HDR tonemap introduced in #276 being applied to SDR content.

[jkluch]

@miguedevel
The change introduced in #276 is definitely giving me bad results.
Possibly due to this

When setting the brightness levels for the capture, I hardcoded the default OBS values of 300 and 1000,
which to me produce satisfactory results. Should these values also be exposed as settings?

As my monitor is in HDR "True Black 400" mode and not "1000 nits" mode.

I think more likely though is the fact that the game I was running doesn't support HDR and I don't use RTX HDR or AutoHDR. Meaning even though I have HDR enabled in windows the game was rendering and displaying in SDR then the game was getting tone mapped from SDR to SDR.

My vote is maybe short term having a checkbox to disable HDR to SDR tone mapping.. and long term work out a more robust way to determine if the content is actually HDR content and allow the user to set the brightness levels.

Here are two screenshots from video taken before and after I updated RePlays with the tone mapping change.
Before:

After:

[sonicv6]

Running your monitor in HDR then running a game in SDR without AutoHDR must look so incredibly washed out for you. I agree that this setting should be exposed to users, but for your own sake I would recommend just disabling HDR on your monitor for SDR content if you don't wish to use AutoHDR. You can use stuff like AutoActions to enable it automatically when you boot up games with HDR support, that's what I do on my monitor.

[miguedevel]

Weird, I tried Rematch and can reproduce the issue but I try a number of other non natively supporting HDR (with Auto HDR off) and they record fine.

EDIT: I think Rematch is just misconfigured and it is supposed to have native HDR.
Because on games that support HDR natively, like Stellar Blade demo as a recent free example, if I disable in game HDR while having Windows HDR then the recording colors get oversaturated. Same with Still Wakes the Deep that I was heavily playing/testing while developing the feature. And disabling HDR on game while having HDR on on Windows doesn't make sense to have so I ignored the results.

@jkluch are there other games which are giving you incorrect looking results? Please list them to take a look at them.

[miguedevel]

OK I tested another UE5 DX12 game that doesn't support HDR, Clair Obscure and the issue is there.
I'll do another pull request reverting behavior by default and adding a config file only option to enable it for advanced users.

[jkluch]

Thanks for testing some other games. I left for a camping trip this morning otherwise I'd do some additional testing myself. As for the hardcoded brightness levels, when I get back I'll try to remember to test an HDR game to see how that looks since I'm not using 1000 nits peak.