Is 2.0 still the goal?

[RonaldJerez]

Planning to use this library for a bot, but I want to add some functionally. Should I work on development or master branch.

[luk3yx]

I've kind of given up on the idea of releasing a v2 (for the time being), I don't like the idea of possibly breaking existing bots.
It'd probably be better to use the master branch, development is out of date anyway.

[RonaldJerez]

Ok, thanks. I did like some of the new coding directions development was going in, seems easier to follow the logics. I compared the commits that were added to master and the only new thing is the server_password which can easily be added. Anything outstanding in v2 that you didn't get to work on yet?

[luk3yx]

I can't think of any but it has been a few years since I touched the v2 code, and would probably want to change things in the unlikely event that I revisit it

[RonaldJerez]

Ah no worries. I ended up going with the development branch since it looks like you were going in the direction of using asyncio which I’m using with other libraries. I converted it to asyncio and pulled in most of the changes/fixes you had done in master. It’s actually working pretty well for my needs right now. I’m mainly converting some bots from twisted since they have no plans to update their IRC library to v3.

Take a look, see if you want to consider it for v2 and I can clean it up for a pull request. If it looks like it’s going in a diff direction than you were planning then maybe I’ll release it under a different name.

[luk3yx]

It looks interesting, and you have improved on a few other things I didn't think of (like removing the _Logfile class). I wonder whether it would be better as a fork though, I'm not sure that I want to break existing programs that use miniirc.

[RonaldJerez]

Yea I completely agree. I actually started adding deprecation warnings for new things, then at some point realized that I’m changing quite a bit and no amount of warnings is going to make it a clean switch over. So I just removed them and decided to move forward as a likely new lib.

That sort of freed me up to make additional changes without worrying about upgradability. (Haven’t pushed them yet).

I will add the ability to still save individual log per bot instances back, I think it’s a good feature and the built in logging lib does allow for that still.