DM-54457: Avoid unnecessary file size check on remote storage#1348
Draft
dhirving wants to merge 2 commits into
Draft
DM-54457: Avoid unnecessary file size check on remote storage#1348dhirving wants to merge 2 commits into
dhirving wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1348 +/- ##
==========================================
- Coverage 89.53% 89.52% -0.01%
==========================================
Files 370 370
Lines 50250 50267 +17
Branches 5876 5879 +3
==========================================
+ Hits 44989 45003 +14
- Misses 3873 3874 +1
- Partials 1388 1390 +2 ☔ View full report in Codecov by Sentry. |
Make `FormatterV2.write_direct` and `FormatterV2.write_locally_then_move` private. Public methods intended for override `to_bytes` and `write_local_file` already exist that replace these.
When using FormatterV2 to write a file, we now keep track of the file size that it wrote to use when recording validation information in the datastore. This lets us avoid a call to remote storage to retrieve the size of the file after writing it. In particular, this extra call was contributing to performance problems during heavy processing workloads with the FrDF WebDAV implementation.
af3ebef to
9b31333
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using FormatterV2 to write a file, we now keep track of the file size that it wrote to use when recording validation information in the datastore. This lets us avoid a call to remote storage to retrieve the size of the file after writing it. In particular, this extra call was contributing to performance problems during heavy processing workloads with the FrDF WebDAV implementation.
Checklist
doc/changesconfigs/old_dimensions