From 9adfd7c6c633acfc2af9af7c1830b9fe4f3f1fa2 Mon Sep 17 00:00:00 2001 From: Yoav Date: Sun, 4 Oct 2026 00:34:49 -0400 Subject: [PATCH] fix(ci): match the FLASH_ATTN pin as a fixed string, not a BRE MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The `prio[0]` pin landed in 16086ae1f (#3375) under a bare `grep -q`, so grep read it as a BASIC REGULAR EXPRESSION in which `[0]` is a character class for the digit 0. The pattern therefore asked for `prio0` and could never match the literal `prio[0]` doctest prints under `-s`. The pin was unsatisfiable from the moment it landed. Run 37160385766 on main is the evidence, and it separates the suite from the gate cleanly: the case ran, all thirteen assertions printed `is correct!`, and the summary read `test cases: 1 | 1 passed | 0 failed | 45 skipped` with `Status: SUCCESS!` — yet the step exited 1, because the SUITE passed and the GREP could not succeed. So `build-test-vulkan` has been red on main since 2026-10-02 while measuring a perfectly healthy device. `-qF` compares the literal text. Replaying all three pins against that run's captured `vulkan-platform-case.log` gives pin2 exit 1 before and exit 0 after, with pin1 and pin3 unchanged at 0; a deliberately wrong `prio[1]` string is still rejected, so the pin keeps its teeth. This is the only unsatisfiable pin in the file: the remaining bracketed pins (1908-1910, 1944-1945) are `-qE` and use `[[:space:]]`/`[1-9]`/`[0-9]` as intended classes. FOLLOWING_AGENTS_PROTOCOL Following-Agents-Protocol: true AI-Assisted: true Assisted-by: AGENT:buffy/space-bunny-alpha [freebuff] --- .github/workflows/ci.yml | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d97753d03f..99a107fbc9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1311,10 +1311,16 @@ jobs: -tc="Vulkan platform is registered and reports unified/no-pool residency" -s \ | tee vulkan-platform-case.log grep -q 'CHECK_FALSE( p.get_device_capability().present() ) is correct' vulkan-platform-case.log - # `[0]` in a BRE is a bracket expression matching the lone character - # `0`, so this pattern can never match the literal `prio[0]` in the - # doctest output. Escape it (run 37202846607, job build-test-vulkan). - grep -q 'CHECK( prio\[0\] == "FLASH_ATTN" ) is correct' vulkan-platform-case.log + # -qF, not -q: WITHOUT a flag grep reads this as a BASIC REGULAR + # EXPRESSION, where `[0]` is a character class meaning "the character + # 0", so the pattern asks for `prio0` and can never match the literal + # `prio[0]` doctest prints. That is not theoretical: run 37160385766 on + # main failed this step with all thirteen assertions reporting + # `is correct!` and `test cases: 1 | 1 passed`, because the SUITE + # passed and the GREP could not succeed. A pin that cannot match is a + # lane that is red forever and proves nothing. Fixed strings for every + # pin whose text contains a bracket. + grep -qF 'CHECK( prio[0] == "FLASH_ATTN" ) is correct' vulkan-platform-case.log grep -qE 'test cases: *1 \| *1 passed' vulkan-platform-case.log device-leakage: # The DSR RATCHET (work row `S1` of .agents/specs/accelerator-seam-audit.md).