From 42d362ef5015b3433045915172412d7ce36de451 Mon Sep 17 00:00:00 2001 From: szeevs <35523888+szeevs@users.noreply.github.com> Date: Wed, 10 Jul 2019 15:17:02 +0300 Subject: [PATCH 1/2] Updated label for average_interaction_rate --- master_basic_stats.view.lkml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/master_basic_stats.view.lkml b/master_basic_stats.view.lkml index 4db87c7..6cdcd80 100644 --- a/master_basic_stats.view.lkml +++ b/master_basic_stats.view.lkml @@ -56,7 +56,7 @@ view: stats { ## rather than creating a new dimension to be aggregated over measure: average_interaction_rate { - label: "Interation Rate" + label: "Interaction Rate" type: number sql: ${total_interactions}*1.0/nullif(${total_impressions},0) ;; value_format_name: percent_2 From ea64d231823c00912ef6d462721d2314659db4e1 Mon Sep 17 00:00:00 2001 From: szeevs <35523888+szeevs@users.noreply.github.com> Date: Wed, 10 Jul 2019 17:21:13 +0300 Subject: [PATCH 2/2] Update audience to extend ad_criterion_base --- entity_base.view.lkml | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/entity_base.view.lkml b/entity_base.view.lkml index 8bced6f..2d03dab 100644 --- a/entity_base.view.lkml +++ b/entity_base.view.lkml @@ -565,7 +565,7 @@ view: ad_group { view: audience { - extends: [entity_base] + extends: [ad_criterion_base, entity_base] sql_table_name: adwords_v201609.Audience_6747157124 ;; dimension: _data { @@ -576,13 +576,6 @@ view: audience { sql: TIMESTAMP(${TABLE}._LATEST_DATE) ;; } - dimension: unique_key { - type: string - primary_key: yes - hidden: yes - sql: CONCAT(CAST(${ad_group_id} AS STRING),CAST(${criterion_id} AS STRING)) ;; - } - dimension: ad_group_id { type: number sql: ${TABLE}.AdGroupId ;;