-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
P3-lowLow: extended features, operational docsLow: extended features, operational docsfollow-upFollow-up task from PR reviewFollow-up task from PR reviewfrom-reviewIssue originated from PR reviewIssue originated from PR review
Description
Context
This follow-up task was identified during the review of PR #162.
Source PR: #162
PR Title: ci: add Docker build job with image size validation
Suggested by: @claude[bot]
Task Description
The docker-build CI job runs in parallel with test-go and test-client. Since it rebuilds Go and the client independently inside Docker, it could show green even when unit tests are failing.
Adding needs: [test-go, test-client] would gate the Docker build on passing tests, giving a cleaner signal ("does this produce a working image from known-good code").
Trade-off
- With needs: Cleaner CI signal, Docker only builds known-good code. Slower overall (sequential).
- Without needs (current): Surfaces all failures at once. Docker build failure visible immediately. Faster overall (parallel).
Implementation
docker-build:
name: Docker Build
needs: [test-go, test-client]
runs-on: ubuntu-latestThis issue was automatically created by prmonitor from PR review comments.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P3-lowLow: extended features, operational docsLow: extended features, operational docsfollow-upFollow-up task from PR reviewFollow-up task from PR reviewfrom-reviewIssue originated from PR reviewIssue originated from PR review