-
Notifications
You must be signed in to change notification settings - Fork 0
Description
Context
This follow-up task was identified during the review of PR #248.
Source PR: #248
PR Title: feat: add per-IP rate limiting for global and auth endpoints
Suggested by: @claude[bot]
Task Description
The auth deny handler hardcodes Retry-After: 60 but the auth RPS is configurable via RATE_LIMIT_AUTH_RPS (default 0.1). If someone sets RATE_LIMIT_AUTH_RPS=1, the header still says 60 seconds.
Compute Retry-After from the configured rate: ceil(1/rps) seconds. For the default 0.1 rps this gives 10s — the current 60s is intentionally conservative to discourage rapid retry, so document this choice if keeping it, or switch to the computed value.
The global deny handler uses Retry-After: 1 which is correct for 100 rps.
Original Comment
The value 60 is hardcoded in the injected auth deny handler but the auth RPS is configurable. If someone sets
RATE_LIMIT_AUTH_RPS=1, theRetry-Afterheader will still say 60. Consider computing this from the configured rate. — @claude[bot]