Instead of changing the ACLs of files individually, use the --recursive option of setfacl#1
Open
raphael247 wants to merge 1 commit intolinuxmuster:lmn73from
Open
Instead of changing the ACLs of files individually, use the --recursive option of setfacl#1raphael247 wants to merge 1 commit intolinuxmuster:lmn73from
raphael247 wants to merge 1 commit intolinuxmuster:lmn73from
Conversation
…ption of setfacl is now used to efficiently apply changes
hermanntoast
approved these changes
Mar 11, 2026
Collaborator
hermanntoast
left a comment
hermanntoast
left a comment
There was a problem hiding this comment.
Looks good! Using setfacl -R is the right approach here — it correctly ignores default: ACL entries on files, so the manual file/directory distinction is unnecessary. This is cleaner, more performant, and easier to maintain. Thanks for contributing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setfacl is smart enough that when using the
--recursiveoption, it does not apply the default ACL entries to the files in subdirectories. Therefore, the--recursiveoption can be used instead of making the distinction between files and directories in the program code.