fix(faucet): repoint at api.ligate.io/v1/drip + cut v0.1.3 (closes #34)#36
Merged
Conversation
8e3d06a to
3a1b2a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ligate faucetwas broken inv0.1.2-devnet. The hardcoded defaulthttps://faucet.ligate.iono longer resolves (standaloneligate-io/faucetrepo was archived; drip moved intoligate-apiasPOST /v1/drip), and the URL builder hardcoded a/faucetsuffix so--faucet-urlcouldn't paper over the host change. RepointsDEFAULT_FAUCET_URLathttps://api.ligate.io/v1/dripand drops the suffix so the configured URL is POSTed directly.-devnetsuffix). Matchesligate-chainv0.1.2,ligate-js, andligate-api. Network identity stays inchain_id(ligate-devnet-1) and genesis dir names, not in the binary tag.README.mdfaucet examples and "Related" link; drops the staleligate-faucetrepo pattern reference.Response shape (
{address, tx_hash, amount_nano, drip_amount_lgt}) is unchanged.Test plan
Verified against live
ligate-devnet-1with a release-build binary:ligate --versionreportsligate 0.1.3ligate faucet --helpshows defaulthttps://api.ligate.io/v1/dripligate faucet lig1wlathcrhl93kmpkyu96xe33ceqqy7qdhk54ku7lazgvs5l834a0→Drip accepted by faucet: 100 $LGT, tx: ltx12ngwqvg9url8hws9xxqvd59hqlg4m0m9raxuaa8wdva4c4478z0qh6e057.GET /v1/drip/statusaddresses_drippedincremented0 → 1.faucet returned 400 Bad Request: ... invalid string lengthviaFaucetErrordeserializer.--faucet-urloverride: works with and without trailing slash (trim_end_matches('/')).v0.1.1-devnetbinary reproduces both failure modes from ligate faucet broken: default URL dead, --faucet-url can't reach api.ligate.io/v1/drip #34 (DNS onfaucet.ligate.io, 404 on suffix-doubling).cargo fmt --checkclean (also enforced by pre-commit hook on this commit).Release: tag
v0.1.3once merged; the cross-platform release workflow at.github/workflows/release.ymldoes the rest.