From 7973a2cef9616be623d4a34074361891b1988c54 Mon Sep 17 00:00:00 2001 From: everoddandeven Date: Sat, 14 Nov 2026 18:19:35 +0100 Subject: [PATCH 1/6] ci: name the steps and the jobs as monero-cpp does --- .github/workflows/build-deb.yml | 4 ++-- .github/workflows/build-macos.yml | 22 +++++++++++-------- .github/workflows/build-windows.yml | 14 ++++++------ .github/workflows/test.yml | 34 ++++++++++++++++------------- 4 files changed, 41 insertions(+), 33 deletions(-) diff --git a/.github/workflows/build-deb.yml b/.github/workflows/build-deb.yml index 0531506..73068d9 100644 --- a/.github/workflows/build-deb.yml +++ b/.github/workflows/build-deb.yml @@ -104,7 +104,7 @@ jobs: with: key: ccache-deb-${{ matrix.name }}-${{ matrix.arch }} - - name: Upload deb package + - name: Upload monero-python package uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2 with: name: python3-monero_${{ steps.version.outputs.version }}-1${{ matrix.name }}1_${{ matrix.arch }} @@ -113,7 +113,7 @@ jobs: # the segments and the exports of the module in the package, and the stack protector and the branch protection in its code. The # module of the armhf package is read but not disassembled, the objdump of the arm64 runner does not read 32 bit arm. # After the upload, so that a package that fails can be downloaded and looked at. The release needs this job to succeed - - name: Check hardening and exports + - name: Verify libraries run: | dpkg-deb -x debian/artifacts/python3-monero_*.deb deb-check bin/check_elf_hardening.sh deb-check/usr/lib/python3/dist-packages/monero*.so diff --git a/.github/workflows/build-macos.yml b/.github/workflows/build-macos.yml index 3cd3e9f..759075f 100644 --- a/.github/workflows/build-macos.yml +++ b/.github/workflows/build-macos.yml @@ -25,8 +25,8 @@ permissions: actions: write # replace the ccache entries jobs: - build: - name: ${{ matrix.os }} + mac-os: + name: ${{ matrix.arch }} runs-on: ${{ matrix.os }} timeout-minutes: 120 env: @@ -37,7 +37,11 @@ jobs: strategy: fail-fast: false matrix: - os: [macos-15, macos-15-intel] + include: + - os: macos-15 + arch: mac-arm64 + - os: macos-15-intel + arch: mac-x86_64 steps: - name: Checkout repository @@ -65,7 +69,7 @@ jobs: "$RUNNER_TEMP/venv/bin/pip" install -r requirements-build.txt # static, against openssl@3: the unbound of brew is built with OpenSSL 4 - - name: Install unbound + - name: Install unbound (static) run: bin/install_unbound_macos.sh - name: Restore ccache @@ -79,7 +83,7 @@ jobs: - name: Reset ccache statistics run: ccache --zero-stats - - name: Build monero + - name: Build monero-project run: | cd external/monero-cpp/external/monero-project mkdir -p build/release @@ -92,7 +96,7 @@ jobs: make -j3 wallet cryptonote_protocol cd ../../../../../../ - - name: Build monero-cpp + - name: Build monero-cpp libraries run: | cd external/monero-cpp mkdir -p build @@ -102,7 +106,7 @@ jobs: make -j3 cd ../../../ - - name: Build monero-python + - name: Build monero-python module run: | mkdir -p build python3 -m pip wheel . -w dist --no-build-isolation @@ -123,12 +127,12 @@ jobs: delocate-wheel -w wheelhouse -v dist/*.whl # the canary and the exports of the module in the wheel that is published - - name: Check hardening and exports + - name: Verify libraries run: | python3 -m zipfile -e wheelhouse/*.whl wheel-check bin/check_macho_hardening.sh wheel-check/monero*.so - - name: Upload artifacts + - name: Upload monero-python wheel uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2 with: name: monero-${{ matrix.os }} diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml index 9ce0288..c074c25 100644 --- a/.github/workflows/build-windows.yml +++ b/.github/workflows/build-windows.yml @@ -24,8 +24,8 @@ permissions: actions: write # replace the ccache entries jobs: - msys2-mingw64: - name: MSYS2 MinGW64 + windows: + name: windows timeout-minutes: 120 runs-on: windows-latest env: @@ -162,7 +162,7 @@ jobs: - name: Reset ccache statistics run: ccache --zero-stats - - name: Build monero + - name: Build monero-project run: | cd external/monero-cpp/external/monero-project mkdir -p build/release @@ -178,7 +178,7 @@ jobs: ../../ make -j$(nproc) wallet cryptonote_protocol - - name: Build monero-cpp + - name: Build monero-cpp libraries run: | cd external/monero-cpp mkdir -p build @@ -186,7 +186,7 @@ jobs: cmake .. -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache cmake --build . --parallel $(nproc) - - name: Build wheel + - name: Build monero-python module run: | export WIN_PYTHON_EXE=$(cygpath -u "$pythonLocation/python.exe") export CMAKE_BUILD_PARALLEL_LEVEL=$(nproc) @@ -213,13 +213,13 @@ jobs: "$WIN_PYTHON_EXE" -m delvewheel repair dist/*.whl -w wheelhouse --add-path "$MINGW_BIN_WIN" # the flags of the image (ASLR, DEP) and the exports of the module in the wheel that is published - - name: Check hardening and exports + - name: Verify libraries run: | export WIN_PYTHON_EXE=$(cygpath -u "$pythonLocation/python.exe") "$WIN_PYTHON_EXE" -m zipfile -e wheelhouse/*.whl wheel-check bash bin/check_pe_hardening.sh wheel-check/monero*.pyd - - name: Upload artifacts + - name: Upload monero-python wheel uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2 with: name: monero-python-win-amd64 diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index f96c392..274d6ca 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -35,12 +35,12 @@ permissions: contents: read jobs: - linux: + ubuntu: runs-on: ubuntu-24.04 permissions: contents: read actions: write # replace the ccache entries - name: linux (pytest) + name: linux-x86_64 (pytest) timeout-minutes: 120 env: CCACHE_DIR: ${{ github.workspace }}/.ccache @@ -93,7 +93,7 @@ jobs: - name: Reset ccache statistics run: ccache --zero-stats - - name: Build monero + - name: Build monero-project run: | cd external/monero-cpp/external/monero-project mkdir -p build/release @@ -105,7 +105,7 @@ jobs: make -j3 wallet cryptonote_protocol cd ../../../../../../ - - name: Build monero-cpp + - name: Build monero-cpp libraries run: | cd external/monero-cpp mkdir -p build @@ -115,7 +115,7 @@ jobs: make -j3 cd ../../../ - - name: Install monero-python + - name: Build monero-python module run: | mkdir -p build cmake -B build -DENABLE_COVERAGE=ON -Dpybind11_DIR="$(python3 -m pybind11 --cmakedir)" @@ -357,7 +357,7 @@ jobs: - name: Reset ccache statistics run: ccache --zero-stats - - name: Build monero + - name: Build monero-project run: | cd external/monero-cpp/external/monero-project mkdir -p build/release @@ -373,7 +373,7 @@ jobs: ../../ make -j$(nproc) wallet cryptonote_protocol - - name: Build monero-cpp + - name: Build monero-cpp libraries run: | cd external/monero-cpp mkdir -p build @@ -381,7 +381,7 @@ jobs: cmake .. -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache cmake --build . --parallel $(nproc) - - name: Build monero-python + - name: Build monero-python module run: | mkdir -p build cd build @@ -418,8 +418,8 @@ jobs: run: | python -m pytest -m unit - macos: - name: ${{ matrix.os }} (pytest) + mac-os: + name: ${{ matrix.arch }} (pytest) runs-on: ${{ matrix.os }} permissions: contents: read @@ -433,7 +433,11 @@ jobs: strategy: fail-fast: false matrix: - os: [macos-15, macos-15-intel] + include: + - os: macos-15 + arch: mac-arm64 + - os: macos-15-intel + arch: mac-x86_64 steps: - name: Checkout repository @@ -461,7 +465,7 @@ jobs: "$RUNNER_TEMP/venv/bin/pip" install -r tests/requirements.txt -r requirements-build.txt # static, against openssl@3: the unbound of brew is built with OpenSSL 4 - - name: Install unbound + - name: Install unbound (static) run: bin/install_unbound_macos.sh - name: Restore ccache @@ -475,7 +479,7 @@ jobs: - name: Reset ccache statistics run: ccache --zero-stats - - name: Build monero + - name: Build monero-project run: | cd external/monero-cpp/external/monero-project mkdir -p build/release @@ -488,7 +492,7 @@ jobs: make -j3 wallet cryptonote_protocol cd ../../../../../../ - - name: Build monero-cpp + - name: Build monero-cpp libraries run: | cd external/monero-cpp mkdir -p build @@ -498,7 +502,7 @@ jobs: make -j3 cd ../../../ - - name: Install monero-python + - name: Build monero-python module run: | mkdir -p build pip3 install --no-build-isolation -vvv . From e37d715b08d8885348f2b0b8efa5af37d872a2d8 Mon Sep 17 00:00:00 2001 From: everoddandeven Date: Sat, 14 Nov 2026 18:26:32 +0100 Subject: [PATCH 2/6] ci: run the tests of Windows and macOS on the wheels that were built --- .github/workflows/build-macos.yml | 19 +- .github/workflows/build-windows.yml | 18 +- .github/workflows/build.yml | 128 ++++++++++++ .github/workflows/test.yml | 306 ---------------------------- 4 files changed, 132 insertions(+), 339 deletions(-) create mode 100644 .github/workflows/build.yml diff --git a/.github/workflows/build-macos.yml b/.github/workflows/build-macos.yml index 759075f..cc0d3bf 100644 --- a/.github/workflows/build-macos.yml +++ b/.github/workflows/build-macos.yml @@ -1,25 +1,10 @@ name: Build MacOS +# Called by build.yml, which has the triggers and the concurrency group: a group here would be the one of the caller, and the +# jobs of the same run would cancel each other. on: - push: - branches: [ main ] - pull_request: - branches: [ main ] - paths: - - '.github/workflows/build-macos.yml' - - 'CMakeLists.txt' - - 'bin/check_macho_hardening.sh' - - 'bin/install_unbound_macos.sh' - - 'requirements-build.txt' - workflow_dispatch: workflow_call: -# A new push to a pull request cancels the previous run. Other events get their own -# group so they are never cancelled or replaced. -concurrency: - group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }} - cancel-in-progress: ${{ github.event_name == 'pull_request' }} - permissions: contents: read actions: write # replace the ccache entries diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml index c074c25..f6742fd 100644 --- a/.github/workflows/build-windows.yml +++ b/.github/workflows/build-windows.yml @@ -1,24 +1,10 @@ name: Build Windows Package +# Called by build.yml, which has the triggers and the concurrency group: a group here would be the one of the caller, and the +# jobs of the same run would cancel each other. on: - push: - branches: [ main ] - pull_request: - branches: [ main ] - paths: - - '.github/workflows/build-windows.yml' - - 'CMakeLists.txt' - - 'bin/check_pe_hardening.sh' - - 'requirements-build.txt' - workflow_dispatch: workflow_call: -# A new push to a pull request cancels the previous run. Other events get their own -# group so they are never cancelled or replaced. -concurrency: - group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }} - cancel-in-progress: ${{ github.event_name == 'pull_request' }} - permissions: contents: read actions: write # replace the ccache entries diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml new file mode 100644 index 0000000..02d3194 --- /dev/null +++ b/.github/workflows/build.yml @@ -0,0 +1,128 @@ +name: Build + +# The builds are in build-windows.yml and build-macos.yml, called from here, and the tests run on what they built: the wheel +# that a build uploads is the one that its tests install, so nothing is compiled twice. +on: + push: + branches: + - main + pull_request: + branches: + - main + # Only on pull requests: the release needs a successful run for every commit on main. + # If Build ever becomes a required check, a skipped run stays Pending and blocks the merge. + paths-ignore: + - 'README.md' + - 'LICENSE' + - '.gitignore' + - 'donate.png' + - 'docs/**' + # other workflows, not run by this one + - '.github/workflows/build-deb.yml' + - '.github/workflows/codacy.yml' + - '.github/workflows/release.yml' + - '.github/workflows/lint-workflows.yml' + - '.github/zizmor.yml' + - '.github/dependabot.yml' + + workflow_dispatch: + +# A new push to a pull request cancels the previous run. Runs that are not +# from a pull request get their own group so they are never cancelled or replaced. +concurrency: + group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }} + cancel-in-progress: ${{ github.event_name == 'pull_request' }} + +permissions: + contents: read + +jobs: + build-windows: + permissions: + contents: read + actions: write # build-windows.yml replaces its ccache entries + uses: ./.github/workflows/build-windows.yml + + build-mac-os: + permissions: + contents: read + actions: write # build-macos.yml replaces its ccache entries + uses: ./.github/workflows/build-macos.yml + + test-windows: + name: windows (pytest) + needs: build-windows + runs-on: windows-latest + timeout-minutes: 30 + + steps: + - name: Checkout repository + uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 + with: + persist-credentials: false + + - name: Setup Python 3.13 + uses: actions/setup-python@6d4fd22b20465ccc0f7354476588e8df7c9ca0e0 # v7.1.0 + with: + python-version: '3.13' + architecture: 'x64' + + - name: Download monero-python wheel + uses: actions/download-artifact@9000827ccba6bdab643e8b6fd33ac0654aef8333 # v8.0.2 + with: + name: monero-python-win-amd64 + path: wheelhouse + + - name: Install dependencies + shell: bash + run: | + python -m pip install -r tests/requirements.txt + python -m pip install wheelhouse/*.whl + + - name: Run unit tests + shell: bash + env: + IN_CONTAINER: "true" + run: | + python -m pytest -m unit + + test-mac-os: + name: ${{ matrix.arch }} (pytest) + needs: build-mac-os + runs-on: ${{ matrix.os }} + timeout-minutes: 30 + + strategy: + fail-fast: false + matrix: + include: + - os: macos-15 + arch: mac-arm64 + - os: macos-15-intel + arch: mac-x86_64 + + steps: + - name: Checkout repository + uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 + with: + persist-credentials: false + + - name: Download monero-python wheel + uses: actions/download-artifact@9000827ccba6bdab643e8b6fd33ac0654aef8333 # v8.0.2 + with: + name: monero-${{ matrix.os }} + path: wheelhouse + + - name: Install dependencies + run: | + # the python that the build used, the wheel is for its version + HOMEBREW_NO_AUTO_UPDATE=1 brew install python + # a virtual environment, as in the build: the python of brew has packages that pip can not replace, and the + # versions of the requirements file are pinned + python3 -m venv "$RUNNER_TEMP/venv" + echo "$RUNNER_TEMP/venv/bin" >> "$GITHUB_PATH" + "$RUNNER_TEMP/venv/bin/pip" install -r tests/requirements.txt wheelhouse/*.whl + + - name: Run unit tests + run: | + pytest -m unit diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 274d6ca..4dd171a 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -215,309 +215,3 @@ jobs: coverage_monero_cpp_html/ coverage_monero_python_bindings_html/ coverage_monero_python_tests_html/ - - windows: - name: windows (pytest) - runs-on: windows-latest - permissions: - contents: read - actions: write # replace the ccache entries - timeout-minutes: 120 - env: - CCACHE_DIR: ${{ github.workspace }}/.ccache - CCACHE_MAXSIZE: 500M - - defaults: - run: - shell: msys2 {0} - - steps: - - name: Checkout repository - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - with: - persist-credentials: false - submodules: recursive - - - name: Setup Python 3.13 - uses: actions/setup-python@6d4fd22b20465ccc0f7354476588e8df7c9ca0e0 # v7.1.0 - with: - python-version: '3.13' - architecture: 'x64' - - - name: Install pytest and dependencies - shell: bash - run: | - python -m pip install -r tests/requirements.txt -r requirements-build.txt - - - name: Setup MSYS2 MINGW64 - uses: msys2/setup-msys2@ec48f7c5447b3140e2b088413ae3a55687bccb6e # v2.33.0 - with: - msystem: MINGW64 - update: true - install: >- - mingw-w64-x86_64-cmake - mingw-w64-x86_64-openssl - mingw-w64-x86_64-zeromq - mingw-w64-x86_64-libsodium - mingw-w64-x86_64-unbound - mingw-w64-x86_64-protobuf - mingw-w64-x86_64-ntldd - mingw-w64-x86_64-ccache - git - make - gettext - base-devel - wget - - - name: Install pinned MinGW64 toolchain v16.2.0 - run: | - wget https://repo.msys2.org/mingw/mingw64/mingw-w64-x86_64-headers-14.0.0.r375.g9c1abbbf5-1-any.pkg.tar.zst - echo "acad5748942953f91a0f2bba03e20437b909366e55949f478f1b2f2d30c726a7 mingw-w64-x86_64-headers-14.0.0.r375.g9c1abbbf5-1-any.pkg.tar.zst" | sha256sum -c - wget https://repo.msys2.org/mingw/mingw64/mingw-w64-x86_64-crt-14.0.0.r375.g9c1abbbf5-1-any.pkg.tar.zst - echo "d24b4e7614756414ae3ef58793265448a3ca7d5fd447a991e9b2facde7b59d75 mingw-w64-x86_64-crt-14.0.0.r375.g9c1abbbf5-1-any.pkg.tar.zst" | sha256sum -c - wget https://repo.msys2.org/mingw/mingw64/mingw-w64-x86_64-binutils-2.47-3-any.pkg.tar.zst - echo "827363748ce3320683319d860ee4fcfcdbb36baf66aac6dab0ec3822be2d4ff7 mingw-w64-x86_64-binutils-2.47-3-any.pkg.tar.zst" | sha256sum -c - wget https://repo.msys2.org/mingw/mingw64/mingw-w64-x86_64-libmangle-14.0.0.r375.g9c1abbbf5-1-any.pkg.tar.zst - echo "481babe8c2fdfa4fc7f51bf13939701719af9f8166ef6a91a9a209cc25961b03 mingw-w64-x86_64-libmangle-14.0.0.r375.g9c1abbbf5-1-any.pkg.tar.zst" | sha256sum -c - wget https://repo.msys2.org/mingw/mingw64/mingw-w64-x86_64-winpthreads-14.0.0.r375.g9c1abbbf5-1-any.pkg.tar.zst - echo "7d86a267b6069198d28f3e77314282ff7b4e3c7bb8fe482299ca58f7a5b439db mingw-w64-x86_64-winpthreads-14.0.0.r375.g9c1abbbf5-1-any.pkg.tar.zst" | sha256sum -c - wget https://repo.msys2.org/mingw/mingw64/mingw-w64-x86_64-libwinpthread-14.0.0.r375.g9c1abbbf5-1-any.pkg.tar.zst - echo "1d0ed7fda332a5c879de210f3d72c75fa1f3df7cc63dd951e763dec8eb02c1ee mingw-w64-x86_64-libwinpthread-14.0.0.r375.g9c1abbbf5-1-any.pkg.tar.zst" | sha256sum -c - wget https://repo.msys2.org/mingw/mingw64/mingw-w64-x86_64-winstorecompat-14.0.0.r375.g9c1abbbf5-1-any.pkg.tar.zst - echo "7fcafd7ba30bd47000263e76a06bd893406c64f88955825f0a9188407a35c3d3 mingw-w64-x86_64-winstorecompat-14.0.0.r375.g9c1abbbf5-1-any.pkg.tar.zst" | sha256sum -c - wget https://repo.msys2.org/mingw/mingw64/mingw-w64-x86_64-tools-14.0.0.r375.g9c1abbbf5-1-any.pkg.tar.zst - echo "c17557d09371e39db38deb56c7da6ae54e2c65b6f3466ca02f4da26b616ca8c3 mingw-w64-x86_64-tools-14.0.0.r375.g9c1abbbf5-1-any.pkg.tar.zst" | sha256sum -c - wget https://repo.msys2.org/mingw/mingw64/mingw-w64-x86_64-pkgconf-1~3.0.7-1-any.pkg.tar.zst - echo "37b97f372409fa7cf54d709bab892f34e9c62d2658230a09f783a89a55ae590e mingw-w64-x86_64-pkgconf-1~3.0.7-1-any.pkg.tar.zst" | sha256sum -c - wget https://repo.msys2.org/mingw/mingw64/mingw-w64-x86_64-make-4.4.1-5-any.pkg.tar.zst - echo "c19e7caf09bbc89b2730556b2da73004118d4e1f967a685cc48524c7ff80d864 mingw-w64-x86_64-make-4.4.1-5-any.pkg.tar.zst" | sha256sum -c - wget https://repo.msys2.org/mingw/mingw64/mingw-w64-x86_64-gcc-libs-16.2.0-3-any.pkg.tar.zst - echo "f8e25ea67bb796e7f65550f0dca9fce4cdde8aaa3dadafe4d13c6a8233c8de26 mingw-w64-x86_64-gcc-libs-16.2.0-3-any.pkg.tar.zst" | sha256sum -c - wget https://repo.msys2.org/mingw/mingw64/mingw-w64-x86_64-gcc-16.2.0-3-any.pkg.tar.zst - echo "8b37c953ae12f3d8fa05c854236463231ea0a294dff423007cbd93d4d8089f9f mingw-w64-x86_64-gcc-16.2.0-3-any.pkg.tar.zst" | sha256sum -c - # gcc-libs is split into libgcc, libstdc++ and cc-libs since 16.2.0-4 and the - # new packages conflict with the pinned gcc-libs, so drop them before the downgrade - for p in libgcc libstdc++ cc-libs; do - if pacman -Q mingw-w64-x86_64-$p > /dev/null 2>&1; then - pacman -Rdd --noconfirm mingw-w64-x86_64-$p - fi - done - pacman -U --noconfirm \ - mingw-w64-x86_64-headers-14.0.0.r375.g9c1abbbf5-1-any.pkg.tar.zst \ - mingw-w64-x86_64-crt-14.0.0.r375.g9c1abbbf5-1-any.pkg.tar.zst \ - mingw-w64-x86_64-binutils-2.47-3-any.pkg.tar.zst \ - mingw-w64-x86_64-libmangle-14.0.0.r375.g9c1abbbf5-1-any.pkg.tar.zst \ - mingw-w64-x86_64-winpthreads-14.0.0.r375.g9c1abbbf5-1-any.pkg.tar.zst \ - mingw-w64-x86_64-libwinpthread-14.0.0.r375.g9c1abbbf5-1-any.pkg.tar.zst \ - mingw-w64-x86_64-winstorecompat-14.0.0.r375.g9c1abbbf5-1-any.pkg.tar.zst \ - mingw-w64-x86_64-tools-14.0.0.r375.g9c1abbbf5-1-any.pkg.tar.zst \ - mingw-w64-x86_64-pkgconf-1~3.0.7-1-any.pkg.tar.zst \ - mingw-w64-x86_64-make-4.4.1-5-any.pkg.tar.zst \ - mingw-w64-x86_64-gcc-libs-16.2.0-3-any.pkg.tar.zst \ - mingw-w64-x86_64-gcc-16.2.0-3-any.pkg.tar.zst - - - name: Install ICU v78.3 - run: | - wget https://repo.msys2.org/mingw/mingw64/mingw-w64-x86_64-icu-78.3-4-any.pkg.tar.zst - echo "8486a018aca2e56d1fcd2eed2069011f2e1da02e03af72b38916ee06cbe7203f mingw-w64-x86_64-icu-78.3-4-any.pkg.tar.zst" | sha256sum -c - pacman -U --noconfirm mingw-w64-x86_64-icu-78.3-4-any.pkg.tar.zst - - - name: Install hidapi v0.15.0 and libusb v1.0.30 - run: | - # dropped from the msys2 mingw64 repo, install the archived packages - wget https://repo.msys2.org/mingw/mingw64/mingw-w64-x86_64-hidapi-0.15.0-2-any.pkg.tar.zst - echo "89fb61549a437d65076a092a367fcb264fc7045ee9ebef48cd81f5a76a5588f8 mingw-w64-x86_64-hidapi-0.15.0-2-any.pkg.tar.zst" | sha256sum -c - wget https://repo.msys2.org/mingw/mingw64/mingw-w64-x86_64-libusb-1.0.30-1-any.pkg.tar.zst - echo "124edc26b009678a4c5e759481a364abf63ed7f2f49a53092e8bd0a47c0c0740 mingw-w64-x86_64-libusb-1.0.30-1-any.pkg.tar.zst" | sha256sum -c - pacman -U --noconfirm mingw-w64-x86_64-hidapi-0.15.0-2-any.pkg.tar.zst mingw-w64-x86_64-libusb-1.0.30-1-any.pkg.tar.zst - - - name: Install boost v1.87.0 - run: | - wget https://repo.msys2.org/mingw/mingw64/mingw-w64-x86_64-boost-1.87.0-3-any.pkg.tar.zst - echo "241919a5885a9270d0e0937e71cf5e146c2a8cabecc2714f09248350181cb1b6 mingw-w64-x86_64-boost-1.87.0-3-any.pkg.tar.zst" | sha256sum -c - wget https://repo.msys2.org/mingw/mingw64/mingw-w64-x86_64-boost-libs-1.87.0-3-any.pkg.tar.zst - echo "5fd77df3e5983ba0d9c689f46151119e0e59b3da6850c5a0ba54068eeae7749c mingw-w64-x86_64-boost-libs-1.87.0-3-any.pkg.tar.zst" | sha256sum -c - # the version that monero-cpp builds with. The boost-libs in the repo is a newer rebuild that needs the split gcc runtime - pacman -U --noconfirm mingw-w64-x86_64-boost-1.87.0-3-any.pkg.tar.zst mingw-w64-x86_64-boost-libs-1.87.0-3-any.pkg.tar.zst - - - name: Install pybind11 v2.13.6 - run: | - wget https://repo.msys2.org/mingw/mingw64/mingw-w64-x86_64-pybind11-2.13.6-2-any.pkg.tar.zst - echo "5b56ad87bc544336b2d51edb8bb0614f46542571362daf4d7e53bf23120175a1 mingw-w64-x86_64-pybind11-2.13.6-2-any.pkg.tar.zst" | sha256sum -c - pacman -U --noconfirm mingw-w64-x86_64-pybind11-2.13.6-2-any.pkg.tar.zst - - - name: Restore ccache - uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0 - with: - path: .ccache - key: ccache-windows - restore-keys: | - ccache-windows_ - - - name: Reset ccache statistics - run: ccache --zero-stats - - - name: Build monero-project - run: | - cd external/monero-cpp/external/monero-project - mkdir -p build/release - cd build/release - cmake -G "MSYS Makefiles" \ - -D STATIC=ON \ - -D ARCH="x86-64" \ - -D BUILD_64=ON \ - -D CMAKE_BUILD_TYPE=Release \ - -D BUILD_TAG="win-x64" \ - -D CMAKE_TOOLCHAIN_FILE="../../cmake/64-bit-toolchain.cmake" \ - -D MSYS2_FOLDER=$(cd $MINGW_PREFIX/.. && pwd -W) \ - ../../ - make -j$(nproc) wallet cryptonote_protocol - - - name: Build monero-cpp libraries - run: | - cd external/monero-cpp - mkdir -p build - cd build - cmake .. -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache - cmake --build . --parallel $(nproc) - - - name: Build monero-python module - run: | - mkdir -p build - cd build - export WIN_PYTHON_EXE=$(cygpath -u "$pythonLocation/python.exe") - cmake .. -DPython3_EXECUTABLE="$WIN_PYTHON_EXE" \ - -DPython3_FIND_STRATEGY=LOCATION \ - -DPython3_FIND_REGISTRY=NEVER - cmake --build . --parallel $(nproc) - mkdir -p ../dist - cp *.pyd ../dist/monero.pyd - cd ../dist - ntldd -R *.pyd | grep mingw64 | awk '{print $3}' | while read -r line; do - cp "$(cygpath -u "$line")" . - done - cd .. - - - name: Show ccache statistics - if: ${{ !cancelled() }} - run: ccache --show-stats - - - name: Save ccache - # Pull requests only read the cache, pushes to main and manual runs replace it. - if: ${{ !cancelled() && github.event_name != 'pull_request' }} - uses: ./.github/actions/save-ccache - with: - key: ccache-windows - - - name: Run unit tests - shell: bash - env: - IN_CONTAINER: "true" - PYTHONPATH: ${{ github.workspace }}/dist - PATH: "${{ github.workspace }}/dist:/usr/bin:$PATH" - run: | - python -m pytest -m unit - - mac-os: - name: ${{ matrix.arch }} (pytest) - runs-on: ${{ matrix.os }} - permissions: - contents: read - actions: write # replace the ccache entries - timeout-minutes: 120 - env: - CCACHE_DIR: ${{ github.workspace }}/.ccache - CCACHE_MAXSIZE: 500M - CCACHE_COMPILERCHECK: "%compiler% -v" - - strategy: - fail-fast: false - matrix: - include: - - os: macos-15 - arch: mac-arm64 - - os: macos-15-intel - arch: mac-x86_64 - - steps: - - name: Checkout repository - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - with: - persist-credentials: false - submodules: recursive - - - name: Install dependencies - run: | - HOMEBREW_NO_AUTO_UPDATE=1 brew install python boost@1.85 hidapi openssl@3 zmq libpgm miniupnpc expat libunwind-headers protobuf ccache - brew unlink boost || true - brew link boost@1.85 --force - # brew links openssl@4 into /opt/homebrew, and the -I/opt/homebrew/include of boost and zeromq comes - # before the one of openssl@3, so its headers win over the ones of OPENSSL_ROOT_DIR - brew unlink openssl@4 || true - # brew's openssl is OpenSSL 4 on the newer runner images, which boost 1.85 does not build with. - # monero-project and monero-cpp take brew's openssl unless they are given another one, so - # they get it on the command line, and the module finds it in the environment - echo "OPENSSL_ROOT_DIR=$(brew --prefix openssl@3)" >> "$GITHUB_ENV" - # a virtual environment: the python of brew has packages that pip can not replace, such as wheel and typing_extensions on the - # Intel runner (they have no RECORD file), and the versions of the requirements files are pinned. The next steps find it first in the PATH - python3 -m venv "$RUNNER_TEMP/venv" - echo "$RUNNER_TEMP/venv/bin" >> "$GITHUB_PATH" - "$RUNNER_TEMP/venv/bin/pip" install -r tests/requirements.txt -r requirements-build.txt - - # static, against openssl@3: the unbound of brew is built with OpenSSL 4 - - name: Install unbound (static) - run: bin/install_unbound_macos.sh - - - name: Restore ccache - uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0 - with: - path: .ccache - key: ccache-${{ matrix.os }} - restore-keys: | - ccache-${{ matrix.os }}_ - - - name: Reset ccache statistics - run: ccache --zero-stats - - - name: Build monero-project - run: | - cd external/monero-cpp/external/monero-project - mkdir -p build/release - cd build/release - # monero builds with -march=native unless it is told which cpu to build for, and objects compiled - # on a runner with newer instructions, restored by ccache or shipped in a package, end in an illegal - # instruction on another cpu - ARCH=$([ "$(uname -m)" = x86_64 ] && echo x86-64 || echo armv8-a) - cmake -DSTATIC=ON -DARCH="$ARCH" -DBUILD_64=ON -DCMAKE_BUILD_TYPE=Release -DOPENSSL_ROOT_DIR="$OPENSSL_ROOT_DIR" ../../ - make -j3 wallet cryptonote_protocol - cd ../../../../../../ - - - name: Build monero-cpp libraries - run: | - cd external/monero-cpp - mkdir -p build - cd build - cmake .. -DOPENSSL_ROOT_DIR="$OPENSSL_ROOT_DIR" -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache - cmake --build . - make -j3 - cd ../../../ - - - name: Build monero-python module - run: | - mkdir -p build - pip3 install --no-build-isolation -vvv . - - - name: Show ccache statistics - if: ${{ !cancelled() }} - run: ccache --show-stats - - - name: Save ccache - # Pull requests only read the cache, pushes to main and manual runs replace it. - if: ${{ !cancelled() && github.event_name != 'pull_request' }} - uses: ./.github/actions/save-ccache - with: - key: ccache-${{ matrix.os }} - - - name: Run unit tests - run: | - pytest -m unit From 7a05c05d4bbd2d340099befca7a95b1d784a7548 Mon Sep 17 00:00:00 2001 From: everoddandeven Date: Sat, 14 Nov 2026 18:28:52 +0100 Subject: [PATCH 3/6] ci: build Linux once and run its tests in shards --- .github/workflows/build-linux.yml | 131 ++++++++++++++++++ .github/workflows/build.yml | 190 +++++++++++++++++++++++++- .github/workflows/test.yml | 217 ------------------------------ 3 files changed, 319 insertions(+), 219 deletions(-) create mode 100644 .github/workflows/build-linux.yml delete mode 100644 .github/workflows/test.yml diff --git a/.github/workflows/build-linux.yml b/.github/workflows/build-linux.yml new file mode 100644 index 0000000..9509325 --- /dev/null +++ b/.github/workflows/build-linux.yml @@ -0,0 +1,131 @@ +name: Build Linux Module + +# Called by build.yml. It builds monero-project, monero-cpp and the module, the last two with the coverage on, and uploads the module +# with the files that the coverage needs. The tests of build.yml run on it, in several jobs. The packages of Linux are the deb ones, +# which build-deb.yml makes. +on: + workflow_call: + +permissions: + contents: read + actions: write # replace the ccache entries + +jobs: + ubuntu: + name: linux-x86_64 + runs-on: ubuntu-24.04 + timeout-minutes: 120 + env: + CCACHE_DIR: ${{ github.workspace }}/.ccache + CCACHE_MAXSIZE: 500M + + steps: + - name: Checkout repository + uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 + with: + persist-credentials: false + submodules: recursive + + - name: Install dependencies + run: | + sudo apt update + sudo apt install -y build-essential cmake pkg-config libssl-dev libzmq3-dev libunbound-dev libsodium-dev libunwind8-dev liblzma-dev libreadline6-dev libexpat1-dev libpgm-dev qttools5-dev-tools libhidapi-dev libusb-1.0-0-dev libprotobuf-dev protobuf-compiler libudev-dev libboost-chrono-dev libboost-date-time-dev libboost-filesystem-dev libboost-locale-dev libboost-program-options-dev libboost-regex-dev libboost-serialization-dev libboost-system-dev libboost-thread-dev python3 ccache doxygen graphviz git curl autoconf libtool gperf nettle-dev libevent-dev debhelper python3-all python3-pip lcov + pip3 install -r requirements-build.txt --break-system-packages + + - name: Install expat + run: | + wget https://github.com/libexpat/libexpat/releases/download/R_2_7_1/expat-2.7.1.tar.bz2 + echo "45c98ae1e9b5127325d25186cf8c511fa814078e9efeae7987a574b482b79b3d expat-2.7.1.tar.bz2" | sha256sum -c + tar -xf expat-2.7.1.tar.bz2 + cd expat-2.7.1 + ./configure --enable-static --disable-shared --with-pic + make + sudo make install + cd ../ + + - name: Install unbound + run: | + wget https://www.nlnetlabs.nl/downloads/unbound/unbound-1.22.0.tar.gz + echo "c5dd1bdef5d5685b2cedb749158dd152c52d44f65529a34ac15cd88d4b1b3d43 unbound-1.22.0.tar.gz" | sha256sum -c + tar xzf unbound-1.22.0.tar.gz + cd unbound-1.22.0 + ./configure --with-libexpat=/usr/local --with-ssl=/usr --enable-static --disable-shared --with-pic + # monero only needs libunbound, skip the daemon and the tools + make -j"$(nproc)" lib + sudo make install-lib + cd ../ + + - name: Restore ccache + uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0 + with: + path: .ccache + key: ccache-linux-test + restore-keys: | + ccache-linux-test_ + + - name: Reset ccache statistics + run: ccache --zero-stats + + - name: Build monero-project + run: | + cd external/monero-cpp/external/monero-project + mkdir -p build/release + cd build/release + # monero builds with -march=native unless it is told which cpu to build for, and objects compiled + # on a runner with newer instructions, restored by ccache or shipped in a package, end in an illegal + # instruction on another cpu + cmake -DSTATIC=ON -DARCH=x86-64 -DBUILD_64=ON -DCMAKE_BUILD_TYPE=Release ../../ + make -j3 wallet cryptonote_protocol + cd ../../../../../../ + + - name: Build monero-cpp libraries + run: | + cd external/monero-cpp + mkdir -p build + cd build + cmake .. -DENABLE_COVERAGE=ON -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache + cmake --build . + make -j3 + cd ../../../ + + - name: Build monero-python module + run: | + mkdir -p build + cmake -B build -DENABLE_COVERAGE=ON -Dpybind11_DIR="$(python3 -m pybind11 --cmakedir)" + cmake --build build + + # stubgen, pinned because a new version can report more, reads the signatures that pybind11 writes in + # the docstrings and fails on what is wrong with the bindings: a C++ type that leaked into one, a default + # that is only a repr, a parameter with no name. The bindings are the same on every platform. + - name: Lint the bindings with pybind11-stubgen + env: + PYTHONPATH: ${{ github.workspace }}/build + run: python3 bin/lint_bindings.py + + - name: Show ccache statistics + if: ${{ !cancelled() }} + run: ccache --show-stats + + - name: Save ccache + # Pull requests only read the cache, pushes to main and manual runs replace it. + if: ${{ !cancelled() && github.event_name != 'pull_request' }} + uses: ./.github/actions/save-ccache + with: + key: ccache-linux-test + + # The module, and the .gcno that lcov reads together with the .gcda that the tests write: the ones of monero-cpp and of the module + # are the only ones, monero-project is not built with the coverage. The tests of build.yml extract it at the root of the + # workspace, where the paths of the .gcda are the ones that the build had. + - name: Package the build for the tests + run: | + find build external/monero-cpp/build \( -name 'monero*.so' -o -name '*.gcno' \) -print0 | tar --null -czf linux-build.tar.gz -T - + ls -l linux-build.tar.gz + + - name: Upload monero-python build + uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2 + with: + name: monero-python-linux-x86_64 + path: linux-build.tar.gz + # already compressed + compression-level: 0 + retention-days: 7 diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 02d3194..bbeb661 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -1,7 +1,8 @@ name: Build -# The builds are in build-windows.yml and build-macos.yml, called from here, and the tests run on what they built: the wheel -# that a build uploads is the one that its tests install, so nothing is compiled twice. +# The builds are in build-linux.yml, build-windows.yml and build-macos.yml, called from here, and the tests run on what they built: the +# wheel that a build uploads is the one that its tests install, and the module of Linux is the one that its shards download, so nothing +# is compiled twice. The tests of Linux are in shards, each with its own nodes and wallets, and a last job merges their coverage. on: push: branches: @@ -37,6 +38,12 @@ permissions: contents: read jobs: + build-ubuntu: + permissions: + contents: read + actions: write # build-linux.yml replaces its ccache entries + uses: ./.github/workflows/build-linux.yml + build-windows: permissions: contents: read @@ -126,3 +133,182 @@ jobs: - name: Run unit tests run: | pytest -m unit + + # The shards cover every test once: the unit ones, and the ones that need the nodes and the wallet rpc, by file. Together they are the + # 1032 tests that the single job of Tests ran. A shard has its own docker environment and its own chain, so the integration ones + # do not wait for each other. What is not marked (tests/test_monero_rpc_connection.py) runs with the rpc daemon. + test-ubuntu: + name: linux-x86_64 ${{ matrix.name }} (pytest) + needs: build-ubuntu + runs-on: ubuntu-24.04 + timeout-minutes: 90 + + strategy: + fail-fast: false + matrix: + include: + - name: unit + pytest: -m unit tests + docker: false + - name: wallet-full + pytest: -m integration tests/test_monero_wallet_full.py + docker: true + - name: wallet-rpc + pytest: -m integration tests/test_monero_wallet_rpc.py + docker: true + - name: daemon-rpc + pytest: tests/test_monero_daemon_rpc.py tests/test_monero_rpc_connection.py + docker: true + + steps: + - name: Checkout repository + uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 + with: + persist-credentials: false + submodules: recursive + + - name: Download monero-python build + uses: actions/download-artifact@9000827ccba6bdab643e8b6fd33ac0654aef8333 # v8.0.2 + with: + name: monero-python-linux-x86_64 + + # at the root of the workspace: the module in build/, and the .gcno where the tests will write the .gcda + - name: Extract monero-python build + run: tar -xzf linux-build.tar.gz + + - name: Install dependencies + run: | + sudo apt-get update + sudo apt-get install -y lcov + pip3 install -r tests/requirements.txt --break-system-packages + + - name: Setup test environment + if: ${{ matrix.docker }} + run: | + docker compose -f tests/docker-compose.yml up -d node_1 node_2 xmr_wallet_1 xmr_wallet_2 xmr_wallet_3 + sleep 10 + + # --durations shows where a shard spends its time, to balance them + - name: Run tests + env: + IN_CONTAINER: "true" + PYTHONPATH: ${{ github.workspace }}/build + COVERAGE_FILE: pytest-coverage-${{ matrix.name }} + PYTEST_ARGS: ${{ matrix.pytest }} + run: | + read -r -a args <<< "$PYTEST_ARGS" + pytest --cov=tests --cov-report= --durations=25 "${args[@]}" + + - name: Dump container logs + if: ${{ always() && matrix.docker }} + run: | + mkdir -p container-logs + for svc in node_1 node_2 xmr_wallet_1 xmr_wallet_2 xmr_wallet_3; do + docker compose -f tests/docker-compose.yml logs --no-color --timestamps "$svc" > "container-logs/$svc.log" 2>&1 || true + done + + - name: Upload container logs + if: ${{ always() && matrix.docker }} + uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2 + with: + name: container-logs-${{ matrix.name }} + path: container-logs/ + + - name: Cleanup test environment + if: ${{ always() && matrix.docker }} + run: docker compose -f tests/docker-compose.yml down -v + + - name: Upload tests logs + if: always() + uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2 + with: + name: test-logs-${{ matrix.name }} + path: monero_tests_*.log + + # the coverage of this shard, as lcov tracefiles. The coverage job merges them + - name: Capture the coverage of the module + if: always() + run: | + lcov --capture --directory build --ignore-errors mismatch,mismatch,inconsistent,source,source,gcov,gcov --output-file coverage_full.info + lcov --ignore-errors unused,unused --remove coverage_full.info '/usr/*' '*/external/*' '*/pybind11/*' '*monero-cpp/*' '*monero-project/*' --output-file coverage.info + sed -i "s|$(pwd)/||g" coverage.info + + - name: Capture the coverage of monero-cpp + if: always() + run: | + lcov --capture --directory external/monero-cpp/build --directory build --ignore-errors mismatch,mismatch,inconsistent,source,source,gcov,gcov --output-file coverage_monero_cpp_full.info + lcov --ignore-errors unused,unused --extract coverage_monero_cpp_full.info '*/monero-cpp/src/*' --output-file coverage_monero_cpp.info + sed -i "s|$(pwd)/||g" coverage_monero_cpp.info + + - name: Upload the coverage of the shard + if: always() + uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2 + with: + name: coverage-${{ matrix.name }} + path: | + coverage.info + coverage_monero_cpp.info + pytest-coverage-${{ matrix.name }} + + # The coverage of the tests of all the shards, in the same reports that Tests made (the artifact has the same name, and Codacy and the + # release read it). It runs when a shard fails too, with the shards that have it, since a failing test is still reported. + coverage: + name: coverage + needs: [build-ubuntu, test-ubuntu] + if: ${{ !cancelled() && needs.build-ubuntu.result == 'success' }} + runs-on: ubuntu-24.04 + timeout-minutes: 30 + + steps: + - name: Checkout repository + uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 + with: + persist-credentials: false + submodules: recursive + + - name: Install dependencies + run: | + sudo apt-get update + sudo apt-get install -y lcov + pip3 install -r tests/requirements.txt --break-system-packages + + # a folder for each shard, named as the artifact + - name: Download the coverage of the shards + uses: actions/download-artifact@9000827ccba6bdab643e8b6fd33ac0654aef8333 # v8.0.2 + with: + pattern: coverage-* + path: shards + + - name: Generate python bindings coverage report + run: | + args=() + for f in shards/*/coverage.info; do args+=(-a "$f"); done + lcov "${args[@]}" --ignore-errors mismatch,mismatch,inconsistent,source,source,corrupt --output-file coverage.info + genhtml coverage.info --output-directory coverage_monero_python_bindings_html --ignore-errors mismatch,inconsistent,source,corrupt --title "monero-python bindings coverage @ ${GITHUB_SHA::7}" + lcov --summary coverage.info + + - name: Generate python tests coverage report + run: | + coverage combine shards/*/pytest-coverage-* + coverage xml + coverage html -d coverage_monero_python_tests_html --title "monero-python tests coverage @ ${GITHUB_SHA::7}" + + - name: Generate monero-cpp coverage report + run: | + args=() + for f in shards/*/coverage_monero_cpp.info; do args+=(-a "$f"); done + lcov "${args[@]}" --ignore-errors mismatch,mismatch,inconsistent,source,source,corrupt --output-file coverage_monero_cpp.info + genhtml coverage_monero_cpp.info --output-directory coverage_monero_cpp_html --ignore-errors mismatch,inconsistent,source,corrupt --title "monero-cpp coverage @ ${GITHUB_SHA::7}" + lcov --summary coverage_monero_cpp.info + + - name: Upload coverage report + uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2 + with: + name: coverage-reports-linux + path: | + coverage.info + coverage.xml + coverage_monero_cpp.info + coverage_monero_cpp_html/ + coverage_monero_python_bindings_html/ + coverage_monero_python_tests_html/ diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml deleted file mode 100644 index 4dd171a..0000000 --- a/.github/workflows/test.yml +++ /dev/null @@ -1,217 +0,0 @@ -name: 'Tests' - -on: - push: - branches: - - main - pull_request: - branches: - - main - # Only on pull requests: the release needs a successful run for every commit on main. - # If Tests ever becomes a required check, a skipped run stays Pending and blocks the merge. - paths-ignore: - - 'README.md' - - 'LICENSE' - - '.gitignore' - - 'donate.png' - - 'docs/**' - # other workflows, not run by this one (build-*.yml have their own pull_request trigger) - - '.github/workflows/build-*.yml' - - '.github/workflows/codacy.yml' - - '.github/workflows/release.yml' - - '.github/workflows/lint-workflows.yml' - - '.github/zizmor.yml' - - '.github/dependabot.yml' - - workflow_dispatch: - -# A new push to a pull request cancels the previous run. Runs that are not -# from a pull request get their own group so they are never cancelled or replaced. -concurrency: - group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }} - cancel-in-progress: ${{ github.event_name == 'pull_request' }} - -permissions: - contents: read - -jobs: - ubuntu: - runs-on: ubuntu-24.04 - permissions: - contents: read - actions: write # replace the ccache entries - name: linux-x86_64 (pytest) - timeout-minutes: 120 - env: - CCACHE_DIR: ${{ github.workspace }}/.ccache - CCACHE_MAXSIZE: 500M - - steps: - - name: Checkout repository - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - with: - persist-credentials: false - submodules: recursive - - - name: Install dependencies - run: | - sudo apt update - sudo apt install -y build-essential cmake pkg-config libssl-dev libzmq3-dev libunbound-dev libsodium-dev libunwind8-dev liblzma-dev libreadline6-dev libexpat1-dev libpgm-dev qttools5-dev-tools libhidapi-dev libusb-1.0-0-dev libprotobuf-dev protobuf-compiler libudev-dev libboost-chrono-dev libboost-date-time-dev libboost-filesystem-dev libboost-locale-dev libboost-program-options-dev libboost-regex-dev libboost-serialization-dev libboost-system-dev libboost-thread-dev python3 ccache doxygen graphviz git curl autoconf libtool gperf nettle-dev libevent-dev debhelper python3-all python3-pip lcov - pip3 install -r tests/requirements.txt -r requirements-build.txt --break-system-packages - - - name: Install expat - run: | - wget https://github.com/libexpat/libexpat/releases/download/R_2_7_1/expat-2.7.1.tar.bz2 - echo "45c98ae1e9b5127325d25186cf8c511fa814078e9efeae7987a574b482b79b3d expat-2.7.1.tar.bz2" | sha256sum -c - tar -xf expat-2.7.1.tar.bz2 - cd expat-2.7.1 - ./configure --enable-static --disable-shared --with-pic - make - sudo make install - cd ../ - - - name: Install unbound - run: | - wget https://www.nlnetlabs.nl/downloads/unbound/unbound-1.22.0.tar.gz - echo "c5dd1bdef5d5685b2cedb749158dd152c52d44f65529a34ac15cd88d4b1b3d43 unbound-1.22.0.tar.gz" | sha256sum -c - tar xzf unbound-1.22.0.tar.gz - cd unbound-1.22.0 - ./configure --with-libexpat=/usr/local --with-ssl=/usr --enable-static --disable-shared --with-pic - # monero only needs libunbound, skip the daemon and the tools - make -j"$(nproc)" lib - sudo make install-lib - cd ../ - - - name: Restore ccache - uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0 - with: - path: .ccache - key: ccache-linux-test - restore-keys: | - ccache-linux-test_ - - - name: Reset ccache statistics - run: ccache --zero-stats - - - name: Build monero-project - run: | - cd external/monero-cpp/external/monero-project - mkdir -p build/release - cd build/release - # monero builds with -march=native unless it is told which cpu to build for, and objects compiled - # on a runner with newer instructions, restored by ccache or shipped in a package, end in an illegal - # instruction on another cpu - cmake -DSTATIC=ON -DARCH=x86-64 -DBUILD_64=ON -DCMAKE_BUILD_TYPE=Release ../../ - make -j3 wallet cryptonote_protocol - cd ../../../../../../ - - - name: Build monero-cpp libraries - run: | - cd external/monero-cpp - mkdir -p build - cd build - cmake .. -DENABLE_COVERAGE=ON -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache - cmake --build . - make -j3 - cd ../../../ - - - name: Build monero-python module - run: | - mkdir -p build - cmake -B build -DENABLE_COVERAGE=ON -Dpybind11_DIR="$(python3 -m pybind11 --cmakedir)" - cmake --build build - cp build/monero.cpython-312-x86_64-linux-gnu.so ~/.local/lib/python3.12/site-packages/ - - # stubgen, pinned because a new version can report more, reads the signatures that pybind11 writes in - # the docstrings and fails on what is wrong with the bindings: a C++ type that leaked into one, a default - # that is only a repr, a parameter with no name. The bindings are the same on every platform. - - name: Lint the bindings with pybind11-stubgen - run: python3 bin/lint_bindings.py - - - name: Show ccache statistics - if: ${{ !cancelled() }} - run: ccache --show-stats - - - name: Save ccache - # Pull requests only read the cache, pushes to main and manual runs replace it. - if: ${{ !cancelled() && github.event_name != 'pull_request' }} - uses: ./.github/actions/save-ccache - with: - key: ccache-linux-test - - - name: Setup test environment - run: | - docker compose -f tests/docker-compose.yml up -d node_1 node_2 xmr_wallet_1 xmr_wallet_2 xmr_wallet_3 - sleep 10 - - - name: Reset coverage counters - run: | - lcov --directory . --zerocounters - - - name: Run unit & integration tests - env: - IN_CONTAINER: "true" - run: | - pytest --cov=tests --cov-report=xml - - - name: Dump container logs - if: always() - run: | - mkdir -p container-logs - for svc in node_1 node_2 xmr_wallet_1 xmr_wallet_2 xmr_wallet_3; do - docker compose -f tests/docker-compose.yml logs --no-color --timestamps "$svc" > "container-logs/$svc.log" 2>&1 || true - done - - - name: Upload container logs - if: always() - uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2 - with: - name: container-logs-linux - path: container-logs/ - - - name: Cleanup test environment - if: always() - run: docker compose -f tests/docker-compose.yml down -v - - - name: Upload tests logs - if: always() - uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2 - with: - name: test-logs - path: monero_tests_*.log - - - name: Generate python bindings coverage report - if: always() - run: | - lcov --capture --directory build --ignore-errors mismatch,mismatch,inconsistent,source,source,gcov,gcov --output-file coverage_full.info - lcov --ignore-errors unused,unused --remove coverage_full.info '/usr/*' '*/external/*' '*/pybind11/*' '*monero-cpp/*' '*monero-project/*' --output-file coverage.info - sed -i "s|$(pwd)/||g" coverage.info - genhtml coverage.info --output-directory coverage_monero_python_bindings_html --ignore-errors mismatch,inconsistent,source,corrupt --title "monero-python bindings coverage @ ${GITHUB_SHA::7}" - lcov --summary coverage.info - - - name: Generate python tests coverage report - if: always() - run: | - coverage html -d coverage_monero_python_tests_html --title "monero-python tests coverage @ ${GITHUB_SHA::7}" - - - name: Generate monero-cpp coverage report - if: always() - run: | - lcov --capture --directory external/monero-cpp/build --directory build --ignore-errors mismatch,mismatch,inconsistent,source,source,gcov,gcov --output-file coverage_monero_cpp_full.info - lcov --ignore-errors unused,unused --extract coverage_monero_cpp_full.info '*/monero-cpp/src/*' --output-file coverage_monero_cpp.info - sed -i "s|$(pwd)/||g" coverage_monero_cpp.info - genhtml coverage_monero_cpp.info --output-directory coverage_monero_cpp_html --ignore-errors mismatch,inconsistent,source,corrupt --title "monero-cpp coverage @ ${GITHUB_SHA::7}" - lcov --summary coverage_monero_cpp.info - - - name: Upload coverage report - if: always() - uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2 - with: - name: coverage-reports-linux - path: | - coverage.info - coverage.xml - coverage_monero_cpp.info - coverage_monero_cpp_html/ - coverage_monero_python_bindings_html/ - coverage_monero_python_tests_html/ From 12c8dccc956725f1b7cc3a2d70219a0c6c7ae92a Mon Sep 17 00:00:00 2001 From: everoddandeven Date: Sat, 14 Nov 2026 18:29:23 +0100 Subject: [PATCH 4/6] ci: follow the Build workflow in the release, in Codacy and in the docs --- .github/workflows/build.yml | 2 +- .github/workflows/codacy.yml | 8 ++++---- .github/workflows/release.yml | 36 ++++++++++++++++------------------- README.md | 4 +--- bin/install_unbound_macos.sh | 2 +- docs/ci-ccache.md | 6 +++--- tests/requirements.txt | 2 +- 7 files changed, 27 insertions(+), 33 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index bbeb661..b002b40 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -135,7 +135,7 @@ jobs: pytest -m unit # The shards cover every test once: the unit ones, and the ones that need the nodes and the wallet rpc, by file. Together they are the - # 1032 tests that the single job of Tests ran. A shard has its own docker environment and its own chain, so the integration ones + # 1032 tests that the single Linux job ran before. A shard has its own docker environment and its own chain, so the integration ones # do not wait for each other. What is not marked (tests/test_monero_rpc_connection.py) runs with the rpc daemon. test-ubuntu: name: linux-x86_64 ${{ matrix.name }} (pytest) diff --git a/.github/workflows/codacy.yml b/.github/workflows/codacy.yml index 6204ad4..cbfd2d5 100644 --- a/.github/workflows/codacy.yml +++ b/.github/workflows/codacy.yml @@ -1,18 +1,18 @@ name: Codacy Coverage Reporter -# workflow_run is what gives this job the secret after a run of Tests on a pull request. It does not check out or run anything +# workflow_run is what gives this job the secret after a run of Build on a pull request. It does not check out or run anything # of the pull request: it downloads the coverage files, and reads them with a reporter pinned to a checksum. on: # zizmor: ignore[dangerous-triggers] workflow_run: workflows: - - Tests + - Build types: - completed workflow_dispatch: permissions: contents: read - # needed to download the artifact of the Tests run with the default GITHUB_TOKEN + # needed to download the artifact of the Build run with the default GITHUB_TOKEN actions: read jobs: @@ -51,7 +51,7 @@ jobs: if: ${{ !cancelled() && steps.download.outcome == 'success' }} env: CODACY_PROJECT_TOKEN: ${{ secrets.CODACY_PROJECT_TOKEN }} - # the commit that Tests ran on, which is the head of the pull request. A manual run has no workflow_run + # the commit that Build ran on, which is the head of the pull request. A manual run has no workflow_run COMMIT_UUID: ${{ github.event.workflow_run.head_sha || github.sha }} run: | ./codacy-coverage-reporter report --language python --coverage-reports coverage.xml --partial --commit-uuid "$COMMIT_UUID" diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 6224570..8b69eb1 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -10,15 +10,13 @@ permissions: actions: read jobs: - # the macos and windows builds and the tests are those of main, the deb ones are built here + # the macos and windows builds, the tests and the coverage are those of the Build run of main, the deb ones are built here check: name: Check the tag and the builds of main runs-on: ubuntu-latest timeout-minutes: 10 outputs: - build_macos_run_id: ${{ steps.find_runs.outputs.build_macos_run_id }} - build_windows_run_id: ${{ steps.find_runs.outputs.build_windows_run_id }} - test_run_id: ${{ steps.find_runs.outputs.test_run_id }} + build_run_id: ${{ steps.find_run.outputs.build_run_id }} steps: - name: Check the tag against the version in pyproject.toml @@ -38,22 +36,20 @@ jobs: exit 1 fi - - name: Find main-branch build runs for this commit - id: find_runs + # a successful run is one in which every build and every test passed + - name: Find the main-branch Build run for this commit + id: find_run env: GH_TOKEN: ${{ github.token }} run: | - for wf in build-macos.yml build-windows.yml test.yml; do - key=$(echo "${wf%.*}" | tr '-' '_') - run_id=$(gh run list --repo "${{ github.repository }}" --workflow "$wf" \ - --branch main --status success --limit 200 --json databaseId,headSha \ - --jq ".[] | select(.headSha == \"${{ github.sha }}\") | .databaseId" | head -n1) - if [ -z "$run_id" ]; then - echo "::error::No successful $wf run on main for commit ${{ github.sha }}. Push to main and wait for it to build before tagging." - exit 1 - fi - echo "${key}_run_id=${run_id}" >> "$GITHUB_OUTPUT" - done + run_id=$(gh run list --repo "${{ github.repository }}" --workflow build.yml \ + --branch main --status success --limit 200 --json databaseId,headSha \ + --jq ".[] | select(.headSha == \"${{ github.sha }}\") | .databaseId" | head -n1) + if [ -z "$run_id" ]; then + echo "::error::No successful Build run on main for commit ${{ github.sha }}. Push to main and wait for it to build and pass before tagging." + exit 1 + fi + echo "build_run_id=${run_id}" >> "$GITHUB_OUTPUT" # every release and architecture, the builds of main only have some of them deb: @@ -89,7 +85,7 @@ jobs: uses: actions/download-artifact@9000827ccba6bdab643e8b6fd33ac0654aef8333 # v8.0.2 with: github-token: ${{ github.token }} - run-id: ${{ needs.check.outputs.build_macos_run_id }} + run-id: ${{ needs.check.outputs.build_run_id }} pattern: monero-macos-* path: release-assets merge-multiple: true @@ -98,7 +94,7 @@ jobs: uses: actions/download-artifact@9000827ccba6bdab643e8b6fd33ac0654aef8333 # v8.0.2 with: github-token: ${{ github.token }} - run-id: ${{ needs.check.outputs.build_windows_run_id }} + run-id: ${{ needs.check.outputs.build_run_id }} name: monero-python-win-amd64 path: release-assets merge-multiple: true @@ -107,7 +103,7 @@ jobs: uses: actions/download-artifact@9000827ccba6bdab643e8b6fd33ac0654aef8333 # v8.0.2 with: github-token: ${{ github.token }} - run-id: ${{ needs.check.outputs.test_run_id }} + run-id: ${{ needs.check.outputs.build_run_id }} name: coverage-reports-linux path: coverage-report diff --git a/README.md b/README.md index affbba2..3714c76 100644 --- a/README.md +++ b/README.md @@ -2,11 +2,9 @@ [![Codacy Badge](https://app.codacy.com/project/badge/Grade/f6129b0bbe314061b34a262a4cb89109)](https://app.codacy.com/gh/libmonero/monero-python/dashboard?utm_source=gh&utm_medium=referral&utm_content=&utm_campaign=Badge_grade) [![Codacy Badge](https://app.codacy.com/project/badge/Coverage/f6129b0bbe314061b34a262a4cb89109)](https://app.codacy.com/gh/libmonero/monero-python/dashboard?utm_source=gh&utm_medium=referral&utm_content=&utm_campaign=Badge_coverage) -[![Tests](https://github.com/libmonero/monero-python/actions/workflows/test.yml/badge.svg?branch=main)](https://github.com/libmonero/monero-python/actions/workflows/test.yml) +[![Build](https://github.com/libmonero/monero-python/actions/workflows/build.yml/badge.svg?branch=main)](https://github.com/libmonero/monero-python/actions/workflows/build.yml) [![Build Debian Packages](https://github.com/libmonero/monero-python/actions/workflows/build-deb.yml/badge.svg?branch=main)](https://github.com/libmonero/monero-python/actions/workflows/build-deb.yml) -[![Build Windows Package](https://github.com/libmonero/monero-python/actions/workflows/build-windows.yml/badge.svg?branch=main)](https://github.com/libmonero/monero-python/actions/workflows/build-windows.yml) -[![Build MacOS](https://github.com/libmonero/monero-python/actions/workflows/build-macos.yml/badge.svg?branch=main)](https://github.com/libmonero/monero-python/actions/workflows/build-macos.yml) [![Pybind](https://img.shields.io/badge/pybind-v2-blue?logo=python&logoColor=white)](https://github.com/pybind/pybind11) [![Python](https://img.shields.io/badge/python-3.10_%7C_3.11_%7C_3.12_%7C_3.13_%7C_3.14-blue?logo=python&logoColor=white)](https://github.com/libmonero/monero-python#monero-python-library) diff --git a/bin/install_unbound_macos.sh b/bin/install_unbound_macos.sh index cb2d1b9..6982e5c 100755 --- a/bin/install_unbound_macos.sh +++ b/bin/install_unbound_macos.sh @@ -1,5 +1,5 @@ #!/usr/bin/env bash -# Builds libunbound as a static library in /usr/local against openssl@3, for the macOS builds (build-macos.yml and test.yml). It needs the +# Builds libunbound as a static library in /usr/local against openssl@3, for the macOS builds (build-macos.yml). It needs the # formulae expat and openssl@3 of brew, and sudo for the install. # # The unbound of brew is built with OpenSSL 4, and the module links OpenSSL 3 as boost 1.85 does not build with 4: the same as the diff --git a/docs/ci-ccache.md b/docs/ci-ccache.md index bee2f97..2da26d7 100644 --- a/docs/ci-ccache.md +++ b/docs/ci-ccache.md @@ -12,8 +12,8 @@ The workflows keep a ccache directory (`.ccache` in the workspace) between runs ### Where the cache lives - Key is `ccache-_`, restore falls back to the newest `ccache-_`. The `_` is there because `macos-15` is a prefix of `macos-15-intel`. -- macOS and Windows share a cache between `test.yml` and the `build-*.yml` workflows, the compile commands are the same. Linux tests have their own, the deb builds have one per distro and arch. -- Pull requests only restore. Pushes to main and manual runs (`workflow_dispatch`) save. This is on purpose, see quota below. The `build-*.yml` workflows also run on pull requests that touch their own files, and follow the same rule. +- Each build has its own cache: Linux, Windows and macOS (one for each architecture) in `build.yml`, and the deb builds one per distro and arch. The tests do not compile, they use what the builds uploaded. +- Pull requests only restore. Pushes to main and manual runs (`workflow_dispatch`) save. This is on purpose, see quota below. The deb workflow also runs on pull requests that touch its own files, and follows the same rule. - A cache saved on a branch is only visible to that branch. Main's caches are visible to everyone, so a pull request starts from main's. - The save step runs after the build and before the tests, so a flaky test doesn't throw the cache away. Failed builds save too, whatever got compiled is still good. @@ -44,6 +44,6 @@ Measured on `build monero` for Windows: about 9 minutes with a cold cache, about ### Checking it works -Run `test.yml` twice on the same branch with `workflow_dispatch`. Second run should show mostly hits in the "Show ccache statistics" step (for deb it's the end of the build step, printed by `debian/rules`). Stats are zeroed at the start of each job, so they're only for that run. +Run `build.yml` twice on the same branch with `workflow_dispatch`. Second run should show mostly hits in the "Show ccache statistics" step (for deb it's the end of the build step, printed by `debian/rules`). Stats are zeroed at the start of each job, so they're only for that run. To start over: `gh cache list`, then `gh cache delete `. diff --git a/tests/requirements.txt b/tests/requirements.txt index 8b73c13..4caa5f3 100644 --- a/tests/requirements.txt +++ b/tests/requirements.txt @@ -1,4 +1,4 @@ -# The versions that the tests run with, in CI (.github/workflows/test.yml) and locally: pip install -r tests/requirements.txt +# The versions that the tests run with, in CI (.github/workflows/build.yml) and locally: pip install -r tests/requirements.txt # Dependabot proposes the updates. coverage==7.17.3 pytest==9.2.0 From 74bec8131e632c72c79e71f920f46b9b88d17245 Mon Sep 17 00:00:00 2001 From: everoddandeven Date: Sat, 14 Nov 2026 18:35:30 +0100 Subject: [PATCH 5/6] ci: install the same apt packages in the Linux test shards as in the build --- .github/workflows/build-linux.yml | 3 +- .github/workflows/build.yml | 4 +-- bin/install_dependencies_linux.sh | 50 +++++++++++++++++++++++++++++++ 3 files changed, 53 insertions(+), 4 deletions(-) create mode 100755 bin/install_dependencies_linux.sh diff --git a/.github/workflows/build-linux.yml b/.github/workflows/build-linux.yml index 9509325..76de948 100644 --- a/.github/workflows/build-linux.yml +++ b/.github/workflows/build-linux.yml @@ -28,8 +28,7 @@ jobs: - name: Install dependencies run: | - sudo apt update - sudo apt install -y build-essential cmake pkg-config libssl-dev libzmq3-dev libunbound-dev libsodium-dev libunwind8-dev liblzma-dev libreadline6-dev libexpat1-dev libpgm-dev qttools5-dev-tools libhidapi-dev libusb-1.0-0-dev libprotobuf-dev protobuf-compiler libudev-dev libboost-chrono-dev libboost-date-time-dev libboost-filesystem-dev libboost-locale-dev libboost-program-options-dev libboost-regex-dev libboost-serialization-dev libboost-system-dev libboost-thread-dev python3 ccache doxygen graphviz git curl autoconf libtool gperf nettle-dev libevent-dev debhelper python3-all python3-pip lcov + bin/install_dependencies_linux.sh pip3 install -r requirements-build.txt --break-system-packages - name: Install expat diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index b002b40..42f73ed 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -176,10 +176,10 @@ jobs: - name: Extract monero-python build run: tar -xzf linux-build.tar.gz + # the module is linked to shared libraries of apt, the ones of the build - name: Install dependencies run: | - sudo apt-get update - sudo apt-get install -y lcov + bin/install_dependencies_linux.sh pip3 install -r tests/requirements.txt --break-system-packages - name: Setup test environment diff --git a/bin/install_dependencies_linux.sh b/bin/install_dependencies_linux.sh new file mode 100755 index 0000000..af30650 --- /dev/null +++ b/bin/install_dependencies_linux.sh @@ -0,0 +1,50 @@ +#!/usr/bin/env bash +# The packages of apt for the Linux build of build-linux.yml, and for the tests of build.yml: the module is linked to the shared libraries +# of some of them (the boost, zeromq, sodium and protobuf ones), so a job that only runs the module needs them too. The development packages +# bring the libraries, and are the same ones in both so that the module finds at run time what it was linked to. +set -euo pipefail + +sudo apt update +sudo apt install -y \ + build-essential \ + cmake \ + pkg-config \ + libssl-dev \ + libzmq3-dev \ + libunbound-dev \ + libsodium-dev \ + libunwind8-dev \ + liblzma-dev \ + libreadline6-dev \ + libexpat1-dev \ + libpgm-dev \ + qttools5-dev-tools \ + libhidapi-dev \ + libusb-1.0-0-dev \ + libprotobuf-dev \ + protobuf-compiler \ + libudev-dev \ + libboost-chrono-dev \ + libboost-date-time-dev \ + libboost-filesystem-dev \ + libboost-locale-dev \ + libboost-program-options-dev \ + libboost-regex-dev \ + libboost-serialization-dev \ + libboost-system-dev \ + libboost-thread-dev \ + python3 \ + ccache \ + doxygen \ + graphviz \ + git \ + curl \ + autoconf \ + libtool \ + gperf \ + nettle-dev \ + libevent-dev \ + debhelper \ + python3-all \ + python3-pip \ + lcov From 81b6044e398817064ef33fad2fb1c2ed134b1ca9 Mon Sep 17 00:00:00 2001 From: everoddandeven Date: Sat, 14 Nov 2026 19:07:34 +0100 Subject: [PATCH 6/6] ci: run integration tests in single job --- .github/workflows/build.yml | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 42f73ed..5a00402 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -147,17 +147,11 @@ jobs: fail-fast: false matrix: include: - - name: unit + - name: unit tests pytest: -m unit tests docker: false - - name: wallet-full - pytest: -m integration tests/test_monero_wallet_full.py - docker: true - - name: wallet-rpc - pytest: -m integration tests/test_monero_wallet_rpc.py - docker: true - - name: daemon-rpc - pytest: tests/test_monero_daemon_rpc.py tests/test_monero_rpc_connection.py + - name: integration tests + pytest: -m integration tests docker: true steps: