From 45b974406fb99e7b0f0ba2606bb0c739ef5005be Mon Sep 17 00:00:00 2001 From: leochiu Date: Tue, 21 Jul 2026 09:56:24 +0800 Subject: [PATCH 1/2] fix(banner): re-check PR creation flag on DOM change for Turbo nav GitHub's compare form now submits via Turbo (soft navigation), so the PR page is never fully reloaded and CreationFeature.initialize() does not re-run. Move checkForPRCreationSuccess() into onDomChange() as well, mirroring CloseFeature, so the stored creation flag is read on the PR page and the banner shows. Co-Authored-By: Claude Opus 4.8 --- src/content/features.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/content/features.ts b/src/content/features.ts index 33e675c..fb2e9ac 100644 --- a/src/content/features.ts +++ b/src/content/features.ts @@ -52,6 +52,10 @@ export class CreationFeature implements GitHubFeature { } onDomChange(): void { + checkForPRCreationSuccess({ + showSettings: this.options.showSettings, + onCreated: this.options.onCreated, + }); detectPRCreationButtons({ showSettings: this.options.showSettings, }); From 5ccfa81c05b03e27ecf598ca921ccc5b594952b5 Mon Sep 17 00:00:00 2001 From: leochiu Date: Tue, 21 Jul 2026 09:59:27 +0800 Subject: [PATCH 2/2] chore(changeset): add patch changeset for creation banner fix Co-Authored-By: Claude Opus 4.8 --- .changeset/creation-banner-turbo-nav.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/creation-banner-turbo-nav.md diff --git a/.changeset/creation-banner-turbo-nav.md b/.changeset/creation-banner-turbo-nav.md new file mode 100644 index 0000000..3c52c84 --- /dev/null +++ b/.changeset/creation-banner-turbo-nav.md @@ -0,0 +1,5 @@ +--- +'elden-ring-github': patch +--- + +Fix PR creation banner not appearing under GitHub's Turbo soft navigation. The compare form now submits without a full page reload, so `checkForPRCreationSuccess` is re-checked on DOM change (not only on init), mirroring the close feature.