From dd9488bb5e8557f700d56dfe0906ba1365cc6505 Mon Sep 17 00:00:00 2001 From: pemaghising Date: Fri, 18 Sep 2026 14:18:52 +0545 Subject: [PATCH 1/3] Promote type-reference overlay into index.css and fix audit findings type-reference.css was a temporary comparison overlay, self-described as deletable, but it shipped: index.js imported it and index.html carried data-typeref="on". Every rule was `[data-typeref=on] .class`, outranking the plain classes in index.css, so index.css read as the authority while the overlay actually rendered. Edits to index.css silently did nothing. Merge all 24 overrides into index.css and delete the overlay. No visual change; the site already rendered these values. --content-max moves to 1600px so the measure cap lives in the token rather than being contradicted by a shadow rule. Accessibility: - Collapsed mobile menu kept its five links in the tab order. max-height, opacity and pointer-events hide it visually but none remove it from the a11y tree; add visibility, delayed so it lands after the collapse. - Single dual-ring :focus-visible replacing three inconsistent rules. No palette colour clears 3:1 on both surfaces (cyan 4.59:1 on --surface but 1.27:1 on --paper; carbon the reverse), so a carbon band sits inside a cyan one and whichever vanishes, the other reads. Layout and type: - .wrap sizes with width, not max-width + padding. Removed the width from .hero-inner and the horizontal padding from .footer .wrap, both of which had been relying on the old mechanism and stacked or overrode the gutter. - Breakpoints consolidated 8 tiers to 5 and documented. - Recognition card titles down to clamp(1.25rem, 1.9vw, 1.8rem); ratio to body copy was 1.74, too hard a step for a stacked list row. - Title-to-copy gap 8px to 12px: line-height 1 strips the leading that would normally do half that work. - Timeline rows centre rather than baseline-align, so the date and phase sit against the middle of a multi-line copy column. - Beyond mech no longer cropped: the picture box computed to 1.425 against the artwork's 1.4471, and object-fit: cover trimmed the forearms. Derive height from aspect-ratio 2696/1863 instead. - IBM Plex Mono now loads 600 and 700. The overlay set font-weight 700 on .tag without them, so every eyebrow label was a synthesized fake bold. - All rgba() literals to color-mix() on tokens; .demoday .lede off the borders-only token; remaining 13.5px body copy onto the scale. Tooling: - .npmrc sets --openssl-legacy-provider. react-scripts 3.x on webpack 4 dies on Node 17+ with ERR_OSSL_EVP_UNSUPPORTED, so npm start failed for everyone. engines raised to >=18 because the flag postdates Node 16, which is long EOL. --- .gitignore | 4 + .impeccable/config.json | 23 +++ .npmrc | 10 ++ package.json | 2 +- public/index.html | 4 +- src/components/Beyond/index.js | 2 +- src/components/Footer/index.js | 2 +- src/components/Hero/index.js | 2 +- src/index.css | 305 ++++++++++++++++++++++++--------- src/index.js | 1 - src/type-reference.css | 180 ------------------- 11 files changed, 263 insertions(+), 272 deletions(-) create mode 100644 .impeccable/config.json create mode 100644 .npmrc delete mode 100644 src/type-reference.css diff --git a/.gitignore b/.gitignore index 289c9146..ff7cb0ea 100644 --- a/.gitignore +++ b/.gitignore @@ -25,3 +25,7 @@ yarn-error.log #vscode stuff .vscode .vercel + +# Impeccable detector cache (regenerated on every run; config.json is shared) +.impeccable/hook.cache.json +.impeccable/critique/ diff --git a/.impeccable/config.json b/.impeccable/config.json new file mode 100644 index 00000000..0715670c --- /dev/null +++ b/.impeccable/config.json @@ -0,0 +1,23 @@ +{ + "detector": { + "ignoreRules": [], + "ignoreFiles": [], + "ignoreValues": [ + { + "rule": "overused-font", + "value": "inter", + "createdAt": "2026-09-18T06:35:56.623Z", + "reason": "Committed design system: Inter is --font-body in src/index.css:33; Oswald carries the identity. Deck must match the site." + }, + { + "rule": "codex-grid-background", + "value": "*", + "files": [ + "src/index.css" + ], + "createdAt": "2026-09-18T08:14:07.239Z", + "reason": "Detector rule exempts blueprint/measurement surfaces; this site's committed art direction is an engineering-blueprint world (file header: 'Engineering grid'; .blueprint-grid is the brief, not decoration)" + } + ] + } +} diff --git a/.npmrc b/.npmrc new file mode 100644 index 00000000..14b372f2 --- /dev/null +++ b/.npmrc @@ -0,0 +1,10 @@ +# react-scripts 3.x builds on webpack 4, whose module hashing calls into an +# OpenSSL digest that Node 17+ removed from the default provider. Without this +# flag every `npm start` / `npm run build` dies with: +# Error: error:0308010C:digital envelope routines::unsupported +# +# npm applies `node-options` to the scripts it runs, so this fixes the whole +# team on every platform with no cross-env dependency and no per-shell setup. +# The real fix is upgrading react-scripts; this keeps the app runnable until +# then. Requires Node >= 17 (see "engines"), where the flag exists. +node-options=--openssl-legacy-provider diff --git a/package.json b/package.json index 9a257b92..f89c7409 100644 --- a/package.json +++ b/package.json @@ -44,7 +44,7 @@ "tailwindcss": "^0.6.6" }, "engines": { - "node": ">=16.0.0" + "node": ">=18.0.0" }, "browserslist": [ ">0.2%", diff --git a/public/index.html b/public/index.html index 4d131833..10b20af1 100644 --- a/public/index.html +++ b/public/index.html @@ -41,7 +41,7 @@ - the frogtoberfest team --> - + @@ -69,7 +69,7 @@ -

+

Commit to Something Real

diff --git a/src/components/Footer/index.js b/src/components/Footer/index.js index 4ca2eb71..7c961e8b 100644 --- a/src/components/Footer/index.js +++ b/src/components/Footer/index.js @@ -6,7 +6,7 @@ export default function Footer() {