fix: enable test_transform_bias_rescale_qkv_nested on XPU (issue #2182 fixed)#10
Open
laifenxiawucha wants to merge 1 commit into
Open
fix: enable test_transform_bias_rescale_qkv_nested on XPU (issue #2182 fixed)#10laifenxiawucha wants to merge 1 commit into
laifenxiawucha wants to merge 1 commit into
Conversation
…rch#2182 fixed) The underlying C++ issue (missing T-rounding for nested tensors in transform_bias_rescale_qkv_xpu) was fixed upstream via intel/torch-xpu-ops#2450. This removes the unconditional XPU skip that was guarding the test while the C++ fix was pending. CUDA reference: aten/src/ATen/native/transformers/cuda/attention.cu:621-629 Authored by Hermes Agent.
75de6a7 to
d7698f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The underlying C++ issue (missing T-rounding for nested tensors in
transform_bias_rescale_qkv_xpu) was fixed upstream via
intel/torch-xpu-ops#2450. This changes the unconditional XPU skip
to a no-op skip so the test runs now that the C++ fix is in place.
CUDA reference: aten/src/ATen/native/transformers/cuda/attention.cu:621-629
Reproducer
Self-Review
Authored by Hermes Agent.