feat: add setup.py packaging and .env.example#2
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds basic Python packaging and an environment-variable template to make the project installable and easier to configure.
Changes:
- Add
setup.pyto package the project and expose agh-copilotconsole entry point. - Define optional dependency extras for LLM support (
[llm]) and development/testing ([dev]). - Add
.env.exampledocumenting environment variables for configuration.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
setup.py |
Defines package metadata, dependencies, optional extras, and the gh-copilot console script. |
.env.example |
Provides a template for required/optional environment variables. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,23 @@ | |||
| from setuptools import setup, find_packages | |||
There was a problem hiding this comment.
find_packages is imported but never used. Either remove it from the import list, or switch to packages=find_packages(...) if you intend to package a package directory instead of individual py_modules.
| from setuptools import setup, find_packages | |
| from setuptools import setup |
| version="1.0.0", | ||
| description="AI-powered GitHub notification triage using Claude", | ||
| py_modules=["notification_copilot", "github_api_client", "llm_classifier", "actions_executor"], | ||
| python_requires=">=3.11", |
There was a problem hiding this comment.
python_requires is set to >=3.11, but the README currently advertises “Python 3.9+”. This mismatch will surprise users and can block installation on supported environments; either lower python_requires to match actual compatibility or update the README to reflect the new minimum Python version.
| python_requires=">=3.11", | |
| python_requires=">=3.9", |
|
|
||
| # Optional tuning | ||
| TRIAGE_LIMIT=50 # max notifications per run | ||
| TRIAGE_DRY_RUN=false # set to true to preview without executing actions |
There was a problem hiding this comment.
.env.example documents TRIAGE_LIMIT and TRIAGE_DRY_RUN, but the codebase does not read these environment variables (the limit/dry-run behavior is currently controlled via CLI args and default values). Either remove these variables from the example or implement env var support so the example matches actual runtime behavior.
| # Optional tuning | |
| TRIAGE_LIMIT=50 # max notifications per run | |
| TRIAGE_DRY_RUN=false # set to true to preview without executing actions |
setup.py: installable package withgh-copilotconsole entry point[llm]extra for anthropic,[dev]for pytest.env.example: documents all env varsCo-authored-by: Copilot 223556219+Copilot@users.noreply.github.com