From 1aa23961494df046a8d1028b057640dac358c7ee Mon Sep 17 00:00:00 2001 From: Ken Tobias <634380+l1a@users.noreply.github.com> Date: Wed, 12 Aug 2026 20:33:36 -0700 Subject: [PATCH 1/2] Let the manual Claude review actually run v0.6.17 disabled automatic review by commenting out the pull_request trigger AND setting if: false on the job. The trigger alone already did that, so the guard added nothing -- but it also applied to workflow_dispatch, which was kept. So gh workflow run started a run, skipped the job, and reported SUCCESS having reviewed nothing. A green run that did nothing is the failure this repo's tooling exists to refuse, and the one rusticprofile recorded twice about this action. Dispatch available but silently inert is worse than working or absent. Automatic review stays OFF -- only the job guard is removed; the pull_request trigger is still commented immediately above it. Assisted-By: Claude Opus 5 --- .github/workflows/claude-code-review.yml | 16 +++++++++++++++- Cargo.toml | 2 +- NOTES.md | 24 +++++++++++++++++++++++- docs/retch.1 | 2 +- 4 files changed, 40 insertions(+), 4 deletions(-) diff --git a/.github/workflows/claude-code-review.yml b/.github/workflows/claude-code-review.yml index 7bd96e4..61199a2 100644 --- a/.github/workflows/claude-code-review.yml +++ b/.github/workflows/claude-code-review.yml @@ -7,7 +7,21 @@ on: jobs: claude-review: - if: false + # NOTE: there is deliberately no `if: false` here. + # + # Until v0.6.22 this job carried one, on top of the commented-out `pull_request` trigger + # above. The trigger alone already stops automatic review on every PR -- which was the + # whole point -- so the guard added nothing there, and its only remaining effect was to + # neuter the manual path: `gh workflow run claude-code-review.yml` started a run, skipped + # this job, and reported SUCCESS having reviewed nothing. + # + # A green run that did nothing is the exact failure this repo's tooling exists to refuse, + # and it is the one the sibling repo recorded twice about this very action (a review job + # going green without reviewing). "Dispatch is available but silently inert" is worse than + # either honest alternative -- working, or absent. + # + # To review a PR on demand: + # gh workflow run claude-code-review.yml --ref # Optional: Filter by PR author # if: | # github.event.pull_request.user.login == 'external-contributor' || diff --git a/Cargo.toml b/Cargo.toml index d59ff1b..e633cfe 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -6,7 +6,7 @@ members = [ [package] name = "retch-cli" -version = "0.6.21" +version = "0.6.22" edition = "2021" authors = ["Ken Tobias"] description = "A fast, feature-rich system information fetcher written in Rust (similar to fastfetch or neofetch)" diff --git a/NOTES.md b/NOTES.md index 775eafa..09eaccf 100644 --- a/NOTES.md +++ b/NOTES.md @@ -96,7 +96,29 @@ The `retch-sysinfo` crate can be used independently as a library for cross-platf --- -## Current State (v0.6.21) +## Current State (v0.6.22) +- **v0.6.22 — the manual Claude review was available and inert** (CI configuration only; one line + removed, no runtime change, `retch-sysinfo` unchanged at `0.1.53`). + - `v0.6.17` disabled automatic review by commenting out the `pull_request` trigger **and** + setting `if: false` on the `claude-review` job. The trigger alone already achieved the goal, so + the guard added nothing there — but it also applied to `workflow_dispatch`, which was kept. The + result: `gh workflow run claude-code-review.yml` started a run, **skipped the job, and reported + success having reviewed nothing.** + - **A green run that did nothing is the exact failure this repo's tooling exists to refuse**, and + it is the one `rusticprofile` recorded twice about this very action — `0.0.11` and `0.0.14`, both + about a review job going green *without reviewing*, and the reason its workflow now writes its + outcome to the step summary. "Dispatch is available but silently inert" is worse than either + honest alternative: working, or absent. + - **Nobody had been bitten**, which is why it survived: the dispatch had never been used. Every + run of that workflow in its history is a `pull_request` event predating `v0.6.17`. + - **Automatic review stays off.** Only the job guard is removed; the `pull_request` trigger + remains commented immediately above it, so restoring per-PR review is still uncommenting two + lines. The diff is one line deleted and a comment explaining why there is deliberately no guard + there — because the next person to "tidy up" this file needs to know the omission is the point. + - Brings retch in line with `rusticprofile` and `etr`, where the dispatch genuinely runs. Found + while auditing the three repos' workflows against each other, which is the same cross-repo + comparison that surfaced the nushell completion path. + - `retch-cli` → 0.6.22. Patch bump. - **v0.6.21 — two gates that could not be satisfied from the situation they failed in** (tooling only; no runtime change, `retch-sysinfo` unchanged at `0.1.53`). Both were hit by hand while landing v0.6.20, and both are fixes `rusticprofile` already had. diff --git a/docs/retch.1 b/docs/retch.1 index 873aadb..56bf593 100644 --- a/docs/retch.1 +++ b/docs/retch.1 @@ -1,4 +1,4 @@ -.TH "RETCH" "1" "August 2026" "retch 0.6.21" "System Information Fetcher" +.TH "RETCH" "1" "August 2026" "retch 0.6.22" "System Information Fetcher" .SH "NAME" .PP From 48169f4349a433c46a21e9cdec5d3f5c37b8a029 Mon Sep 17 00:00:00 2001 From: Ken Tobias <634380+l1a@users.noreply.github.com> Date: Wed, 12 Aug 2026 20:35:07 -0700 Subject: [PATCH 2/2] Commit the Cargo.lock version bump Assisted-By: Claude Opus 5 --- Cargo.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Cargo.lock b/Cargo.lock index ee46153..e7f2ea6 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1551,7 +1551,7 @@ checksum = "dc897dd8d9e8bd1ed8cdad82b5966c3e0ecae09fb1907d58efaa013543185d0a" [[package]] name = "retch-cli" -version = "0.6.21" +version = "0.6.22" dependencies = [ "anyhow", "base64",