From 7ef28fac54ad23b2ef3e9c3fdcecbd29b07c9559 Mon Sep 17 00:00:00 2001 From: Matteo Gastaldello Date: Fri, 17 Apr 2026 09:21:15 +0200 Subject: [PATCH] fix(metrics): add nil checks for Metrics methods to prevent panics --- pkg/telemetry/metrics.go | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/pkg/telemetry/metrics.go b/pkg/telemetry/metrics.go index e9af16c..9619fba 100644 --- a/pkg/telemetry/metrics.go +++ b/pkg/telemetry/metrics.go @@ -102,7 +102,7 @@ func Setup(ctx context.Context, log logging.Logger, cfg Config) (*Metrics, func( } res, err := resource.Merge(resource.Default(), - resource.NewSchemaless(attribute.String("service.name", serviceName))) + resource.NewSchemaless()) if err != nil { return nil, nil, err } @@ -324,14 +324,23 @@ func (m *Metrics) IncReconcileFailure(ctx context.Context) { } func (m *Metrics) IncReconcileRequeueAfter(ctx context.Context) { + if m == nil { + return + } m.recordRequeue(ctx, "after", m.reconcileRequeueAfter) } func (m *Metrics) IncReconcileRequeueImmediate(ctx context.Context) { + if m == nil { + return + } m.recordRequeue(ctx, "immediate", m.reconcileRequeueImmediate) } func (m *Metrics) IncReconcileErrorRequeue(ctx context.Context) { + if m == nil { + return + } m.recordRequeue(ctx, "error", m.reconcileErrorRequeue) }