`keygen upload` sporadically fails

[ryansteil]

Somewhat randomly, keygen upload fails. I'm running in a github action, which usually succeeds, but will sporadically fail.

keygen upload ... \
    --signature $SIGNATURE \
    --filename $FILENAME \
    --release $VERSION \
    --platform $PLATFORM \
    --arch $ARCH

error: Put "https://keygen-dist....": write tcp 192.168.64.5:49362->162.159.141.50:443: write: broken pipe

Could there be retry logic here or should I just implement this within the action?

[ezekg]

You're not the only one. I've experienced the same, as have other users. It's rare, but it happens, and more often with large files or on slow connections. Adding better retry logic to the CLI would be beneficial since this seems to be a failure on Cloudflare R2's end, and it seems to be a known issue.

How large are the files you're uploading?

[ryansteil]

Gotcha - my files are ~30MB.

[ezekg]

Okay, so pretty small. Likely due to connection issues in Actions, or a transient issue on R2's end. Regardless, retries for artifact uploads to the storage provider can probably be implemented pretty painlessly with https://github.com/hashicorp/go-retryablehttp. Open to a PR?

[ryansteil]

Yup, I'll take a stab at it in the next couple of days.

[ezekg]

Does this happen more often on certain Action runners than others? e.g. on a macOS runner.

[ryansteil]

I'm not sure, I have this running on both a macOS and Windows runner. It's only happened to me a few times in total - I think on both, but for sure on macOS.

[ezekg]

Thanks for the info. Recently had a couple other reports of upload failures on the macOS runner, so wanted to check.

Hopefully the retry logic will work around it. Will reach out to the GitHub team, regardless.

[ezekg]

Could be related? actions/upload-artifact#527 actions/upload-artifact#623 actions/upload-artifact#569