2024280385王继熠#8
Open
Wjaywhy wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
该 PR 主要完成了实验平台中 BPSK/QPSK/16‑QAM 的调制实现,并补全了(选做)解调函数;同时更新了教师指南与报告模板内容。
Changes:
- 在
src/modulation.py实现 BPSK/QPSK/16‑QAM 调制(含输入合法性校验与归一化) - 在
src/demodulation.py实现 BPSK/QPSK/16‑QAM 解调(最近点/阈值判决) - 更新
TEACHER_GUIDE.md的排版;将实验报告内容写入REPORT_TEMPLATE.md
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/modulation.py | 实现三种调制映射、归一化与输入校验,满足自动评分测试点 |
| src/demodulation.py | 补全三种解调算法,支持性能测试链路(选做) |
| TEACHER_GUIDE.md | 文档排版调整(表格/空行等) |
| REPORT_TEMPLATE.md | 报告模板被替换为具体个人报告内容(会影响评分脚本识别) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+7
| # 实验报告 | ||
|
|
||
| **实验名称**:数字调制解调实验 | ||
| **学生姓名**:[你的姓名] | ||
| **学号**:[你的学号] | ||
| **实验日期**:2026年4月24日 | ||
| **提交日期**:[提交日期] | ||
| **实验名称**:数字调制解调实验 | ||
| **学生姓名**:王继熠 | ||
| **学号**:2024280385 | ||
| **实验日期**:2026年4月23日 | ||
| **提交日期**:2026年4月23日 |
There was a problem hiding this comment.
当前仓库的自动评分脚本只会检查是否存在并评分 REPORT.md(见 grading/check_report.py 的文件名列表)。本PR把实验报告内容写进了 REPORT_TEMPLATE.md,但如果没有新增 REPORT.md,报告项会被判定为“未找到实验报告文件”。建议将该内容移到新建的 REPORT.md(或按要求的文件名),并把 REPORT_TEMPLATE.md 恢复为通用模板。
| - 勾选 `Template repository`(作为模板) | ||
|
|
||
| 2. 将本地文件推送到远程仓库: | ||
| 1. 将本地文件推送到远程仓库: |
There was a problem hiding this comment.
这里的有序列表出现了两个连续的“1.”(第1步“创建仓库”后紧跟“将本地文件推送到远程仓库”仍标为1),容易让读者误解步骤顺序。建议将第二条改为“2.”,或保持 Markdown 自动编号但在文字中明确步骤序号。
Suggested change
| 1. 将本地文件推送到远程仓库: | |
| 2. 将本地文件推送到远程仓库: |
|
cool |
🤖 自动评分结果提交者: @Wjaywhy 📊 详细测试结果点击查看BPSK测试详情点击查看QPSK测试详情点击查看16-QAM测试详情点击查看报告检查详情💡 提示:
⏰ 评分时间: 2026/4/30 19:23:12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
我完成了任务1(BPSK调制)
我完成了任务2(QPSK调制)
我完成了任务3(16-QAM调制)
我生成了BPSK、QPSK和16-QAM星座图
我完成了调制功能的基本测试,结果符合预期