From fcf473b8e6a4d5a18a14eddd9738cfed5b2ecbe4 Mon Sep 17 00:00:00 2001 From: Jonathan Pool Date: Sat, 3 Oct 2026 15:38:03 -0700 Subject: [PATCH 1/3] add violation counts to reports list --- package.json | 2 +- web/listReports/index.ts | 20 +++++++++++--------- web/util.ts | 4 ++++ 3 files changed, 16 insertions(+), 10 deletions(-) diff --git a/package.json b/package.json index 4207c2f9..9899e866 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@jrpool/kilotest", - "version": "57.2.3", + "version": "57.3.0", "description": "Ensemble testing for front-end web quality", "type": "module", "main": "index.ts", diff --git a/web/listReports/index.ts b/web/listReports/index.ts index 6cf9a604..6838940a 100644 --- a/web/listReports/index.ts +++ b/web/listReports/index.ts @@ -119,6 +119,7 @@ const populateQuery = async (query: Record) => { preventedEngineNames, reporterNames, reporterCount, + violationCount, violatorCount } = reportData; // Otherwise, i.e. if it succeeded, add lines about the report. @@ -147,20 +148,21 @@ const populateQuery = async (query: Record) => { const reporterNamesString = reporterNames.join(' + '); reporterString = `${reporterString} (${reporterNamesString})`; } - const issueCountString = getCountString(issueCount, 'issue was', 'issues were'); - const violatorString = getCountString(violatorCount, 'violator was', 'violators were'); lines.tested.push(`${margin}
  • ${reporterString}
    • `); - lines.tested.push(`${margin}
  • ${issueCountString} reported
    • `); - lines.tested.push(`${margin}
  • ${violatorString} reported
    • `); - lines.tested.push(`${margin} `); + lines.tested.push(`${margin}
  • Summary of results:`); + lines.tested.push(`${margin}
      `); + lines.tested.push(`${margin}
    • Violations: ${violationCount}
      • `); + lines.tested.push(`${margin}
    • Violators: ${violatorCount}
      • `); + lines.tested.push(`${margin}
    • Issues: ${issueCount}
      • `); + lines.tested.push(`${margin}
    `); + lines.tested.push(`${margin}
    • `); lines.tested.push(`${margin}
      `); // If any issues were reported: if (issueCount) { - // Add a question link about the reported issues to the lines. + // Add a link to issue details to the lines. const href = `href="listIssues.html/${timeStamp}/${jobID}"`; - const label = `aria-label="What ${issueCountString} reported for the ${description} page?"`; - const questionString = issueCount === 1 ? 'was the issue' : 'were the issues'; - const link = `What ${questionString}?`; + const label = `aria-label="issue details for the ${description} page"`; + const link = `Issue details`; lines.tested.push(`${margin}
    • ${link}
      • `); } let retestString: string = ''; diff --git a/web/util.ts b/web/util.ts index 7529a1b4..71d6de84 100644 --- a/web/util.ts +++ b/web/util.ts @@ -54,6 +54,7 @@ export type ReportData = { engineCount: number; reporterNames: string[]; reporterCount: number; + violationCount: number; violatorCount: number; preventedEngineNames: string[]; preventedEngineCount: number; @@ -160,6 +161,7 @@ export const getReportData = async (timeStamp: string, jobID: string): Promise Date: Sat, 3 Oct 2026 15:44:49 -0700 Subject: [PATCH 2/3] debug --- web/listReports/index.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/web/listReports/index.ts b/web/listReports/index.ts index 6838940a..6aad1d8d 100644 --- a/web/listReports/index.ts +++ b/web/listReports/index.ts @@ -156,6 +156,7 @@ const populateQuery = async (query: Record) => { lines.tested.push(`${margin}
    • Issues: ${issueCount}
      • `); lines.tested.push(`${margin}
    `); lines.tested.push(`${margin} `); + lines.tested.push(`${margin} `); lines.tested.push(`${margin}
      `); // If any issues were reported: if (issueCount) { From 196f8e4ae1ecb3ed92db40b0d11fe974915b788e Mon Sep 17 00:00:00 2001 From: Jonathan Pool Date: Sat, 3 Oct 2026 15:56:23 -0700 Subject: [PATCH 3/3] add missing tests --- web/listReports/listReports.test.ts | 73 +++++++++++++++++++++++++++++ 1 file changed, 73 insertions(+) diff --git a/web/listReports/listReports.test.ts b/web/listReports/listReports.test.ts index 2e78c177..433d4e67 100644 --- a/web/listReports/listReports.test.ts +++ b/web/listReports/listReports.test.ts @@ -216,3 +216,76 @@ test('listReports shows no-reports message when the database is empty', async () await fs.rm(tmpDir, {recursive: true}).catch(() => {}); } }); + +// Returns the details element of the report whose summary starts with a description and whose issue link, if required, contains a fragment. +const getReportDetails = (html: any, description: string, hrefFragment?: string) => { + const matches = html.querySelectorAll('details').filter((d: any) => { + const summary = d.querySelector('summary')?.text ?? ''; + if (!summary.startsWith(description)) { + return false; + } + return hrefFragment === undefined + || d.querySelectorAll('a').some((a: any) => a.getAttribute('href')?.includes(hrefFragment)); + }); + assert.equal(matches.length, 1, `exactly one report matches ${description} ${hrefFragment ?? ''}`); + return matches[0]; +}; + +// Returns the rule-engine line, the prevention line, and the 3 summary amounts of a details element. +const getResultFacts = (details: any) => { + const items = details.querySelectorAll('li'); + const itemTexts: string[] = items.map((li: any) => li.text.trim()); + const getAmount = (label: string) => { + const text = itemTexts.find(t => t.startsWith(`${label}: `)); + assert.ok(text, `${label} item exists`); + return Number(text.slice(label.length + 2)); + }; + // The summary item is the parent of the 3 amount items. + const summaryItem = items.find((li: any) => li.text.trim().startsWith('Summary of results:')); + assert.ok(summaryItem, 'Summary of results item exists'); + const amountLabels = summaryItem.querySelectorAll('ul > li').map((li: any) => li.text.trim().split(':')[0]); + return { + reporterLine: itemTexts.find(t => t.endsWith('reported issues') || t.includes('reported issues (')), + preventionLine: itemTexts.find(t => t.startsWith('Page not testable by')), + amountLabels, + violations: getAmount('Violations'), + violators: getAmount('Violators'), + issues: getAmount('Issues') + }; +}; + +// Expected facts, hand-computed from the fixtures. +const expectedFacts: [string, string | undefined, string, number, number, number][] = [ + // Description, issue-link fragment, reporter line, violations, violators, issues. + ['Mixed Outcomes Page', '260101T0000/mix', '2 rule engines reported issues (Alfa + Axe)', 3, 2, 2], + ['Mixed Outcomes Page', '260202T0000/new', '1 rule engine reported issues (Axe)', 1, 1, 1], + ['All CantTell Page', undefined, '0 rule engines reported issues', 0, 0, 0], + ['No Outcomes Page', undefined, '1 rule engine reported issues (Accessibility Checker)', 1, 1, 1], + ['Empty Results Page', undefined, '0 rule engines reported issues', 0, 0, 0], + ['Prevented Page', undefined, '1 rule engine reported issues (Axe)', 1, 1, 1], + ['Multi Violator Page', undefined, '2 rule engines reported issues (Alfa + Axe)', 4, 3, 1], + ['Branch Coverage Page', undefined, '1 rule engine reported issues (Axe)', 4, 4, 1] +]; + +for (const [description, fragment, reporterLine, violations, violators, issues] of expectedFacts) { + test(`listReports gives correct rule-engine count and names and summary amounts for ${description}${fragment ? ` (${fragment})` : ''}`, async () => { + const result: any = await answer(); + const html = parse(result.answerPage); + const facts = getResultFacts(getReportDetails(html, description, fragment)); + assert.equal(facts.reporterLine, reporterLine); + assert.deepEqual(facts.amountLabels, ['Violations', 'Violators', 'Issues']); + assert.equal(facts.violations, violations); + assert.equal(facts.violators, violators); + assert.equal(facts.issues, issues); + }); +} + +test('listReports reports the prevented rule engine only for the report with a prevention', async () => { + const result: any = await answer(); + const html = parse(result.answerPage); + const prevented = getResultFacts(getReportDetails(html, 'Prevented Page')); + assert.equal(prevented.preventionLine, 'Page not testable by 1 rule engine (Alfa)'); + const others = html.querySelectorAll('details').filter((d: any) => !d.text.includes('Prevented Page')); + assert.equal(others.length, 7); + assert.ok(others.every((d: any) => !d.text.includes('Page not testable by'))); +});