Skip to content

Commit 0effb95

Browse files
committed
test: clarify helpful nullpointer assertion
1 parent 3db1e01 commit 0effb95

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

src/test/java/net/jrodolfo/java_evolution/java14/HelpfulNullPointerExceptionExamplesTest.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package net.jrodolfo.java_evolution.java14;
22

3-
import static org.assertj.core.api.Assertions.assertThatThrownBy;
3+
import static org.assertj.core.api.Assertions.assertThat;
4+
import static org.assertj.core.api.Assertions.catchThrowable;
45
import static org.junit.jupiter.api.Assumptions.assumeTrue;
56

67
import org.junit.jupiter.api.Test;
@@ -11,14 +12,12 @@ class HelpfulNullPointerExceptionExamplesTest {
1112

1213
@Test
1314
void nullPointerExceptionMessageIdentifiesTheNullPartOfTheChain() {
14-
Throwable failure = org.assertj.core.api.Assertions.catchThrowable(examples::triggerHelpfulNullPointerException);
15+
Throwable failure = catchThrowable(examples::triggerHelpfulNullPointerException);
1516

1617
// Helpful NPE details can be disabled with -XX:-ShowCodeDetailsInExceptionMessages.
1718
assumeTrue(failure.getMessage() != null, "helpful NullPointerException details are disabled in this JVM");
1819

19-
assertThatThrownBy(() -> {
20-
throw failure;
21-
})
20+
assertThat(failure)
2221
.as("Java 14 helpful NullPointerException messages should identify the null expression")
2322
.isInstanceOf(NullPointerException.class)
2423
.hasMessageContaining("address()");

0 commit comments

Comments
 (0)