From d0ad1d01690092bf34597b3619a5d0d6cf37076e Mon Sep 17 00:00:00 2001 From: Jordan Simonovski Date: Sat, 14 Nov 2026 20:55:02 +1100 Subject: [PATCH] fix: release-check passes when no changesets are pending Changesets v3's changeset version exits 1 with 'No unreleased changesets found', so the dry-run failed on every pull request without a changeset. Skip the dry-run when there is nothing to release. --- .github/workflows/release-check.yml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/release-check.yml b/.github/workflows/release-check.yml index 22391ee..a999708 100644 --- a/.github/workflows/release-check.yml +++ b/.github/workflows/release-check.yml @@ -27,12 +27,17 @@ jobs: - name: Dry-run npm run release run: | pending=$(ls .changeset/*.md | grep -vc '/README\.md$' || true) + # Nothing to release: changeset version exits 1 ("No unreleased changesets found"). + if [ "$pending" -eq 0 ]; then + echo "No pending changesets; nothing to dry-run." + exit 0 + fi before=$(node -p "require('./package.json').version") npm run release after=$(node -p "require('./package.json').version") left=$(ls .changeset/*.md | grep -vc '/README\.md$' || true) echo "pending changesets: $pending, version: $before -> $after, left: $left" - if [ "$pending" -gt 0 ] && { [ "$before" = "$after" ] || [ "$left" -ne 0 ]; }; then + if [ "$before" = "$after" ] || [ "$left" -ne 0 ]; then echo "::error::npm run release did not consume the pending changesets; the release PR would be empty." exit 1 fi