Skip to content

Improve ContinuedFractions#realToCF() method #1

@axkr

Description

@axkr

The limit is 1 to high:

diff --git a/src/main/java/arithmetic/ContinuedFractions.java b/src/main/java/arithmetic/ContinuedFractions.java
index 07d67bf..77c65b8 100644
--- a/src/main/java/arithmetic/ContinuedFractions.java
+++ b/src/main/java/arithmetic/ContinuedFractions.java
@@ -70,10 +70,13 @@
         double tNext;
         int aNext;
         as.add(aNow);
-        for(int i = 0; i < limit; i++){
+        for(int i = 0; i < limit-1; i++){
             double rec = 1.0 / tNow;
             aNext = (int)rec;
             tNext = rec - aNext;
+            if (aNext==Integer.MAX_VALUE)  {
+				break;
+			}
             as.add(aNext);
             tNow = tNext;
         }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions