diff --git a/ircapp/core/managers/extraction.py b/ircapp/core/managers/extraction.py index 3eeb0f2..b9bea1d 100755 --- a/ircapp/core/managers/extraction.py +++ b/ircapp/core/managers/extraction.py @@ -50,7 +50,26 @@ def extract(self, irc_app_connection): try: # Unpack the rar blocks from the tar file with tarfile.open(_file) as f: - f.extractall(temp_path) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(f, temp_path) os.remove(_file) # Extract rar files unpacked from the original tar files x = 0