[Request] Hide menu-bar?

[secastles]

Is it possible to add a config option to hide the div id menu-bar? I'm not sure if it's possible to go into the iframe and alter contents or not but I thought I would ask. something like: iframe.contents().find('#menu-bar').hide()

I tried that in the code but it didn't work and I'm not smart...

[jojoduquartier]

@tisnatch You actually are very smart. I tried everything to hide that menu too. It's nearly impossible to directly mess with the frame content due to cross site preventions but I am not so good at Javascript so I can't find a work around. Hopefully someone can figure it out and commit the changes. Until then I will probably keep trying

[secastles]

Thanks for looking into this. Yeah, you're probably right about the XSS issue. Might just not be possible.

[secastles]

Hmm... I wonder if it's possible to do it like this:
(1) first load the rainviewer page into a variable
(2) manipulate the HTML in the variable (i.e. strip out the header div)
(3) load the result into the iframe

[jojoduquartier]

That actually sounds interesting. I guess I should give it a try

[jojoduquartier]

I really don't this will work unless someone with real javascript experience works on it.

Uncaught DOMException: Blocked a frame with origin "http://localhost:8080" from accessing a cross-origin frame. 
at HTMLIFrameElement.iframe.onload (http://localhost:8080/modules/MMM-RAIN-RADAR//MMM-RAIN-RADAR.js:58:36)

[secastles]

Eh, looks like the same XSS issue. Depending on how far you want to pursue this I had a thought: I wonder if the content is complete once it's pulled into the local variable. Meaning: If you stripped out all calls to an external site (e.g. rainviewer) would the radar loop still work? That might prevent the XSS error. Alternatively, could you wrap the entire content of the variable in a try/catch block and just ignore the errors?

[jojoduquartier]

I was just testing different things. For example this actually logs the frame but no contentWindow document. This is what is causing the error. So technically this function is only called when the frame is fully loaded.

iframe.onload = function () {
			var frame = document.evaluate('//*[@id="mmrainviewerframe"]', document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue;
			console.log("Rain Radar Modifier");
			console.log(frame.contentWindow.document);
		};

[secastles]

Doing a little research here using my limited understanding of CORS:

electron/electron#384

electron/electron#1990

https://stackoverflow.com/questions/51254618/how-to-handle-cors-in-an-electron-app

https://cors-anywhere.herokuapp.com/

and if you really can't sleep at night: https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS

Sorry, just spitballing here.