From c961f078129407803cde400b1483594b55e9314e Mon Sep 17 00:00:00 2001
From: Carl Schwan <carl@carlschwan.eu>
Date: Tue, 4 Aug 2026 11:12:01 +0200
Subject: [PATCH] perf: use getUserGroupIds

Several time faster than getUserGroups as we don't have to load group
objects.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
---
 lib/AutoGroupsManager.php            |  2 +-
 tests/Unit/AutoGroupsManagerTest.php | 14 +++++++-------
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/lib/AutoGroupsManager.php b/lib/AutoGroupsManager.php
index 9bbd2f0..cb0fabc 100644
--- a/lib/AutoGroupsManager.php
+++ b/lib/AutoGroupsManager.php
@@ -100,7 +100,7 @@ public function addAndRemoveAutoGroups($event)
 
         // Get user information
         $user = $event->getUser();
-        $userGroupNames = array_keys($this->groupManager->getUserGroups($user));
+        $userGroupNames = $this->groupManager->getUserGroupIds($user);
 
         // Notice message for Auto Group Hook Execution
         $this->logger->debug('AutoGroups hook triggered for user ' . $user->getDisplayName());
diff --git a/tests/Unit/AutoGroupsManagerTest.php b/tests/Unit/AutoGroupsManagerTest.php
index 4c38da4..0ee1378 100644
--- a/tests/Unit/AutoGroupsManagerTest.php
+++ b/tests/Unit/AutoGroupsManagerTest.php
@@ -114,7 +114,7 @@ public function testAddingToAutoGroups()
 
         // User belongs to no groups, so they should be added to the auto group
         $this->groupManager->expects($this->once())
-            ->method('getUserGroups')
+            ->method('getUserGroupIds')
             ->with($this->testUser)
             ->willReturn([]);
 
@@ -141,9 +141,9 @@ public function testAddingNotRequired()
 
         // User is already in the auto group, so addUser should never be called
         $this->groupManager->expects($this->once())
-            ->method('getUserGroups')
+            ->method('getUserGroupIds')
             ->with($this->testUser)
-            ->willReturn(['autogroup' => []]);
+            ->willReturn(['autogroup']);
 
         $autogroup = $this->createMock(IGroup::class);
         $autogroup->expects($this->once())->method('getGID')->willReturn('autogroup');
@@ -168,9 +168,9 @@ public function testRemoveUserFromAutoGroups()
 
         // User belongs to an override group, so they should be removed from all auto groups
         $this->groupManager->expects($this->once())
-            ->method('getUserGroups')
+            ->method('getUserGroupIds')
             ->with($this->testUser)
-            ->willReturn(['autogroup1' => [], 'overridegroup1' => [], 'autogroup2' => []]);
+            ->willReturn(['autogroup1', 'overridegroup1', 'autogroup2']);
 
         $groupMock = $this->createMock(IGroup::class);
         $groupMock->expects($this->exactly(2))->method('getGID')->willReturnOnConsecutiveCalls('autogroup1', 'autogroup2');
@@ -195,9 +195,9 @@ public function testRemoveNotRequired()
 
         // User is in an override group but not in any auto group, so removeUser should never be called
         $this->groupManager->expects($this->once())
-            ->method('getUserGroups')
+            ->method('getUserGroupIds')
             ->with($this->testUser)
-            ->willReturn(['overridegroup1' => []]);
+            ->willReturn(['overridegroup1']);
 
         $groupMock = $this->createMock(IGroup::class);
         $groupMock->expects($this->exactly(2))->method('getGID')->willReturnOnConsecutiveCalls('autogroup1', 'autogroup2');