in `ramfs_vector.c` redundant '/' skipping

[steverpalmer]

The function ramfs_get_parent near the top skips leading '/' characters (around line 174 of ramfs_vector.c).

ramfs_get_parent is called from:

• ramfs_get_entry
• ramfs_create
• ramfs_rename (twice)
• ramfs_mkdir

In each call, the pathname is pre-processed to skip leading '/' characters. The only effect of this is the loss of a few clock cycles, but perhaps the code would be simpler if the functionality was kept in ramfs_get_parent and removed elsewhere.

[steverpalmer]

Mea culpa| I've just realised that the pre-processed path name is reused in other parts of the calling functions above. If this is the case, perhaps the reverse of my suggestion is the right way? That is, keep the pre-processing in each of the callers, and perhaps add an assert to ramfs_get_parent that the passed pathname has no leading '/' characters.

[steverpalmer]

The ramfs_rename is curious since it starts with an optimization(?) that if it is trying to rename a file to the same name, then it returns immediately having done nothing. It then skips '/' characters on the src and dst names ad starts processing. So ramfs_rename(fs, "/fred.txt", "//fred.txt") works harder than ramfs_rename(fs, "/fred.txt", "/fred.txt"), but does the same thing. Perhaps the optimization could come after the '/' skipping?

[jkent]

I vaguely remember there being some issues Espressif IDF VFS mounts and leading slashes. I will learn how to use unity with the IDF framework before making any changes.

Kind regards,
Jeff