Skip to content

【Discuss and Proposal】Some variable name may be better understand if minor changes #4

@wnz27

Description

@wnz27

1

parallel_change1
first, I think the fanout func is send executor to out for async run, the executor run logic real in outer ,
so I think the func addIn name may not be suitable, so may be addOut more better understand.
unless u use executor.addIn something like this to call this func, but i think this func return <-chan interface{},
if use executor.addIn may should not to return something. so this func i think use add or addExecutor or addOut, may be addOut better, because the func's param is executor, when call is very easy readble.

2

parallel_change2
second, this func out actually it is receive result from out , so addToOut actuall it is receive value from out chan ,
so I think inner fanin func addToOut may be receiveFrom better to understand.

Proposal

  • I want to add some benchmark for project.
  • by the way if u dont mind i change this func name for project.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions