-
Notifications
You must be signed in to change notification settings - Fork 2
Closed
Description
Problem
Several themes define their own custom CSS color variables and use them internally, rather than using the standard rokkit palette tokens (surface-z*, primary-z*, secondary-z*, danger-z*, etc.).
Known offenders:
- grada-ui:
--gd-primary,--gd-secondary,--gd-gradient,--gd-grey-a,--gd-grey-b,--gd-grey-c,--gd-success,--gd-error-border,--gd-error-text,--gd-dark,--gd-surface-a,--gd-surface-b,--gd-surface-c - material:
--material-*(removed) — verify none remain - Potentially others (ant-design, carbon, etc.)
input.css, button.css, switch.css, and card.css in grada-ui are already migrated. Remaining files with ~80+ usages:
toolbar.css,floating-navigation.css,list.css,select.css,tabs.css,toggle.css,table.css,search-filter.css,range.css,timeline.css,toc.css,message.css,status-list.css,tree.css,menu.css,dropdown.css,floating-action.css
Rule
No theme may define or use its own --custom-* CSS color variables. All colors must come from:
@apply surface-z*,primary-z*,secondary-z*,danger-z*,success-z*tokens- Explicit
rgba(var(--color-primary-500), 1)etc. for gradients
Gradient exception
The Rokkit color system does not have a built-in primary → secondary gradient utility. For themes like grada-ui that rely on this gradient, use explicit CSS:
background-image: linear-gradient(to right, rgba(var(--color-primary-500), 1), rgba(var(--color-secondary-500), 1));
background-color: transparent;Acceptance Criteria
- Zero occurrences of
var(--gd-*),var(--material-*), or any other theme-specific custom color variable inpackages/themes/src/**/*.css - All replaced with
@applypalette utilities or explicitrgba(var(--color-*), ...)syntax - Build passes, lint passes
- Themes comparison page renders all 10 themes correctly
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels