From cba01650b7948988adf7d66975c41d13b7e8cb30 Mon Sep 17 00:00:00 2001 From: Meet Goti Date: Sun, 15 Mar 2026 22:18:36 +0530 Subject: [PATCH 1/3] Remove dead getOldGitExe() code and empty onLoaded() block --- src/main/java/hudson/plugins/git/GitSCM.java | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/src/main/java/hudson/plugins/git/GitSCM.java b/src/main/java/hudson/plugins/git/GitSCM.java index 9b609fcbfd..907b33ebb8 100644 --- a/src/main/java/hudson/plugins/git/GitSCM.java +++ b/src/main/java/hudson/plugins/git/GitSCM.java @@ -1810,15 +1810,6 @@ public void setAllowSecondFetch(boolean allowSecondFetch) { public void setAddGitTagAction(boolean addGitTagAction) { this.addGitTagAction = addGitTagAction; } - /** - * Old configuration of git executable - exposed so that we can - * migrate this setting to GitTool without deprecation warnings. - * @return git executable - */ - public String getOldGitExe() { - return null; - } - public static List createRepositoryConfigurations(String[] urls, String[] repoNames, String[] refs) throws GitException, IOException { @@ -2168,17 +2159,6 @@ public boolean getDoGenerateSubmoduleConfigurations() { @Initializer(after=PLUGINS_STARTED) public static void onLoaded() { - Jenkins jenkins = Jenkins.get(); - DescriptorImpl desc = jenkins.getDescriptorByType(DescriptorImpl.class); - - if (desc.getOldGitExe() != null) { - String exe = desc.getOldGitExe(); - String defaultGit = GitTool.getDefaultInstallation().getGitExe(); - if (exe.equals(defaultGit)) { - return; - } - System.err.println("[WARNING] you're using deprecated gitexe attribute to configure git plugin. Use Git installations"); - } } @Initializer(before=JOB_LOADED) From 2324d89619d2f67bcf6317ad17e70407b25ecf18 Mon Sep 17 00:00:00 2001 From: Meet Goti Date: Mon, 16 Mar 2026 22:30:27 +0530 Subject: [PATCH 2/3] remove onLoaded method --- src/main/java/hudson/plugins/git/GitSCM.java | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/main/java/hudson/plugins/git/GitSCM.java b/src/main/java/hudson/plugins/git/GitSCM.java index 907b33ebb8..8d46846202 100644 --- a/src/main/java/hudson/plugins/git/GitSCM.java +++ b/src/main/java/hudson/plugins/git/GitSCM.java @@ -2157,10 +2157,6 @@ public boolean getDoGenerateSubmoduleConfigurations() { return doGenerateSubmoduleConfigurations; } - @Initializer(after=PLUGINS_STARTED) - public static void onLoaded() { - } - @Initializer(before=JOB_LOADED) public static void configureXtream() { Run.XSTREAM.registerConverter(new ObjectIdConverter()); From cd2c37ef22206e06d7450e73448e09068855dfbd Mon Sep 17 00:00:00 2001 From: Mark Waite Date: Sat, 21 Mar 2026 06:33:37 -0600 Subject: [PATCH 3/3] Deprecate method instead of deleting it Preserve API compatibility for consumers. Low risk to delete it, but it is simpler for maintainers if we retain the method rather than answer later questions about its removal. --- src/main/java/hudson/plugins/git/GitSCM.java | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/main/java/hudson/plugins/git/GitSCM.java b/src/main/java/hudson/plugins/git/GitSCM.java index 8d46846202..430e065702 100644 --- a/src/main/java/hudson/plugins/git/GitSCM.java +++ b/src/main/java/hudson/plugins/git/GitSCM.java @@ -1810,6 +1810,17 @@ public void setAllowSecondFetch(boolean allowSecondFetch) { public void setAddGitTagAction(boolean addGitTagAction) { this.addGitTagAction = addGitTagAction; } + /** + * Old configuration of git executable, unused since 2023. + * Returns null in all cases. + * @deprecated use GitTool + * @return null + */ + @Deprecated(since = "5.11.0") + public String getOldGitExe() { + return null; + } + public static List createRepositoryConfigurations(String[] urls, String[] repoNames, String[] refs) throws GitException, IOException {