feat: implement instance readiness gate for HTTP service.#58
Conversation
JimHsiung
requested review from
DongheJin,
RobbieLeung,
XuZhang99,
magicheng0816,
weizhehuang0827 and
yq33victor
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a readiness check mechanism for the HTTP server, ensuring it only runs when valid instance groups are available. It adds a new readiness thread in the Master class, a configuration flag for the check interval, and helper methods in the InstanceMgr and Scheduler classes to verify instance availability. The review identified two areas for improvement: the sleep loop in the readiness thread should use std::chrono for better robustness and readability, and the duplicated validation logic for prefill instances in InstanceMgr should be refactored into a private helper function.
JimHsiung
force-pushed
the
feat/instance-readiness-gate
branch
from
9bf4050 to
5a432a3
Compare
|
/gemini review |
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
|
/gemini review |
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
3 participants
No description provided.