feat: support namespace prefix for etcd key.

[JimHsiung]

No description provided.

[gemini-code-assist]

Code Review

This pull request introduces support for an optional etcd namespace prefix to isolate keys within the xllm-service. It adds configuration flags, utility functions for normalization, and updates various managers (InstanceMgr, GlobalKVCacheMgr, Scheduler) to apply the namespace to their respective etcd keys. Feedback highlights concerns regarding the leaky abstraction in EtcdClient where namespacing isn't handled transparently for all operations, the duplication of key-building logic across multiple components, and the use of hardcoded shared keys instead of centralized constants.

[JimHsiung]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces support for etcd namespaces across the xllm_service components. It adds a new configuration flag etcd_namespace, utility functions for normalizing and building namespaced keys, and updates the EtcdClient, GlobalKVCacheMgr, InstanceMgr, and Scheduler to ensure all etcd keys are correctly prefixed. I have no feedback to provide.

[gemini-code-assist]

Code Review

This pull request introduces etcd namespacing support for the xllm_service, allowing all etcd keys to be prefixed with a configurable namespace. The changes include a new etcd_namespace flag, utility functions for namespace normalization and key construction, and updates to EtcdClient to ensure all operations use namespaced keys. The review feedback identifies several performance optimization opportunities within EtcdClient where namespaced key calculations are performed redundantly inside loops and should be moved outside to improve efficiency.

[JimHsiung]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces support for etcd namespaces within the xllm-service. It adds a new configuration flag, utility functions for key normalization, and updates the EtcdClient to automatically prefix keys with the provided namespace. A critical issue was identified in the batch set implementation of EtcdClient, where the function ignores the accumulated success status and always returns true, preventing callers from detecting failures.

[JimHsiung]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces support for etcd namespaces within the xllm_service. It adds a new etcd_namespace configuration flag, provides utility functions for namespace normalization and key construction, and updates the EtcdClient to automatically prepend the namespace prefix to all etcd keys. A critical issue was identified in the template set function for unordered_map in etcd_client.h, which calculates an operation success status but fails to return it, potentially leading to silent failures.

[JimHsiung]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces support for an optional etcd namespace prefix, allowing keys to be scoped (e.g., for different environments like 'prod-a'). Changes include adding the etcd_namespace flag, implementing utility functions for path normalization and key construction, and updating EtcdClient to wrap all operations with the namespace prefix. Additionally, a bug was fixed in the EtcdClient::set methods to correctly return the cumulative success status of batch operations. I have no further feedback to provide.

[yq33victor]

LGTM