From d23b64c868ff080cd2dd401e72fc4bb1d2c1302a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lu=C3=ADs=20N=C3=B3brega?= Date: Wed, 15 Feb 2017 23:27:55 +0000 Subject: [PATCH 1/2] WIP: Update toggle to also call callback on click --- src/readmore.js | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/src/readmore.js b/src/readmore.js index c51e692..092a71b 100644 --- a/src/readmore.js +++ b/src/readmore.js @@ -17,7 +17,8 @@ function readMore($templateCache) { hmMoreText: '@', hmLessText: '@', hmDotsClass: '@', - hmLinkClass: '@' + hmLinkClass: '@', + hmOnClickCallback: '&' }, template: $templateCache.get('readmore.template.html'), controller: hmReadMoreController, @@ -34,7 +35,8 @@ function readMore($templateCache) { vm.toggle = { dots: '...', dotsClass: vm.hmDotsClass, - linkClass: vm.hmLinkClass + linkClass: vm.hmLinkClass, + onClickCallback: vm.hmOnClickCallback } // Toggle functions @@ -58,13 +60,24 @@ function readMore($templateCache) { vm.toggle.show = vm.moreText && vm.moreText.length > 0; } - vm.doToggle = function () { + function doToggle() { $log.debug('doToggle'); vm.toggle.state = !vm.toggle.state; vm.showMoreText = !vm.showMoreText; setCurrentToggleText(); } + function callOnClickCb() { + $log.debug('callOnClickCb'); + vm.hmOnClickCallback(); + } + + vm.onClick = function () { + $log.debug('onClick'); + doToggle(); + callOnClickCb(); + } + $scope.$watch('vm.hmMoreText', function (newValue, oldValue) { if (newValue != oldValue) { $log.debug('hmMoreText changed'); @@ -111,7 +124,7 @@ function readMore($templateCache) { function setLessAndMoreText() { $log.debug('setLessAndMoreText'); vm.lessText = $filter('limitTo')(vm.hmText, vm.hmLimit); - vm.moreText = $filter('limitTo')(vm.hmText, getMoreTextLimit()); + vm.moreText = $filter('limitTo')(vm.hmText, getMoreTextLimit()); } function initialize() { From 18cb04b84854853a7d9907dcbb420abecd812f95 Mon Sep 17 00:00:00 2001 From: Luis Nobrega Date: Wed, 15 Feb 2017 23:39:05 +0000 Subject: [PATCH 2/2] Add on click callback to element --- src/readmore.template.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/readmore.template.html b/src/readmore.template.html index 91ebd52..67411f1 100644 --- a/src/readmore.template.html +++ b/src/readmore.template.html @@ -5,5 +5,5 @@ {{ vm.toggle.dots }} - {{ vm.toggle.text }} + {{ vm.toggle.text }}