From cc3cc6f5f03148aee57a15ab453d22149c6a39c0 Mon Sep 17 00:00:00 2001 From: Pavel Fedotov Date: Fri, 20 Jun 2025 04:40:22 +0200 Subject: [PATCH 1/5] fixing link in readme --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index dd250c1e7..972b7d22c 100644 --- a/README.md +++ b/README.md @@ -79,7 +79,7 @@ It bundles config for standard tools such as eslint, mocha, etc and lets you con } ``` - You can find the complete default config [here](https://github.com/ipfs/aegir/blob/main/src/config/user.js#L12) and the types [here](https://github.com/ipfs/aegir/blob/main/src/types.d.ts). + You can find the complete default config [here](https://github.com/ipfs/aegir/blob/main/src/config/user.js#L12) and the types [here](https://github.com/ipfs/aegir/blob/main/src/types.ts). ## Continuous Integration From 95f55c99a309fc81a57f1797621804b9b68f09ce Mon Sep 17 00:00:00 2001 From: name Date: Sun, 22 Jun 2025 07:07:25 +0300 Subject: [PATCH 2/5] removed Unused '@ts-expect-error' directive --- eslint.config.js | 1 - 1 file changed, 1 deletion(-) diff --git a/eslint.config.js b/eslint.config.js index fef586324..9e1b6edf8 100644 --- a/eslint.config.js +++ b/eslint.config.js @@ -1,6 +1,5 @@ import assert from 'node:assert' import eslintParser from '@typescript-eslint/parser' -// @ts-expect-error no types import importPlugin from 'eslint-plugin-import' import jsdoc from 'eslint-plugin-jsdoc' // @ts-expect-error no types From 1c3ac65c2028d43ae0a02a7bf2944a0a23830173 Mon Sep 17 00:00:00 2001 From: name Date: Sun, 22 Jun 2025 07:10:35 +0300 Subject: [PATCH 3/5] removed irrelevant old comment on eslint upgrade --- eslint.config.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/eslint.config.js b/eslint.config.js index 9e1b6edf8..404961387 100644 --- a/eslint.config.js +++ b/eslint.config.js @@ -116,10 +116,6 @@ setParser('neostandard/ts', eslintParser, { ecmaVersion: 'latest' }) -// TODO: not compatible with ESLint 9x yet -// addPlugin('neostandard/ts', 'etc', etc) -// addRule('neostandard/ts', 'etc/prefer-interface', 'error') // https://ncjamieson.com/prefer-interfaces/ - addRule('neostandard/ts', 'no-return-await', 'off') // disable this rule to use @typescript-eslint/return-await instead addRule('neostandard/ts', '@typescript-eslint/no-use-before-define', [ 'error', { From 3d9b3d5f3e0a971c53087392068d01977ea252bf Mon Sep 17 00:00:00 2001 From: name Date: Sun, 22 Jun 2025 07:18:46 +0300 Subject: [PATCH 4/5] removed unused variables in lint --- src/lint.js | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/lint.js b/src/lint.js index d02669581..10e6c2440 100644 --- a/src/lint.js +++ b/src/lint.js @@ -27,9 +27,8 @@ const tasks = new Listr( /** * * @param {GlobalOptions & LintOptions} ctx - * @param {Task} task */ - task: async (ctx, task) => { + task: async (ctx) => { const eslint = new ESLint({ fix: ctx.fix, overrideConfigFile: fromAegir('eslint.config.js') @@ -64,10 +63,7 @@ const tasks = new Listr( }, { title: 'tsc', - /** - * @param {GlobalOptions & LintOptions} ctx - */ - enabled: ctx => hasTsconfig && !isTypescript, + enabled: () => hasTsconfig && !isTypescript, /** * @param {GlobalOptions & LintOptions} ctx * @param {Task} task From 0a581332fb92174829009579e4380900d3fd9c3c Mon Sep 17 00:00:00 2001 From: name Date: Sun, 22 Jun 2025 07:20:29 +0300 Subject: [PATCH 5/5] removed unused variables in dependy-check --- src/dependency-check.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/dependency-check.js b/src/dependency-check.js index 0e9aaa0dd..8f0a93dbe 100644 --- a/src/dependency-check.js +++ b/src/dependency-check.js @@ -39,9 +39,8 @@ const tasks = new Listr( title: 'dependency-check', /** * @param {GlobalOptions & DependencyCheckOptions} ctx - * @param {Task} task */ - task: async (ctx, task) => { + task: async (ctx) => { let missingOrUnusedPresent = false // check production dependencies