Fix setuptools package discovery#42
Open
MarkKoz wants to merge 1 commit into
Open
Conversation
Author
|
Okay this doesn't seem to work — I was initially testing with the repo as the cwd, so I missed this: Not sure why this is a problem. |
e29b899 to
7f34e2a
Compare
Author
|
Right, so I was only including the root package and not subpackages. Subpackages would have to be explicitly included when providing a list. So instead, I switched to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to install this package on Python 3.9 with pip 23.3.1 and setuptools 68.2.2. It incorrectly installs the package into the root
site-packagesdirectory (instead of within anh2p_parsersubdirectory). The module is not importable when installed this way.I don't really know why setuptools installs it that way, but the config seemed relatively complex for what this package needs.
package_dirseems unnecessary since the package is in the root directory:(https://setuptools.pypa.io/en/latest/userguide/package_discovery.html)