Promote remaining Vue lint warnings to errors now that the codebase is clean

[RayBB]

Part of epic #13447 — comment on the issue to claim it (no need to wait for assignment), then open a PR referencing it. Follow-up to #13477 (fixed by #13479) and #13473.

Both PRs are merged, so npx eslint . now reports 0 warnings on first-party Vue components. The only reason these warnings accumulated is that flat/recommended ships the relevant rules at warn, and CI does not fail on warnings. With the codebase clean, we can flip them to error at zero cost and prevent regression.

Change

In eslint.config.cjs, in the **/*.vue rules block (next to the existing vue/multi-word-component-names entry), add:

"vue/require-prop-types": "error",
"vue/require-explicit-emits": "error",
"vue/require-default-prop": "error",
"vue/no-v-html": "error",
"vue/no-template-shadow": "error",

Rationale per rule:

• require-prop-types + require-default-prop force every prop to declare a type and an explicit required/default — the exact decisions Fix Vue prop lint warnings #13473 had to make by hand.
• require-explicit-emits + no-template-shadow cover the other two warning classes cleaned up in fix(vue): resolve remaining component lint warnings (#13477) #13479.
• no-v-html is the only security rule of the bunch; as an error, any future v-html requires a visible, justified eslint-disable in review.

Do not bulk-promote all 30 warn rules from flat/recommended — most are formatting rules (vue/html-indent, vue/max-attributes-per-line, ...) that would turn style churn into hard CI failures without safety value.

Acceptance criteria

• The five rules above are set to "error" in eslint.config.cjs
• npm run lint / npx eslint . passes with 0 errors and 0 warnings on current master
• No inline eslint-disable added anywhere to make the flip pass

Difficulty: 1/5

[openlibrary-bot]

Context

• The five target rules are not currently overridden anywhere in eslint.config.cjs — they sit purely on the flat/recommended defaults from eslint-plugin-vue@^9.32.0 (warn), confirmed by grepping the repo for each rule name. The insertion point described in the issue (next to the existing Vue rules block) is here:

  openlibrary/eslint.config.cjs

  Lines 132 to 138 in d6e5db7

  	"vue/no-mutating-props": "off",
  	"vue/multi-word-component-names": [
  	"error",
  	{
  	ignores: ["Bookshelf", "Shelf"],
  	},
  	],

• Both prerequisite PRs are merged on master: Fix Vue prop lint warnings #13473 ("Fix Vue prop lint warnings", 29 files, merged 2026-08-27) and fix(vue): resolve remaining component lint warnings (#13477) #13479 ("fix(vue): resolve remaining component lint warnings (Fix the remaining Vue lint warnings (require-prop-types, explicit-emits, no-template-shadow, v-html) #13477)", 7 files, merged 2026-09-01T16:49:32Z — same day as this issue). Fix the remaining Vue lint warnings (require-prop-types, explicit-emits, no-template-shadow, v-html) #13477 is closed as fixed by fix(vue): resolve remaining component lint warnings (#13477) #13479.
• The other epic dependency that could otherwise mask the "0 warnings" claim — Stop ESLint from linting the gitignored docs/wiki clone (58.5 MB of output) #13448, stopping ESLint from also scanning the gitignored docs/wiki/ clone — is merged via fix(eslint): ignore the gitignored docs/wiki clone #13458. So npx eslint . on current master should not have unrelated noise drowning out the signal from this change.
• No open duplicate found (searched issues for "vue lint warning"); this is a natural, not-yet-filed successor to Fix the 69 real Vue lint warnings (vue/require-default-prop, prop-name-casing) #13455/Fix the remaining Vue lint warnings (require-prop-types, explicit-emits, no-template-shadow, v-html) #13477 under epic [Epic] Quiet the tooling — eliminate lint/test output noise and false failures #13447 — it isn't yet listed in the epic's sub-issue tracking table, which is a minor bookkeeping gap only.
• Could not execute npx eslint . directly in this environment (no node_modules installed) to empirically confirm 0 warnings on current master — the assessment above is based on the merged diffs of Fix Vue prop lint warnings #13473/fix(vue): resolve remaining component lint warnings (#13477) #13479 covering exactly the rule set named in this issue, not a live lint run.

Issue Assessment

No open questions or action items — the issue already specifies the exact diff, file, and insertion point, and the acceptance criteria are directly verifiable (npx eslint . exit code and diff review for stray eslint-disable).

🔔 Stakeholders

No additional stakeholder to tag — @RayBB is both the author and the assigned lead (Lead: @RayBB), and the epic (#13447) is already theirs.

Full triage checklist

• Triage — labels reviewed; no changes needed (Good First Issue, Lead: @RayBB, module/theme labels all already correctly applied; no Needs: Triage/Needs: Breakdown/blocking labels warranted)
• Scope — narrow and explicit; issue deliberately excludes bulk-promoting the other ~30 warn rules (formatting-only, no safety value)
• Problem / opportunity — clear and quantified: flip 5 named rules from warn→error at zero cost now that the codebase is clean, to prevent regression
• Justification — per-rule rationale given, tied to the specific warning classes fixed in Fix Vue prop lint warnings #13473/fix(vue): resolve remaining component lint warnings (#13477) #13479
• Success & testing criteria — concrete and verifiable (npm run lint / npx eslint . exit 0, no new eslint-disable)
• Proposal & breakdown — exact code diff and file location provided; no further breakdown needed
• If bug: environment & repro steps — n/a, not a bug report
• Risks, concerns, open questions — addressed in the issue itself (explicit scope-limiting rationale); none outstanding
• Richy context — code, commit history, and related PRs/issues reviewed; no duplicate found
• References — n/a, no designs/screenshots needed for a lint-config change

---

Note

This comment was automatically generated by Richy, Open Library's issue enrichment assistant, on behalf of @mekarpeles. This is NOT a sign-off. This issue needs lead review before work begins.

[Nehant14]

I'd like to work on this will add the 5 rules to the **/*.vue block in eslint.config.cjs and confirm npm run lint passes with 0 warnings/errors on master before opening a PR.

[RayBB]

@Nehant14 go for it!

[CipherZ3r0]

hey @RayBB I started working on it when there was no comment mentioning anyone and just saw the comment.