Migrate log functions to sycl:: in XPU kernels and refactor types#3725
Open
orrangetabby17 wants to merge 4 commits into
Open
Migrate log functions to sycl:: in XPU kernels and refactor types#3725orrangetabby17 wants to merge 4 commits into
orrangetabby17 wants to merge 4 commits into
Conversation
- Real/Half paths: sycl:: with opmath_t cast - Complex paths: retain std:: - Host-side code (RandpermKernel, LossNLLKernel): unchanged Part of #3266
github-actions
Bot
added
disable_e2e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates various mathematical kernel implementations to consistently use SYCL-provided logarithmic functions (
sycl::log,sycl::log1p) instead of the standard C++ math library (std::log,std::log1p). This change improves compatibility and performance on SYCL-supported devices, and ensures consistent behavior across the codebase. Additionally, there are minor type and header updates to support these changes.Logarithmic function migration:
std::logandstd::log1pwithsycl::logandsycl::log1p, including files likeActivationMishKernels.cpp,ActivationSoftplusKernels.cpp,BinaryMiscOpsKernels.cpp,LogAddExpKernels.cpp,LossCTCKernels.cpp,MathExtensions.h,Philox4x32.h, andSoftMaxKernels.cpp.Type and header consistency:
at::opmath_typefor correct type promotion in mathematical operations.<c10/util/complex.h>to ensure proper compilation.ASM difference:
These changes collectively improve device compatibility, numerical correctness, and maintainability of the SYCL backend.