Migrate std::floor to sycl::floor in device kernels #3721
Open
orrangetabby17 wants to merge 1 commit into
Open
Migrate std::floor to sycl::floor in device kernels #3721orrangetabby17 wants to merge 1 commit into
orrangetabby17 wants to merge 1 commit into
Conversation
c0df31c to
185bcf4
Compare
weishi-deng
reviewed
May 22, 2026
weishi-deng
reviewed
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors several SYCL/XPU kernel files to consistently use
sycl::floorinstead ofstd::floororfloorf, and introduces the use of theat::opmath_typetype trait to improve numerical precision and type safety. These changes standardize floating-point operations across the codebase, which is important for device compatibility and correctness.Numerical precision and type safety improvements:
at::opmath_typein multiple kernels (e.g.,DeformConv2dKernels.cpp,PsRoiPoolKernels.cpp,RoiPoolKernels.cpp,UnaryFractionKernels.cpp,GridSampler.cpp) to ensure that mathematical operations are performed in a type-safe way.Device compatibility and code consistency:
std::floorandfloorfwithsycl::floorin device kernel code, ensuring compatibility with SYCL device execution.Header and dependency updates:
#include <ATen/OpMathType.h>where necessary to support the newopmath_typeusage.ASM Difference
These changes improve the reliability and maintainability of the code on SYCL devices.