qpl/sources/middle-layer/compression/deflate/containers /huffman_table.cpp: Potential Integer Overflow

[stasos24]

Case 1

Since

fixed_codes[i].length is unt8_t

and

ll_histogram[i] is unt32_t

There is could be possible integer overflow at:

qpl/sources/middle-layer/compression/deflate/containers/huffman_table.cpp

Line 134 in d08be00

fixed_compressed_len += fixed_ll_codes[i].length * ll_histogram[i];

Possible fix:

static_cast<uint64_t>(ll_codes[i].length) * ll_histogram[i];

Case 2

Since

buffer_used(bit_buffer) + bit_buffer->m_bit_count - are unit32_t

at

qpl/sources/middle-layer/compression/deflate/containers/huffman_table.cpp

Line 164 in d08be00

compressed_len += 8 * buffer_used(bit_buffer) + bit_buffer->m_bit_count;

it would be better to cast one of them to uint64_t because compressed_len is uint64_t

[mzhukova]

Thanks for pointing this out! We'll take a look and I'll let you know once this is addressed.