-
Notifications
You must be signed in to change notification settings - Fork 0
Should enumerations be more helpful #27
Description
From the perspective of a user of this document, having enumerations be fully realized may be helpful, depending on whether or not the terms will originate in MapDragon or added by the person writing the DBT Transforms.
File/FileAssay.data_type and format
both indicate they would be EDAM, but no codes are provided in the official docs. It seems reasonable to me that the time spent investigating how to coalesce those terms into the model during the build would ultimately save time for harmonizers.
Clarity of expectations
- value_units - Is this expected to be ucum? It doesn't say so in the description.
Use of Meaning?
Are there ontology terms that match our DataCategory terms? If so, it would be nice if they were added to the code's "Meaning" to help with automating the harmonization (those can be turned into seeds with the script I put together).
Others that could use meaning and/or description:
- EnumDataCategory
- EnumClinicalDataSourceType
- EnumStudyDesign
- EnumParticipantLifespanStage
Explicit Enumerations
Someone needs to populate the enumerations unless they will be populated via MapDragon. Here are a few examples:
- EnumLaterality
- EnumSpatialQualifiers
- EnumSite
- EnumSampleCollectionMethod