Optimizations + QoL improvements#35
Merged
Merged
Conversation
colemanirby
approved these changes
Sep 4, 2025
Contributor
colemanirby
left a comment
colemanirby
left a comment
There was a problem hiding this comment.
LGTM. Nice QoL changes.
- Add Safety sections to timelock_get_version(), timelock_init(), and timelock_cleanup() - Resolves clippy missing_safety_doc warnings - All functions are safe to call from any context despite unsafe extern C marking
- Add brew uninstall cmake before installing to avoid tap conflicts - Resolves CI failure where cmake from local/pinned tap conflicts with homebrew/core - Uses --ignore-dependencies and || true for safe uninstall
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR: