From 10d5dfdc041805497566a591a119f50715f61367 Mon Sep 17 00:00:00 2001 From: Imani Manyara Date: Wed, 11 Nov 2026 10:15:40 -0500 Subject: [PATCH 1/2] Name the per-set sync recipes icon-sets-extras- --- CHANGELOG.md | 1 + resources/assets/svg/config.json | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 487d583a9..39209cc40 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,7 @@ All notable changes to `ichava/icon-sets-extras` follow [Keep a Changelog](https ### Changed +- **The per-set sync recipes are named `icon-sets-extras-`**, not `icon-sets-extras.`: icon-sets-sync names packs by lowercase slugs (icon-sets-sync#104). `update_command.recipe` and the two notes in `resources/assets/svg/config.json` say so. icon-sets-sync still accepts the dotted name, with a warning, until its 1.0.0. No icon or licence changed. - **This pack requires `ichava/core` and nothing else.** `composer.json` `require` is now `php` and `ichava/core`; `illuminate/support` and `laranail/package-tools` were dropped from it and still arrive through core. The provider extends core's `IconPackServiceProvider` and declares its constants class and component class, so `src/` imports no `laranail/*` namespace; it registers the same name, path, Blade component and icon directory as before. The composer `type` is `ichava-icon-set`, which core's pack discovery reads. The README and `docs/installation.md` no longer restate the `laranail/*` repositories: they link to core's installation guide, the one place that lists them, and no longer say the pack is on Packagist, which no Ichava package is yet. `tests/Unit/CoreOnlyDependencyTest.php` fails if any of it comes back. - **Pepicons' licence is stated per variant, and upstream's commercial-use request is quoted as a request.** Pop!, Print and Pencil (1,275 files each) are all CC BY 4.0: one npm package whose `license` field names it, under one repository `LICENSE` that is the CC BY 4.0 legal code with no commercial term. The repository's root README asks commercial users to buy a licence through a one-time sponsorship; that sentence is in neither the licence file nor the npm package, and CC BY 4.0 is irrevocable with no non-commercial limit, so it is a request beside the grant. `ATTRIBUTION.md` and `docs/attribution.md` say so, with sources read on 2026-11-05, and `PepiconsLicenceTest` fails on a fourth variant, a changed or commercial licence text, or a missing per-variant row. Nothing shipped changed. - **The hand-supplied licences of `ant-design`, `eva` and `pepicons` are marked with a `source.md`** beside each `LICENSE`, recording the upstream file, ref and SHA-256. Their npm packages ship no licence file, so without the marker a real sync would delete those directories. The upstream sync runs icon-sets-sync `cbebf08` (icon-sets-sync#89), up from `06b17d7`, the first commit whose licence sink accepts the lowercase marker. `SetLicenceTest` fails if a marker or a text goes missing. diff --git a/resources/assets/svg/config.json b/resources/assets/svg/config.json index fa692bdbb..e16fedd5d 100644 --- a/resources/assets/svg/config.json +++ b/resources/assets/svg/config.json @@ -290,7 +290,7 @@ "upstream": { "source": { "type": "manifest", - "_note": "One upstream per set, under upstream.sets. Each has its own recipe in the design folder (pack-recipes/icon-sets-extras..json)." + "_note": "One upstream per set, under upstream.sets. Each has its own icon-sets-sync config, config/icon-sets-extras-.json." }, "license": "per set", "sets": { @@ -1008,8 +1008,8 @@ }, "update_command": { "type": "recipe", - "recipe": "icon-sets-extras.", - "_note": "Each set has its own icon-sets-sync recipe, icon-sets-extras. (icon-sets-sync#88), which refreshes files// and licenses// and stamps upstream.sets..current_version." + "recipe": "icon-sets-extras-", + "_note": "Each set has its own icon-sets-sync recipe, icon-sets-extras- (icon-sets-sync#88; named icon-sets-extras. until icon-sets-sync#104, which still accepts the old name), which refreshes files// and licenses// and stamps upstream.sets..current_version." } }, "license": { From 50c4cefd327a30506c59901696ba111bd143c222 Mon Sep 17 00:00:00 2001 From: Imani Manyara Date: Wed, 11 Nov 2026 10:27:25 -0500 Subject: [PATCH 2/2] Drop the note that the dotted recipe name still works --- CHANGELOG.md | 2 +- resources/assets/svg/config.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 39209cc40..47aacb2d9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,7 +6,7 @@ All notable changes to `ichava/icon-sets-extras` follow [Keep a Changelog](https ### Changed -- **The per-set sync recipes are named `icon-sets-extras-`**, not `icon-sets-extras.`: icon-sets-sync names packs by lowercase slugs (icon-sets-sync#104). `update_command.recipe` and the two notes in `resources/assets/svg/config.json` say so. icon-sets-sync still accepts the dotted name, with a warning, until its 1.0.0. No icon or licence changed. +- **The per-set sync recipes are named `icon-sets-extras-`**, not `icon-sets-extras.`: icon-sets-sync names packs by lowercase slugs (icon-sets-sync#104). `update_command.recipe` and the two notes in `resources/assets/svg/config.json` say so. icon-sets-sync no longer accepts the dotted name. No icon or licence changed. - **This pack requires `ichava/core` and nothing else.** `composer.json` `require` is now `php` and `ichava/core`; `illuminate/support` and `laranail/package-tools` were dropped from it and still arrive through core. The provider extends core's `IconPackServiceProvider` and declares its constants class and component class, so `src/` imports no `laranail/*` namespace; it registers the same name, path, Blade component and icon directory as before. The composer `type` is `ichava-icon-set`, which core's pack discovery reads. The README and `docs/installation.md` no longer restate the `laranail/*` repositories: they link to core's installation guide, the one place that lists them, and no longer say the pack is on Packagist, which no Ichava package is yet. `tests/Unit/CoreOnlyDependencyTest.php` fails if any of it comes back. - **Pepicons' licence is stated per variant, and upstream's commercial-use request is quoted as a request.** Pop!, Print and Pencil (1,275 files each) are all CC BY 4.0: one npm package whose `license` field names it, under one repository `LICENSE` that is the CC BY 4.0 legal code with no commercial term. The repository's root README asks commercial users to buy a licence through a one-time sponsorship; that sentence is in neither the licence file nor the npm package, and CC BY 4.0 is irrevocable with no non-commercial limit, so it is a request beside the grant. `ATTRIBUTION.md` and `docs/attribution.md` say so, with sources read on 2026-11-05, and `PepiconsLicenceTest` fails on a fourth variant, a changed or commercial licence text, or a missing per-variant row. Nothing shipped changed. - **The hand-supplied licences of `ant-design`, `eva` and `pepicons` are marked with a `source.md`** beside each `LICENSE`, recording the upstream file, ref and SHA-256. Their npm packages ship no licence file, so without the marker a real sync would delete those directories. The upstream sync runs icon-sets-sync `cbebf08` (icon-sets-sync#89), up from `06b17d7`, the first commit whose licence sink accepts the lowercase marker. `SetLicenceTest` fails if a marker or a text goes missing. diff --git a/resources/assets/svg/config.json b/resources/assets/svg/config.json index e16fedd5d..fcbdc9ee4 100644 --- a/resources/assets/svg/config.json +++ b/resources/assets/svg/config.json @@ -1009,7 +1009,7 @@ "update_command": { "type": "recipe", "recipe": "icon-sets-extras-", - "_note": "Each set has its own icon-sets-sync recipe, icon-sets-extras- (icon-sets-sync#88; named icon-sets-extras. until icon-sets-sync#104, which still accepts the old name), which refreshes files// and licenses// and stamps upstream.sets..current_version." + "_note": "Each set has its own icon-sets-sync recipe, icon-sets-extras- (icon-sets-sync#88, renamed from the dotted form in icon-sets-sync#104), which refreshes files// and licenses// and stamps upstream.sets..current_version." } }, "license": {