From d5a8140c6233c84f7c17fb65d2c222be9ef0ac2d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bart=C5=82omiej=20Nowak?= Date: Tue, 22 Sep 2026 15:47:02 +0200 Subject: [PATCH 1/2] IBX-12654: Added ibexa/phpstan to the PHPStan configuration --- composer.json | 1 + phpstan.neon.dist | 1 + 2 files changed, 2 insertions(+) diff --git a/composer.json b/composer.json index b34daf24..be837ee0 100644 --- a/composer.json +++ b/composer.json @@ -28,6 +28,7 @@ "require-dev": { "ibexa/code-style": "~2.0.0", "ibexa/doctrine-schema": "~6.0.x-dev", + "ibexa/phpstan": "~6.0.x-dev", "ibexa/rector": "~6.0.x-dev", "matthiasnoback/symfony-dependency-injection-test": "^6.0", "phpstan/phpstan": "^2.0", diff --git a/phpstan.neon.dist b/phpstan.neon.dist index 6652998b..8310be99 100644 --- a/phpstan.neon.dist +++ b/phpstan.neon.dist @@ -1,6 +1,7 @@ includes: - vendor/phpstan/phpstan-phpunit/extension.neon - vendor/phpstan/phpstan-symfony/extension.neon + - vendor/ibexa/phpstan/extension.neon - phpstan-baseline.neon parameters: From 6af380bec14ecfb81eaa22060f59681147d8663b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bart=C5=82omiej=20Nowak?= Date: Tue, 22 Sep 2026 15:49:21 +0200 Subject: [PATCH 2/2] IBX-12654: Fixed issues reported by ibexa/phpstan rules --- src/bundle/DependencyInjection/Configuration.php | 4 ++-- .../DistributionStrategy/CloudDistributionStrategy.php | 2 +- .../DistributionStrategy/StandaloneDistributionStrategy.php | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/bundle/DependencyInjection/Configuration.php b/src/bundle/DependencyInjection/Configuration.php index ff0dd83e..767a8f44 100644 --- a/src/bundle/DependencyInjection/Configuration.php +++ b/src/bundle/DependencyInjection/Configuration.php @@ -129,7 +129,7 @@ protected function addConnectionsSection(ArrayNodeDefinition $node): void static fn ($v): bool => !empty($v['mapping']) && !\is_array($v['mapping']) ) ->then( - static function (array $v) { + static function (array $v): array { // If single endpoint is set for Content mapping, use it as default // mapping for Content index $v['mapping'] = [ @@ -151,7 +151,7 @@ static function (array $v) { ) ->then( // If entry endpoints are not provided use mapping endpoints - static function (array $v) { + static function (array $v): array { $endpointSet = []; if (!empty($v['mapping']['translations'])) { diff --git a/src/lib/Gateway/DistributionStrategy/CloudDistributionStrategy.php b/src/lib/Gateway/DistributionStrategy/CloudDistributionStrategy.php index 606fc9b8..51cc6fa3 100644 --- a/src/lib/Gateway/DistributionStrategy/CloudDistributionStrategy.php +++ b/src/lib/Gateway/DistributionStrategy/CloudDistributionStrategy.php @@ -20,7 +20,7 @@ final class CloudDistributionStrategy extends AbstractDistributionStrategy protected function appendSearchTargets(array $parameters, array $searchTargets): array { - $collections = array_map(fn (string $endpointName) => $this->endpointRegistry->getEndpoint($endpointName)->core, $searchTargets); + $collections = array_map(fn (string $endpointName): string => $this->endpointRegistry->getEndpoint($endpointName)->core, $searchTargets); $parameters[self::COLLECTION_PARAMETER] = implode(self::COLLECTION_SEPARATOR, $collections); diff --git a/src/lib/Gateway/DistributionStrategy/StandaloneDistributionStrategy.php b/src/lib/Gateway/DistributionStrategy/StandaloneDistributionStrategy.php index 3f2748ad..afa5e950 100644 --- a/src/lib/Gateway/DistributionStrategy/StandaloneDistributionStrategy.php +++ b/src/lib/Gateway/DistributionStrategy/StandaloneDistributionStrategy.php @@ -20,7 +20,7 @@ final class StandaloneDistributionStrategy extends AbstractDistributionStrategy protected function appendSearchTargets(array $parameters, array $searchTargets): array { - $shards = array_map(fn (string $endpointName) => $this->endpointRegistry->getEndpoint($endpointName)->getIdentifier(), $searchTargets); + $shards = array_map(fn (string $endpointName): string => $this->endpointRegistry->getEndpoint($endpointName)->getIdentifier(), $searchTargets); $parameters[self::SHARD_PARAMETER] = implode(self::SHARD_SEPARATOR, $shards);