From fa5c724c484de020bdbd2e45558768af27b12ae4 Mon Sep 17 00:00:00 2001 From: Dawid Parafinski Date: Wed, 9 Sep 2026 13:47:06 +0200 Subject: [PATCH] IBX-12046: Removed Symfony 8 deprecated code usage Replaced the deprecated Request::get() call in ConditionallyRemoveVaryHeaderListener with the explicit attributes bag access, since the route name is a route attribute, not a query/request parameter. --- .../EventListener/ConditionallyRemoveVaryHeaderListener.php | 2 +- .../ConditionallyRemoveVaryHeaderListenerTest.php | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/lib/EventListener/ConditionallyRemoveVaryHeaderListener.php b/src/lib/EventListener/ConditionallyRemoveVaryHeaderListener.php index 15ce8f0..74aac3f 100644 --- a/src/lib/EventListener/ConditionallyRemoveVaryHeaderListener.php +++ b/src/lib/EventListener/ConditionallyRemoveVaryHeaderListener.php @@ -53,7 +53,7 @@ public function onKernelResponse(ResponseEvent $event): void return; } - if (!\in_array($event->getRequest()->get('_route'), $this->routes)) { + if (!\in_array($event->getRequest()->attributes->get('_route'), $this->routes)) { return; } diff --git a/tests/bundle/EventListener/ConditionallyRemoveVaryHeaderListenerTest.php b/tests/bundle/EventListener/ConditionallyRemoveVaryHeaderListenerTest.php index d70f8b6..3f75281 100644 --- a/tests/bundle/EventListener/ConditionallyRemoveVaryHeaderListenerTest.php +++ b/tests/bundle/EventListener/ConditionallyRemoveVaryHeaderListenerTest.php @@ -77,9 +77,8 @@ public function onKernelResponseProvider(): iterable */ public function testOnKernelResponse(array $varyHeaders, array $expectedVaryHeaders): void { - $request = $this->createMock(Request::class); - $request->method('get') - ->willReturn('testroute1'); + $request = new Request(); + $request->attributes->set('_route', 'testroute1'); $response = new Response('test content', Response::HTTP_OK, ['vary' => $varyHeaders]);