From 7bbe4bc36b2ed72f3af65547f7fbd2ccc3e2bdf1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bart=C5=82omiej=20Nowak?= Date: Tue, 22 Sep 2026 09:22:15 +0200 Subject: [PATCH] IBX-12654: Fixed dynamic calls to static methods --- ...tTreeChildrenQueryArgumentResolverTest.php | 2 +- .../Configuration/Parser/AdminUiFormsTest.php | 48 +++++++++---------- .../Parser/SubtreeOperationsTest.php | 14 +++--- .../SetViewParametersListenerTest.php | 6 +-- .../UDWBasedValueViewTransformerTest.php | 4 +- .../DataTransformer/UserTransformerTest.php | 2 +- .../ContentTypeFormProcessorTest.php | 14 +++--- .../Action/DraftListActionMenuBuilderTest.php | 4 +- .../VersionListActionMenuBuilderTest.php | 2 +- .../Pagerfanta/URLSearchAdapterTest.php | 20 ++++---- .../Pagerfanta/URLWildcardAdapterTest.php | 20 ++++---- 11 files changed, 68 insertions(+), 68 deletions(-) diff --git a/tests/bundle/ControllerArgumentResolver/ContentTreeChildrenQueryArgumentResolverTest.php b/tests/bundle/ControllerArgumentResolver/ContentTreeChildrenQueryArgumentResolverTest.php index 87f3e66e0c..79b8c3d4bd 100644 --- a/tests/bundle/ControllerArgumentResolver/ContentTreeChildrenQueryArgumentResolverTest.php +++ b/tests/bundle/ControllerArgumentResolver/ContentTreeChildrenQueryArgumentResolverTest.php @@ -101,7 +101,7 @@ public function testResolve( $generator = $this->resolver->resolve( $request, - $this->createArgumentMetadata( + self::createArgumentMetadata( 'filter', Criterion::class ) diff --git a/tests/bundle/DependencyInjection/Configuration/Parser/AdminUiFormsTest.php b/tests/bundle/DependencyInjection/Configuration/Parser/AdminUiFormsTest.php index e4c48456b9..047a168589 100644 --- a/tests/bundle/DependencyInjection/Configuration/Parser/AdminUiFormsTest.php +++ b/tests/bundle/DependencyInjection/Configuration/Parser/AdminUiFormsTest.php @@ -55,16 +55,16 @@ public function testContentEditFormTemplatesAreMapped(): void $this->contextualizer ->expects($matcher) - ->method('setContextualParameter')->willReturnCallback(function (...$parameters) use ($matcher, $currentScope, $expectedTemplatesList): void { + ->method('setContextualParameter')->willReturnCallback(static function (...$parameters) use ($matcher, $currentScope, $expectedTemplatesList): void { if ($matcher->numberOfInvocations() === 1) { - $this->assertSame(AdminUiForms::FORM_TEMPLATES_PARAM, $parameters[0]); - $this->assertSame($currentScope, $parameters[1]); - $this->assertSame($expectedTemplatesList, $parameters[2]); + self::assertSame(AdminUiForms::FORM_TEMPLATES_PARAM, $parameters[0]); + self::assertSame($currentScope, $parameters[1]); + self::assertSame($expectedTemplatesList, $parameters[2]); } if ($matcher->numberOfInvocations() === 2) { - $this->assertSame(AdminUiForms::FIELD_TYPES_PARAM, $parameters[0]); - $this->assertSame($currentScope, $parameters[1]); - $this->assertSame([], $parameters[2]); + self::assertSame(AdminUiForms::FIELD_TYPES_PARAM, $parameters[0]); + self::assertSame($currentScope, $parameters[1]); + self::assertSame([], $parameters[2]); } }); @@ -96,16 +96,16 @@ public function testContentEditFieldTypesAreMapped(): void $this->contextualizer ->expects($matcher) - ->method('setContextualParameter')->willReturnCallback(function (...$parameters) use ($matcher, $currentScope, $expectedFieldTypeSettings): void { + ->method('setContextualParameter')->willReturnCallback(static function (...$parameters) use ($matcher, $currentScope, $expectedFieldTypeSettings): void { if ($matcher->numberOfInvocations() === 1) { - $this->assertSame(AdminUiForms::FORM_TEMPLATES_PARAM, $parameters[0]); - $this->assertSame($currentScope, $parameters[1]); - $this->assertSame([], $parameters[2]); + self::assertSame(AdminUiForms::FORM_TEMPLATES_PARAM, $parameters[0]); + self::assertSame($currentScope, $parameters[1]); + self::assertSame([], $parameters[2]); } if ($matcher->numberOfInvocations() === 2) { - $this->assertSame(AdminUiForms::FIELD_TYPES_PARAM, $parameters[0]); - $this->assertSame($currentScope, $parameters[1]); - $this->assertSame($expectedFieldTypeSettings, $parameters[2]); + self::assertSame(AdminUiForms::FIELD_TYPES_PARAM, $parameters[0]); + self::assertSame($currentScope, $parameters[1]); + self::assertSame($expectedFieldTypeSettings, $parameters[2]); } }); @@ -132,21 +132,21 @@ public function testContentEditMetaFieldgroupListIsMapped(): void $this->contextualizer ->expects($matcher) - ->method('setContextualParameter')->willReturnCallback(function (...$parameters) use ($matcher, $currentScope): void { + ->method('setContextualParameter')->willReturnCallback(static function (...$parameters) use ($matcher, $currentScope): void { if ($matcher->numberOfInvocations() === 1) { - $this->assertSame(AdminUiForms::FORM_TEMPLATES_PARAM, $parameters[0]); - $this->assertSame($currentScope, $parameters[1]); - $this->assertSame([], $parameters[2]); + self::assertSame(AdminUiForms::FORM_TEMPLATES_PARAM, $parameters[0]); + self::assertSame($currentScope, $parameters[1]); + self::assertSame([], $parameters[2]); } if ($matcher->numberOfInvocations() === 2) { - $this->assertSame(AdminUiForms::FIELD_TYPES_PARAM, $parameters[0]); - $this->assertSame($currentScope, $parameters[1]); - $this->assertSame([], $parameters[2]); + self::assertSame(AdminUiForms::FIELD_TYPES_PARAM, $parameters[0]); + self::assertSame($currentScope, $parameters[1]); + self::assertSame([], $parameters[2]); } if ($matcher->numberOfInvocations() === 3) { - $this->assertSame(AdminUiForms::META_FIELD_GROUPS_LIST_PARAM, $parameters[0]); - $this->assertSame($currentScope, $parameters[1]); - $this->assertSame(['metadata', 'seo'], $parameters[2]); + self::assertSame(AdminUiForms::META_FIELD_GROUPS_LIST_PARAM, $parameters[0]); + self::assertSame($currentScope, $parameters[1]); + self::assertSame(['metadata', 'seo'], $parameters[2]); } }); diff --git a/tests/bundle/DependencyInjection/Configuration/Parser/SubtreeOperationsTest.php b/tests/bundle/DependencyInjection/Configuration/Parser/SubtreeOperationsTest.php index 3ef8fb120b..acf14a563a 100644 --- a/tests/bundle/DependencyInjection/Configuration/Parser/SubtreeOperationsTest.php +++ b/tests/bundle/DependencyInjection/Configuration/Parser/SubtreeOperationsTest.php @@ -143,16 +143,16 @@ public function testBothSubtreeOperationsSet(): void $this->contextualizer ->expects($matcher) - ->method('setContextualParameter')->willReturnCallback(function (...$parameters) use ($matcher, $currentScope): void { + ->method('setContextualParameter')->willReturnCallback(static function (...$parameters) use ($matcher, $currentScope): void { if ($matcher->numberOfInvocations() === 1) { - $this->assertSame('subtree_operations.copy_subtree.limit', $parameters[0]); - $this->assertSame($currentScope, $parameters[1]); - $this->assertSame(200, $parameters[2]); + self::assertSame('subtree_operations.copy_subtree.limit', $parameters[0]); + self::assertSame($currentScope, $parameters[1]); + self::assertSame(200, $parameters[2]); } if ($matcher->numberOfInvocations() === 2) { - $this->assertSame('subtree_operations.query_subtree.limit', $parameters[0]); - $this->assertSame($currentScope, $parameters[1]); - $this->assertSame(500, $parameters[2]); + self::assertSame('subtree_operations.query_subtree.limit', $parameters[0]); + self::assertSame($currentScope, $parameters[1]); + self::assertSame(500, $parameters[2]); } }); diff --git a/tests/lib/EventListener/SetViewParametersListenerTest.php b/tests/lib/EventListener/SetViewParametersListenerTest.php index 6e040cb485..0eaba97e13 100644 --- a/tests/lib/EventListener/SetViewParametersListenerTest.php +++ b/tests/lib/EventListener/SetViewParametersListenerTest.php @@ -64,9 +64,9 @@ public function setUp(): void $configResolver = $this->createMock(ConfigResolverInterface::class); $matcher = self::any(); $configResolver->expects($matcher) - ->method('getParameter')->willReturnCallback(function (...$parameters) use ($matcher): array { + ->method('getParameter')->willReturnCallback(static function (...$parameters) use ($matcher): array { if ($matcher->numberOfInvocations() === 1) { - $this->assertSame('admin_ui_forms.content_edit.fieldtypes', $parameters[0]); + self::assertSame('admin_ui_forms.content_edit.fieldtypes', $parameters[0]); return [ 'ibexa_taxonomy_entry_assignment' => [ @@ -75,7 +75,7 @@ public function setUp(): void ]; } if ($matcher->numberOfInvocations() === 2) { - $this->assertSame('admin_ui_forms.content_edit.meta_field_groups_list', $parameters[0]); + self::assertSame('admin_ui_forms.content_edit.meta_field_groups_list', $parameters[0]); return ['metadata']; } diff --git a/tests/lib/Form/DataTransformer/UDWBasedValueViewTransformerTest.php b/tests/lib/Form/DataTransformer/UDWBasedValueViewTransformerTest.php index 087ae0eed3..95d101049d 100644 --- a/tests/lib/Form/DataTransformer/UDWBasedValueViewTransformerTest.php +++ b/tests/lib/Form/DataTransformer/UDWBasedValueViewTransformerTest.php @@ -67,8 +67,8 @@ public function testReverseTransform(?string $given, ?array $expected): void { $this->locationService ->method('loadLocation') - ->willReturnCallback(function ($id): Location { - return $this->createLocation($id); + ->willReturnCallback(static function ($id): Location { + return self::createLocation($id); }); self::assertEquals($expected, $this->transformer->reverseTransform($given)); diff --git a/tests/lib/Form/DataTransformer/UserTransformerTest.php b/tests/lib/Form/DataTransformer/UserTransformerTest.php index 78be7c03a7..18c20fad1d 100644 --- a/tests/lib/Form/DataTransformer/UserTransformerTest.php +++ b/tests/lib/Form/DataTransformer/UserTransformerTest.php @@ -30,7 +30,7 @@ protected function setUp(): void ->expects(self::any()) ->method('loadUser') ->with(123456) - ->willReturn($this->generateUser(123456)); + ->willReturn(self::generateUser(123456)); $this->userTransformer = new UserTransformer($userService); } diff --git a/tests/lib/Form/Processor/ContentTypeFormProcessorTest.php b/tests/lib/Form/Processor/ContentTypeFormProcessorTest.php index 54e78603cf..d8b17cdbe2 100644 --- a/tests/lib/Form/Processor/ContentTypeFormProcessorTest.php +++ b/tests/lib/Form/Processor/ContentTypeFormProcessorTest.php @@ -94,16 +94,16 @@ public function testProcessDefaultAction(): void $this->contentTypeService ->expects($matcher) - ->method('updateFieldDefinition')->willReturnCallback(function (...$parameters) use ($matcher, $contentTypeDraft, $fieldDef1, $fieldDefData1, $fieldDef2, $fieldDefData2): void { + ->method('updateFieldDefinition')->willReturnCallback(static function (...$parameters) use ($matcher, $contentTypeDraft, $fieldDef1, $fieldDefData1, $fieldDef2, $fieldDefData2): void { if ($matcher->numberOfInvocations() === 1) { - $this->assertSame($contentTypeDraft, $parameters[0]); - $this->assertSame($fieldDef1, $parameters[1]); - $this->assertSame($fieldDefData1, $parameters[2]); + self::assertSame($contentTypeDraft, $parameters[0]); + self::assertSame($fieldDef1, $parameters[1]); + self::assertSame($fieldDefData1, $parameters[2]); } if ($matcher->numberOfInvocations() === 2) { - $this->assertSame($contentTypeDraft, $parameters[0]); - $this->assertSame($fieldDef2, $parameters[1]); - $this->assertSame($fieldDefData2, $parameters[2]); + self::assertSame($contentTypeDraft, $parameters[0]); + self::assertSame($fieldDef2, $parameters[1]); + self::assertSame($fieldDefData2, $parameters[2]); } }); $this->contentTypeService diff --git a/tests/lib/Menu/Action/DraftListActionMenuBuilderTest.php b/tests/lib/Menu/Action/DraftListActionMenuBuilderTest.php index 9c8dcc85af..c43ac0b073 100644 --- a/tests/lib/Menu/Action/DraftListActionMenuBuilderTest.php +++ b/tests/lib/Menu/Action/DraftListActionMenuBuilderTest.php @@ -53,7 +53,7 @@ public function testBuildDraftListActionMenu(): void $this->mockUrlGeneratorGenerate(); $this->mockTranslatorTranslate(); - $menu = $this->actionMenuBuilder->build(['versionInfo' => $this->createVersionInfo()]); + $menu = $this->actionMenuBuilder->build(['versionInfo' => self::createVersionInfo()]); $this->assertActionItemSame( $menu, @@ -69,7 +69,7 @@ public function testBuildDraftListActionMenu(): void public function testAddUserUpdateItemAction(): void { - $versionInfo = $this->createVersionInfo(); + $versionInfo = self::createVersionInfo(); $user = self::createStub(Content::class); $this->mockUrlGeneratorGenerate(); diff --git a/tests/lib/Menu/Action/VersionListActionMenuBuilderTest.php b/tests/lib/Menu/Action/VersionListActionMenuBuilderTest.php index 2bc46f5cf2..61bca2ac9f 100644 --- a/tests/lib/Menu/Action/VersionListActionMenuBuilderTest.php +++ b/tests/lib/Menu/Action/VersionListActionMenuBuilderTest.php @@ -157,7 +157,7 @@ public static function provideDataForTestBuildVersionListActionMenu(): iterable public function testAddUserUpdateItemAction(): void { - $versionInfo = $this->createVersionInfo(); + $versionInfo = self::createVersionInfo(); $user = self::createStub(Content::class); $this->mockUrlGeneratorGenerate(); diff --git a/tests/lib/Pagination/Pagerfanta/URLSearchAdapterTest.php b/tests/lib/Pagination/Pagerfanta/URLSearchAdapterTest.php index 58980b5723..57e705fbab 100644 --- a/tests/lib/Pagination/Pagerfanta/URLSearchAdapterTest.php +++ b/tests/lib/Pagination/Pagerfanta/URLSearchAdapterTest.php @@ -38,11 +38,11 @@ public function testGetNbResults(): void $this->urlService ->expects(self::once()) ->method('findUrls') - ->willReturnCallback(function (URLQuery $q) use ($query, $searchResults): SearchResult { - $this->assertEquals($query->filter, $q->filter); - $this->assertEquals($query->sortClauses, $q->sortClauses); - $this->assertEquals(0, $q->offset); - $this->assertEquals(0, $q->limit); + ->willReturnCallback(static function (URLQuery $q) use ($query, $searchResults): SearchResult { + self::assertEquals($query->filter, $q->filter); + self::assertEquals($query->sortClauses, $q->sortClauses); + self::assertEquals(0, $q->offset); + self::assertEquals(0, $q->limit); return $searchResults; }); @@ -70,11 +70,11 @@ public function testGetSlice(): void $this->urlService ->expects(self::once()) ->method('findUrls') - ->willReturnCallback(function (URLQuery $q) use ($query, $limit, $offset, $searchResults): SearchResult { - $this->assertEquals($query->filter, $q->filter); - $this->assertEquals($query->sortClauses, $q->sortClauses); - $this->assertEquals($limit, $q->limit); - $this->assertEquals($offset, $q->offset); + ->willReturnCallback(static function (URLQuery $q) use ($query, $limit, $offset, $searchResults): SearchResult { + self::assertEquals($query->filter, $q->filter); + self::assertEquals($query->sortClauses, $q->sortClauses); + self::assertEquals($limit, $q->limit); + self::assertEquals($offset, $q->offset); return $searchResults; }); diff --git a/tests/lib/Pagination/Pagerfanta/URLWildcardAdapterTest.php b/tests/lib/Pagination/Pagerfanta/URLWildcardAdapterTest.php index f91c9710ae..299339794c 100644 --- a/tests/lib/Pagination/Pagerfanta/URLWildcardAdapterTest.php +++ b/tests/lib/Pagination/Pagerfanta/URLWildcardAdapterTest.php @@ -38,11 +38,11 @@ public function testGetNbResults(): void $this->urlWildcardService ->expects(self::once()) ->method('findUrlWildcards') - ->willReturnCallback(function (URLWildcardQuery $q) use ($query, $searchResults): SearchResult { - $this->assertEquals($query->filter, $q->filter); - $this->assertEquals($query->sortClauses, $q->sortClauses); - $this->assertEquals(0, $q->offset); - $this->assertEquals(0, $q->limit); + ->willReturnCallback(static function (URLWildcardQuery $q) use ($query, $searchResults): SearchResult { + self::assertEquals($query->filter, $q->filter); + self::assertEquals($query->sortClauses, $q->sortClauses); + self::assertEquals(0, $q->offset); + self::assertEquals(0, $q->limit); return $searchResults; }); @@ -66,11 +66,11 @@ public function testGetSlice(): void $this->urlWildcardService ->expects(self::once()) ->method('findUrlWildcards') - ->willReturnCallback(function (URLWildcardQuery $q) use ($query, $limit, $offset, $searchResults): SearchResult { - $this->assertEquals($query->filter, $q->filter); - $this->assertEquals($query->sortClauses, $q->sortClauses); - $this->assertEquals($limit, $q->limit); - $this->assertEquals($offset, $q->offset); + ->willReturnCallback(static function (URLWildcardQuery $q) use ($query, $limit, $offset, $searchResults): SearchResult { + self::assertEquals($query->filter, $q->filter); + self::assertEquals($query->sortClauses, $q->sortClauses); + self::assertEquals($limit, $q->limit); + self::assertEquals($offset, $q->offset); return $searchResults; });