Modernization: GSL 2.x Integration and Python 3.x Migration#1
Draft
JonathanPorta wants to merge 5 commits into
Draft
Modernization: GSL 2.x Integration and Python 3.x Migration#1JonathanPorta wants to merge 5 commits into
JonathanPorta wants to merge 5 commits into
Conversation
…ython Modernization of SOAP: GSL 2.x Integration and Python 3.x Migration
Author
|
@j-faria I opened this draft PR in an attempt to begin a dialogue in hopes of getting some of these changes merged into your codebase. Are you open to discussing this? I was likely overly cautious in my caveats in my version of your README. I can clean that up to better reflect the state of the situation if you are open to collaborating. |
|
Hi @JonathanPorta! Thank your for the suggestions. We have been privately working on an updated version of SOAP that we will make available soon. We are no longer using GSL and everything is written with Python 3.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a series of updates that modernize the SOAP repository, ensuring compatibility with newer versions of dependencies and programming language versions. The changes encompass updates from deprecated GSL 1.x calls to full support for GSL 2.x, along with a migration of the StarSpot module from Python 2.x to Python 3.x. These updates are a step towards maintaining the codebase's relevancy and efficiency, as well as improving security and compatibility for future developments.
Changes Included:
GSL 1.x to 2.x Transition: All deprecated GSL 1.x calls within the codebase have been updated to be compatible with GSL 2.x, aligning with modern standards and enhancing the library's functionality and performance.
StarSpot Module Python Migration: The StarSpot module has been migrated from Python 2.x to 3.x. This update is crucial given Python 2's end-of-life status, ensuring the code remains secure, stable, and takes advantage of the latest language features.
Dependency Locking with pipenv: Implementation of dependency locking utilizing pipenv has been added. This addition ensures a more reliable and consistent development and deployment environment by managing dependencies more effectively.
Impact: