Merge our projects?

[deitch]

Hi Iain,

This is great. I have a similar project that backs up MySQL databases, with a few key differences:

1. Adds timing (how often to back up, when to start)
2. Adds smb and local filesystem targets
3. Does not support AWS
4. Does not support database exclusions

Do you want to merge? Looks like we each got about 50% of it, and someone already has been asking at databacker/mysql-backup#2

[iainmckay]

Sorry for the delay, I'm open to the idea. How do you suggest proceeding?

[deitch]

No worries. Two options: pull yours into mine, or mine into yours, and then merge the project.

[clescot]

Hi,
the resulting merge would be very useful!
Hope to see the result soon.
best regards,

Charles.

[iainmckay]

This isn't an active project for me so I'm happy to merge this in to your project. I can add a note or a redirect from this repo to yours once the merge is complete.

How would you like to share the work?

[deitch]

I am impressed with how short your entrypoint is, just 88 lines! A big part of what I had to deal with was parsing different URLs to support file, smb, git, etc.

I will take a stab at writing tests, then hand it back and see what happens. I should give you write access to the project... done!

I find writing the tests the hardest, actually. But let's see what we can do.

[iainmckay]

Thanks.

The scope of mine was much smaller and I could skip a lot of environment/dependency validation because it was being run from inside a docker container where I could guarantee the existence of all dependencies. This allows for much fewer lines of code :)

Tests are a pain in the ass. Let me see what you come up with and I'll see if I can add anything.

[deitch]

@lukebarton added S3 support (I think based on yours) to the other one.

You are right, tests were a pain. I ended up using fake-s3 run in a container, then linked the running backup to it and checked the output. Check out https://github.com/deitch/mysql-backup/blob/master/test/test.sh and especially https://github.com/deitch/mysql-backup/blob/master/test/test.sh#L160

What is next to do to merge the functionality?

[lukebarton]

Having done a review of this project, I can't see any functionality that it offers over @deitch's project except for the exclusions.

[deitch]

@lukebarton we have been trying to merge them. Love it when people work together.

@iainmckay can you point out the exclusion lines and I will work on merging those?